From 5cc8a092574a3365863d9abf3b25a4b508bd5548 Mon Sep 17 00:00:00 2001 From: Victor Julien Date: Wed, 15 Aug 2012 17:13:33 +0200 Subject: [PATCH] stream: fix unittest broken by new flags handling. --- src/stream-tcp.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/src/stream-tcp.c b/src/stream-tcp.c index 6686649886..4ea3d4823b 100644 --- a/src/stream-tcp.c +++ b/src/stream-tcp.c @@ -5066,18 +5066,28 @@ static int StreamTcpTest06 (void) { tcph.th_flags = TH_FIN; p->tcph = &tcph; - if (StreamTcpPacket(&tv, p, &stt, &pq) == -1) + /* StreamTcpPacket returns -1 on unsolicited FIN */ + if (StreamTcpPacket(&tv, p, &stt, &pq) != -1) { + printf("StreamTcpPacket failed: "); goto end; + } - if (((TcpSession *)(p->flow->protoctx)) != NULL) + if (((TcpSession *)(p->flow->protoctx)) != NULL) { + printf("we have a ssn while we shouldn't: "); goto end; + } p->tcph->th_flags = TH_RST; - if (StreamTcpPacket(&tv, p, &stt, &pq) == -1) + /* StreamTcpPacket returns -1 on unsolicited RST */ + if (StreamTcpPacket(&tv, p, &stt, &pq) != -1) { + printf("StreamTcpPacket failed (2): "); goto end; + } - if (((TcpSession *)(p->flow->protoctx)) != NULL) + if (((TcpSession *)(p->flow->protoctx)) != NULL) { + printf("we have a ssn while we shouldn't (2): "); goto end; + } ret = 1; end: