detect/frames: fix coverity warning

Harmless warning, but it was correct in that the code made no sense:
1497420 Dereference before null check
pull/6860/head
Victor Julien 4 years ago
parent e902aaf838
commit 40c315aa35

@ -463,7 +463,7 @@ static void DetectFrameInspectEngineCopy(DetectEngineCtx *de_ctx, int sm_list, i
{ {
/* take the list from the detect engine as the buffers can be registered /* take the list from the detect engine as the buffers can be registered
* dynamically. */ * dynamically. */
const DetectEngineFrameInspectionEngine *t = de_ctx->frame_inspect_engines; DetectEngineFrameInspectionEngine *t = de_ctx->frame_inspect_engines;
while (t) { while (t) {
if (t->sm_list == sm_list) { if (t->sm_list == sm_list) {
DetectEngineFrameInspectionEngine *new_engine = DetectEngineFrameInspectionEngine *new_engine =
@ -479,16 +479,14 @@ static void DetectFrameInspectEngineCopy(DetectEngineCtx *de_ctx, int sm_list, i
new_engine->v1 = t->v1; new_engine->v1 = t->v1;
new_engine->v1.transforms = transforms; /* assign transforms */ new_engine->v1.transforms = transforms; /* assign transforms */
if (de_ctx->frame_inspect_engines == NULL) { /* append to the list */
de_ctx->frame_inspect_engines = new_engine; DetectEngineFrameInspectionEngine *list = t;
} else {
DetectEngineFrameInspectionEngine *list = de_ctx->frame_inspect_engines;
while (list->next != NULL) { while (list->next != NULL) {
list = list->next; list = list->next;
} }
list->next = new_engine; list->next = new_engine;
} break;
} }
t = t->next; t = t->next;
} }

Loading…
Cancel
Save