aiden
/
suricata
mirror of https://github.com/OISF/suricata
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

detect/byte: remove unneeded SIG_FLAG_APPLAYER sets

Browse Source 
Flag will be set during list(s) setup if needed.
pull/10052/head
Victor Julien 2 years ago
parent 804a40e036
commit 3ba8e2d3ea
2 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File

3
src/detect-byte-extract.c
Unescape Escape View File

@ -563,7 +563,6 @@ static int DetectByteExtractSetup(DetectEngineCtx *de_ctx, Signature *s, const c
if (DetectSignatureSetAppProto(s, ALPROTO_DCERPC) < 0)
goto error;
s->flags |= SIG_FLAG_APPLAYER;
} else if (data->flags & DETECT_BYTE_EXTRACT_FLAG_RELATIVE) {
prev_pm = DetectGetLastSMFromLists(s,
@ -576,8 +575,6 @@ static int DetectByteExtractSetup(DetectEngineCtx *de_ctx, Signature *s, const c
sm_list = SigMatchListSMBelongsTo(s, prev_pm);
if (sm_list < 0)
goto error;
if (sm_list != DETECT_SM_LIST_PMATCH)
s->flags |= SIG_FLAG_APPLAYER;
}
} else {

3
src/detect-bytemath.c
Unescape Escape View File

@ -325,7 +325,6 @@ static int DetectByteMathSetup(DetectEngineCtx *de_ctx, Signature *s, const char
if (DetectSignatureSetAppProto(s, ALPROTO_DCERPC) < 0)
goto error;
s->flags |= SIG_FLAG_APPLAYER;
} else if (data->flags & DETECT_BYTEMATH_FLAG_RELATIVE) {
prev_pm = DetectGetLastSMFromLists(s, DETECT_CONTENT, DETECT_PCRE,
@ -338,8 +337,6 @@ static int DetectByteMathSetup(DetectEngineCtx *de_ctx, Signature *s, const char
sm_list = SigMatchListSMBelongsTo(s, prev_pm);
if (sm_list < 0)
goto error;
if (sm_list != DETECT_SM_LIST_PMATCH)
s->flags |= SIG_FLAG_APPLAYER;
}
} else {

Write Preview
Loading…
Cancel
Save