From 3a017f61b0a1f5e7f69321c2fb7b06a17f4b57c3 Mon Sep 17 00:00:00 2001
From: Pierre Chifflier <chifflier@wzdftpd.net>
Date: Thu, 19 Apr 2018 11:04:01 +0200
Subject: [PATCH] Kerberos 5: pretty-print error code when logging

---
 rust/Cargo.toml.in   | 2 +-
 rust/src/krb/krb5.rs | 4 ++--
 rust/src/krb/log.rs  | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/rust/Cargo.toml.in b/rust/Cargo.toml.in
index 5e3a411ce6..470829451e 100644
--- a/rust/Cargo.toml.in
+++ b/rust/Cargo.toml.in
@@ -19,7 +19,7 @@ nom = "~3.2.1"
 libc = "^0.2.36"
 crc = "~1.7.0"
 der-parser = "0.5.2"
-kerberos-parser = "0.1.2"
+kerberos-parser = "0.1.3"
 
 ntp-parser = "0.2.0"
 ipsec-parser = "~0.3.0"
diff --git a/rust/src/krb/krb5.rs b/rust/src/krb/krb5.rs
index 24cb8414f2..d6573ff861 100644
--- a/rust/src/krb/krb5.rs
+++ b/rust/src/krb/krb5.rs
@@ -23,7 +23,7 @@ use std::ffi::{CStr,CString};
 use nom::{IResult,be_u32};
 use der_parser::der_read_element_header;
 use kerberos_parser::krb5_parser;
-use kerberos_parser::krb5::{EncryptionType,MessageType,PrincipalName,Realm};
+use kerberos_parser::krb5::{EncryptionType,ErrorCode,MessageType,PrincipalName,Realm};
 use applayer;
 use core;
 use core::{AppProto,Flow,ALPROTO_FAILED,ALPROTO_UNKNOWN,STREAM_TOCLIENT,STREAM_TOSERVER,sc_detect_engine_state_free};
@@ -62,7 +62,7 @@ pub struct KRB5Transaction {
     pub etype: Option<EncryptionType>,
 
     /// Error code, if request has failed
-    pub error_code: Option<i32>,
+    pub error_code: Option<ErrorCode>,
 
     /// The internal transaction id
     id: u64,
diff --git a/rust/src/krb/log.rs b/rust/src/krb/log.rs
index a0768884ba..c910d11ffc 100644
--- a/rust/src/krb/log.rs
+++ b/rust/src/krb/log.rs
@@ -28,7 +28,7 @@ pub extern "C" fn rs_krb5_log_json_response(_state: &mut KRB5State, tx: &mut KRB
         Some(c) => {
             js.set_string("msg_type", "KRB_ERROR");
             js.set_string("failed_request", &format!("{:?}", tx.msg_type));
-            js.set_string("error_code", &format!("{}", c));
+            js.set_string("error_code", &format!("{:?}", c));
         },
         None    => { js.set_string("msg_type", &format!("{:?}", tx.msg_type)); },
     }