aiden
/
suricata
mirror of https://github.com/OISF/suricata
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: unify how warnings specify ticket id's

Browse Source
pull/8198/head
Victor Julien 4 years ago
parent 0c00f28ebc
commit 2edfff7a0c
5 changed files with 20 additions and 19 deletions
Show Stats Download Patch File Download Diff File

2
src/detect-engine-address.c
Unescape Escape View File

@ -462,7 +462,7 @@ static int DetectAddressParseString(DetectAddress *dd, const char *str)
if (cidr < 0) { if (cidr < 0) {
SCLogError(SC_ERR_INVALID_SIGNATURE, SCLogError(SC_ERR_INVALID_SIGNATURE,
"netmask \"%s\" is not usable. Only netmasks that are compatible with " "netmask \"%s\" is not usable. Only netmasks that are compatible with "
"CIDR notation are supported. See #5168.", "CIDR notation are supported. See ticket #5168.",
mask); mask);
goto error; goto error;
} }

5
src/output-json-stats.c
Unescape Escape View File

@ -401,8 +401,9 @@ static OutputInitResult OutputStatsLogInitSub(ConfNode *conf, OutputCtx *parent_
if (stats_decoder_events && if (stats_decoder_events &&
strcmp(stats_decoder_events_prefix, "decoder") == 0) { strcmp(stats_decoder_events_prefix, "decoder") == 0) {
SCLogWarning(SC_WARN_EVE_MISSING_EVENTS, "eve.stats will not display " SCLogWarning(SC_WARN_EVE_MISSING_EVENTS,
"all decoder events correctly. See #2225. Set a prefix in " "eve.stats will not display "
"all decoder events correctly. See ticket #2225. Set a prefix in "
"stats.decoder-events-prefix."); "stats.decoder-events-prefix.");
} }

18
src/runmodes.c
Unescape Escape View File

@ -797,18 +797,16 @@ void RunModeInitializeOutputs(void)
} }
if (strcmp(output->val, "file-log") == 0) { if (strcmp(output->val, "file-log") == 0) {
SCLogWarning(SC_ERR_NOT_SUPPORTED, SCLogWarning(SC_ERR_NOT_SUPPORTED, "file-log is no longer supported,"
"file-log is no longer supported," " use eve.files instead "
" use eve.files instead " "(see ticket #2376"
"(see https://redmine.openinfosecfoundation.org/issues/2376" " for an explanation)");
" for an explanation)");
continue; continue;
} else if (strncmp(output->val, "unified-", sizeof("unified-") - 1) == 0) { } else if (strncmp(output->val, "unified-", sizeof("unified-") - 1) == 0) {
SCLogWarning(SC_ERR_NOT_SUPPORTED, SCLogWarning(SC_ERR_NOT_SUPPORTED, "Unified1 is no longer supported,"
"Unified1 is no longer supported," " use Unified2 instead "
" use Unified2 instead " "(see ticket #353"
"(see https://redmine.openinfosecfoundation.org/issues/353" " for an explanation)");
" for an explanation)");
continue; continue;
} else if (strncmp(output->val, "unified2-", sizeof("unified2-") - 1) == 0) { } else if (strncmp(output->val, "unified2-", sizeof("unified2-") - 1) == 0) {
SCLogWarning(SC_ERR_NOT_SUPPORTED, SCLogWarning(SC_ERR_NOT_SUPPORTED,

2
src/source-pfring.c
Unescape Escape View File

@ -262,7 +262,7 @@ static inline void PfringProcessPacket(void *user, struct pfring_pkthdr *h, Pack
if (!ptv->vlan_hdr_warned) { if (!ptv->vlan_hdr_warned) {
SCLogWarning(SC_ERR_PF_RING_VLAN, "no VLAN header in the raw " SCLogWarning(SC_ERR_PF_RING_VLAN, "no VLAN header in the raw "
"packet. See #2355."); "packet. See ticket #2355.");
ptv->vlan_hdr_warned = true; ptv->vlan_hdr_warned = true;
} }
} }

12
src/util-luajit.c
Unescape Escape View File

@ -109,9 +109,9 @@ void LuajitFreeStatesPool(void)
pthread_mutex_lock(&luajit_states_lock); pthread_mutex_lock(&luajit_states_lock);
if (luajit_states_cnt_max > luajit_states_size) { if (luajit_states_cnt_max > luajit_states_size) {
SCLogNotice("luajit states used %d is bigger than pool size %d. Set " SCLogNotice("luajit states used %d is bigger than pool size %d. Set "
"luajit.states to %d to avoid memory issues. " "luajit.states to %d to avoid memory issues. "
"See #1577 and #1955.", luajit_states_cnt_max, luajit_states_size, "See tickets #1577 and #1955.",
luajit_states_cnt_max); luajit_states_cnt_max, luajit_states_size, luajit_states_cnt_max);
} }
PoolFree(luajit_states); PoolFree(luajit_states);
luajit_states = NULL; luajit_states = NULL;
@ -128,9 +128,11 @@ lua_State *LuajitGetState(void)
s = (lua_State *)PoolGet(luajit_states); s = (lua_State *)PoolGet(luajit_states);
if (s != NULL) { if (s != NULL) {
if (luajit_states_cnt == luajit_states_size) { if (luajit_states_cnt == luajit_states_size) {
SCLogWarning(SC_WARN_LUA_SCRIPT, "luajit states pool size %d " SCLogWarning(SC_WARN_LUA_SCRIPT,
"luajit states pool size %d "
"reached. Increase luajit.states config option. " "reached. Increase luajit.states config option. "
"See #1577 and #1955", luajit_states_size); "See tickets #1577 and #1955",
luajit_states_size);
} }
luajit_states_cnt++; luajit_states_cnt++;

Write Preview
Loading…
Cancel
Save