From 2913a4a86084441a2e9504bcd32a373f15aa65a9 Mon Sep 17 00:00:00 2001 From: Victor Julien Date: Wed, 11 Dec 2013 13:26:55 +0100 Subject: [PATCH] debug: fix realloc error checking on flowbit print detect.c:1074:17: warning: Potential leak of memory pointed to by \ field 'debuglog_flowbits_names' return; Bug #1062. --- src/detect.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/detect.c b/src/detect.c index 7c8f55a922..682c8bb4ff 100644 --- a/src/detect.c +++ b/src/detect.c @@ -1067,12 +1067,16 @@ static void AlertDebugLogModeSyncFlowbitsNamesToPacketStruct(Packet *p, DetectEn if (i == p->debuglog_flowbits_names_len) { p->debuglog_flowbits_names_len += MALLOC_JUMP; - p->debuglog_flowbits_names = SCRealloc(p->debuglog_flowbits_names, + const char **names = SCRealloc(p->debuglog_flowbits_names, sizeof(char *) * p->debuglog_flowbits_names_len); - if (p->debuglog_flowbits_names == NULL) { + if (names == NULL) { + SCFree(p->debuglog_flowbits_names); + p->debuglog_flowbits_names = NULL; + p->debuglog_flowbits_names_len = 0; return; } + p->debuglog_flowbits_names = names; memset(p->debuglog_flowbits_names + p->debuglog_flowbits_names_len - MALLOC_JUMP, 0, sizeof(char *) * MALLOC_JUMP);