Don't warn about non enable non existing output module

This patch modifies output module loading to only trigger alert
message for non existing modules when they are loaded. It also
warn about unified1 removal.
remotes/origin/master-1.1.x
Eric Leblond 14 years ago committed by Victor Julien
parent 3944357058
commit 24f15fa321

@ -334,14 +334,7 @@ void RunModeInitializeOutputs(void)
if (strcmp(output->val, "stats") == 0)
continue;
OutputModule *module = OutputGetModuleByConfName(output->val);
if (module == NULL) {
SCLogWarning(SC_ERR_INVALID_ARGUMENT,
"No output module named %s, ignoring", output->val);
continue;
}
output_config = ConfNodeLookupChild(output, module->conf_name);
output_config = ConfNodeLookupChild(output, output->val);
if (output_config == NULL) {
/* Shouldn't happen. */
SCLogError(SC_ERR_INVALID_ARGUMENT,
@ -350,7 +343,26 @@ void RunModeInitializeOutputs(void)
}
enabled = ConfNodeLookupChildValue(output_config, "enabled");
if (enabled != NULL && ConfValIsTrue(enabled)) {
if (enabled == NULL || !ConfValIsTrue(enabled)) {
continue;
}
if (strncmp(output->val, "unified-", sizeof("unified-") - 1) == 0) {
SCLogWarning(SC_ERR_INVALID_ARGUMENT,
"Unified1 is no longer supported,"
" use Unified2 instead "
"(see https://redmine.openinfosecfoundation.org/issues/353"
" for an explanation)");
continue;
}
OutputModule *module = OutputGetModuleByConfName(output->val);
if (module == NULL) {
SCLogWarning(SC_ERR_INVALID_ARGUMENT,
"No output module named %s, ignoring", output->val);
continue;
}
OutputCtx *output_ctx = NULL;
if (module->InitFunc != NULL) {
output_ctx = module->InitFunc(output_config);
@ -373,7 +385,6 @@ void RunModeInitializeOutputs(void)
runmode_output->output_ctx = output_ctx;
TAILQ_INSERT_TAIL(&RunModeOutputs, runmode_output, entries);
}
}
}
/**

Loading…
Cancel
Save