From 1e13f7278585555623ff0be2d3a98476617b1219 Mon Sep 17 00:00:00 2001 From: Victor Julien Date: Wed, 27 Apr 2022 11:38:37 +0200 Subject: [PATCH] ja3: fix minor format string warning cppcheck: src/util-ja3.c:197:28: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] (*buffer)->used += snprintf((*buffer)->data, (*buffer)->size, "%d", ^ src/util-ja3.c:201:28: warning: %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [invalidPrintfArgType_sint] (*buffer)->used += snprintf((*buffer)->data + (*buffer)->used, ^ Bug: #5291. --- src/util-ja3.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/util-ja3.c b/src/util-ja3.c index a2fee4efb3..f3b455d7c4 100644 --- a/src/util-ja3.c +++ b/src/util-ja3.c @@ -194,13 +194,11 @@ int Ja3BufferAddValue(JA3Buffer **buffer, uint32_t value) } if ((*buffer)->used == 0) { - (*buffer)->used += snprintf((*buffer)->data, (*buffer)->size, "%d", - value); + (*buffer)->used += snprintf((*buffer)->data, (*buffer)->size, "%u", value); } else { - (*buffer)->used += snprintf((*buffer)->data + (*buffer)->used, - (*buffer)->size - (*buffer)->used, "-%d", - value); + (*buffer)->used += snprintf( + (*buffer)->data + (*buffer)->used, (*buffer)->size - (*buffer)->used, "-%u", value); } return 0;