detect/http2: don't double register engines

Each keyword supporting DOH2 must register explicitly
pull/15846/head
Victor Julien 3 months ago
parent 416b9c12ae
commit 1bb843d83f

@ -107,11 +107,6 @@ static void RegisterInternal(const char *name, int direction, int priority,
FatalError("MPM engine registration for %s failed", name);
}
// every HTTP2 can be accessed from DOH2
if (alproto == ALPROTO_HTTP2 || alproto == ALPROTO_DNS) {
RegisterInternal(name, direction, priority, PrefilterRegister, GetData, GetDataSingle,
GetMultiData, ALPROTO_DOH2, sub_state, tx_min_progress);
}
DetectBufferMpmRegistry *am = SCCalloc(1, sizeof(*am));
BUG_ON(am == NULL);
am->name = name;

@ -236,12 +236,6 @@ static void AppLayerInspectEngineRegisterInternal(const char *name, AppProto alp
} else {
direction = 1;
}
// every DNS or HTTP2 can be accessed from DOH2
if (alproto == ALPROTO_HTTP2 || alproto == ALPROTO_DNS) {
AppLayerInspectEngineRegisterInternal(name, ALPROTO_DOH2, dir, sub_state, progress,
Callback, GetData, GetDataSingle, GetMultiData);
}
DetectEngineAppInspectionEngine *new_engine =
SCCalloc(1, sizeof(DetectEngineAppInspectionEngine));
if (unlikely(new_engine == NULL)) {

Loading…
Cancel
Save