pgsql: remove unused msg field

The `ConsolidatedDataRow` struct had a `length` field that wasn't truly
used.

Related to
Bug #6389
pull/10076/head
Juliana Fajardini 2 years ago committed by Victor Julien
parent 3103505cb0
commit 1afb485dfa

@ -234,7 +234,6 @@ fn log_response(res: &PgsqlBEMessage, jb: &mut JsonBuilder) -> Result<(), JsonEr
} }
PgsqlBEMessage::ConsolidatedDataRow(ConsolidatedDataRowPacket { PgsqlBEMessage::ConsolidatedDataRow(ConsolidatedDataRowPacket {
identifier: _, identifier: _,
length: _,
row_cnt, row_cnt,
data_size, data_size,
}) => { }) => {

@ -210,7 +210,6 @@ pub struct BackendKeyDataMessage {
#[derive(Debug, PartialEq, Eq)] #[derive(Debug, PartialEq, Eq)]
pub struct ConsolidatedDataRowPacket { pub struct ConsolidatedDataRowPacket {
pub identifier: u8, pub identifier: u8,
pub length: u32,
pub row_cnt: u16, pub row_cnt: u16,
pub data_size: u64, pub data_size: u64,
} }
@ -924,7 +923,6 @@ pub fn parse_consolidated_data_row(i: &[u8]) -> IResult<&[u8], PgsqlBEMessage> {
Ok((i, PgsqlBEMessage::ConsolidatedDataRow( Ok((i, PgsqlBEMessage::ConsolidatedDataRow(
ConsolidatedDataRowPacket { ConsolidatedDataRowPacket {
identifier, identifier,
length,
row_cnt: 1, row_cnt: 1,
data_size: add_up_data_size(rows), data_size: add_up_data_size(rows),
} }

@ -487,7 +487,6 @@ impl PgsqlState {
let dummy_resp = let dummy_resp =
PgsqlBEMessage::ConsolidatedDataRow(ConsolidatedDataRowPacket { PgsqlBEMessage::ConsolidatedDataRow(ConsolidatedDataRowPacket {
identifier: b'D', identifier: b'D',
length: tx.get_row_cnt() as u32, // TODO this is ugly. We can probably get rid of `length` field altogether...
row_cnt: tx.get_row_cnt(), row_cnt: tx.get_row_cnt(),
data_size: tx.data_size, // total byte count of all data_row messages combined data_size: tx.data_size, // total byte count of all data_row messages combined
}); });

Loading…
Cancel
Save