aiden
/
suricata
mirror of https://github.com/OISF/suricata
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

xbits: fix coverity warnings

Browse Source 
Switch statement would contain NOALERT even though this was
unreachable.
pull/1454/head
Victor Julien 10 years ago
parent 54d5e2eed5
commit 1a83fee5f5
3 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File

4
src/detect-flowbits.c
Unescape Escape View File

@ -260,9 +260,7 @@ int DetectFlowbitSetup (DetectEngineCtx *de_ctx, Signature *s, char *rawstr)
sm->ctx = (SigMatchCtx *)cd; sm->ctx = (SigMatchCtx *)cd;
switch (fb_cmd) { switch (fb_cmd) {
case DETECT_FLOWBITS_CMD_NOALERT: /* case DETECT_FLOWBITS_CMD_NOALERT can't happen here */
/* nothing to do */
break;
case DETECT_FLOWBITS_CMD_ISNOTSET: case DETECT_FLOWBITS_CMD_ISNOTSET:
case DETECT_FLOWBITS_CMD_ISSET: case DETECT_FLOWBITS_CMD_ISSET:

4
src/detect-hostbits.c
Unescape Escape View File

@ -403,9 +403,7 @@ int DetectHostbitSetup (DetectEngineCtx *de_ctx, Signature *s, char *rawstr)
sm->ctx = (void *)cd; sm->ctx = (void *)cd;
switch (fb_cmd) { switch (fb_cmd) {
case DETECT_XBITS_CMD_NOALERT: /* case DETECT_XBITS_CMD_NOALERT can't happen here */
/* nothing to do */
break;
case DETECT_XBITS_CMD_ISNOTSET: case DETECT_XBITS_CMD_ISNOTSET:
case DETECT_XBITS_CMD_ISSET: case DETECT_XBITS_CMD_ISSET:

4
src/detect-xbits.c
Unescape Escape View File

@ -327,9 +327,7 @@ int DetectXbitSetup (DetectEngineCtx *de_ctx, Signature *s, char *rawstr)
sm->ctx = (void *)cd; sm->ctx = (void *)cd;
switch (fb_cmd) { switch (fb_cmd) {
case DETECT_XBITS_CMD_NOALERT: /* case DETECT_XBITS_CMD_NOALERT can't happen here */
/* nothing to do */
break;
case DETECT_XBITS_CMD_ISNOTSET: case DETECT_XBITS_CMD_ISNOTSET:
case DETECT_XBITS_CMD_ISSET: case DETECT_XBITS_CMD_ISSET:

Write Preview
Loading…
Cancel
Save