From 15c67bfbd2b7f67012de790aa9dcc24e825aa435 Mon Sep 17 00:00:00 2001 From: Victor Julien Date: Fri, 9 Apr 2010 14:17:08 +0200 Subject: [PATCH] Fix locking issue in the uri scanning code. --- src/detect-engine-uri.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/detect-engine-uri.c b/src/detect-engine-uri.c index 26d28cb395..14b86b2a26 100644 --- a/src/detect-engine-uri.c +++ b/src/detect-engine-uri.c @@ -243,14 +243,13 @@ int DetectEngineInspectPacketUris(DetectEngineCtx *de_ctx, { SCEnter(); SigMatch *sm = NULL; - int r = 1; + int r = 0; HtpState *htp_state = NULL; htp_state = (HtpState *)alstate; if (htp_state == NULL) { SCLogDebug("no HTTP state"); - r = 0; - goto end; + SCReturnInt(0); } /* locking the flow, we will inspect the htp state */ @@ -259,7 +258,6 @@ int DetectEngineInspectPacketUris(DetectEngineCtx *de_ctx, /* if we don't have a uri, don't bother inspecting */ if (det_ctx->de_have_httpuri == FALSE) { SCLogDebug("We don't have uri"); - r = 0; goto end; }