From 13c8724ae0cbc300914413aacd239645699a42a4 Mon Sep 17 00:00:00 2001
From: Shivani Bhardwaj <shivani@oisf.net>
Date: Mon, 3 Nov 2025 11:32:10 +0530
Subject: [PATCH] detect/xbits: remove unneeded cast to check ptr validity

---
 src/detect-xbits.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/detect-xbits.c b/src/detect-xbits.c
index bb88c008ab..1c87ca84f3 100644
--- a/src/detect-xbits.c
+++ b/src/detect-xbits.c
@@ -455,10 +455,10 @@ int DetectXbitSetup (DetectEngineCtx *de_ctx, Signature *s, const char *rawstr)
 
 static void DetectXbitFree (DetectEngineCtx *de_ctx, void *ptr)
 {
-    DetectXbitsData *fd = (DetectXbitsData *)ptr;
-
-    if (fd == NULL)
+    if (ptr == NULL)
         return;
+
+    DetectXbitsData *fd = (DetectXbitsData *)ptr;
     VarNameStoreUnregister(fd->idx, fd->type);
 
     SCFree(fd);