Fix potential prelude recourse leak during initialization

15 years ago · 0f458495c7
parent db94f01831
commit 0f458495c7
1 changed files with 8 additions and 2 deletions
--- a/src/alert-prelude.c
+++ b/src/alert-prelude.c
@ -858,8 +858,14 @@ OutputCtx *AlertPreludeInitCtx(ConfNode *conf)
        ctx->log_packet_header = 0;

    output_ctx = SCMalloc(sizeof(OutputCtx));
-    if (output_ctx == NULL)
-        return NULL;
+    if (output_ctx == NULL) {
+        SCFree(ctx);
+
+        prelude_perror(ret, "Unable to allocate memory");
+        prelude_client_destroy(client, PRELUDE_CLIENT_EXIT_STATUS_SUCCESS);
+        SCReturnPtr(NULL, "AlertPreludeCtx");
+    }
+
    output_ctx->data = ctx;
    output_ctx->DeInit = AlertPreludeDeinitCtx;