isdataat: fix mem leak in error path

6 years ago · 0d0da7880e
parent 2ef2febc7c
commit 0d0da7880e
1 changed files with 3 additions and 0 deletions
--- a/src/detect-isdataat.c
+++ b/src/detect-isdataat.c
@ -251,6 +251,7 @@ int DetectIsdataatSetup (DetectEngineCtx *de_ctx, Signature *s, const char *isda
        idad->flags |= ISDATAAT_OFFSET_BE;
        SCLogDebug("isdataat uses byte_extract with local id %u", idad->dataat);
        SCFree(offset);
+        offset = NULL;
    }

    /* 'ends with' scenario */
@ -293,6 +294,8 @@ int DetectIsdataatSetup (DetectEngineCtx *de_ctx, Signature *s, const char *isda
    ret = 0;

 end:
+    if (offset)
+        SCFree(offset);
    if (ret != 0)
        DetectIsdataatFree(idad);
    return ret;