diff --git a/src/detect-engine-hcd.c b/src/detect-engine-hcd.c index 21d5646d6e..29790f03a3 100644 --- a/src/detect-engine-hcd.c +++ b/src/detect-engine-hcd.c @@ -303,10 +303,6 @@ static int DetectEngineHttpCookieTest01(void) end: if (alp_tctx != NULL) AppLayerParserThreadCtxFree(alp_tctx); - if (de_ctx != NULL) - SigGroupCleanup(de_ctx); - if (de_ctx != NULL) - SigCleanSignatures(de_ctx); if (de_ctx != NULL) DetectEngineCtxFree(de_ctx); @@ -402,10 +398,6 @@ static int DetectEngineHttpCookieTest02(void) end: if (alp_tctx != NULL) AppLayerParserThreadCtxFree(alp_tctx); - if (de_ctx != NULL) - SigGroupCleanup(de_ctx); - if (de_ctx != NULL) - SigCleanSignatures(de_ctx); if (de_ctx != NULL) DetectEngineCtxFree(de_ctx); @@ -501,10 +493,6 @@ static int DetectEngineHttpCookieTest03(void) end: if (alp_tctx != NULL) AppLayerParserThreadCtxFree(alp_tctx); - if (de_ctx != NULL) - SigGroupCleanup(de_ctx); - if (de_ctx != NULL) - SigCleanSignatures(de_ctx); if (de_ctx != NULL) DetectEngineCtxFree(de_ctx); @@ -600,10 +588,6 @@ static int DetectEngineHttpCookieTest04(void) end: if (alp_tctx != NULL) AppLayerParserThreadCtxFree(alp_tctx); - if (de_ctx != NULL) - SigGroupCleanup(de_ctx); - if (de_ctx != NULL) - SigCleanSignatures(de_ctx); if (de_ctx != NULL) DetectEngineCtxFree(de_ctx); @@ -699,10 +683,6 @@ static int DetectEngineHttpCookieTest05(void) end: if (alp_tctx != NULL) AppLayerParserThreadCtxFree(alp_tctx); - if (de_ctx != NULL) - SigGroupCleanup(de_ctx); - if (de_ctx != NULL) - SigCleanSignatures(de_ctx); if (de_ctx != NULL) DetectEngineCtxFree(de_ctx); @@ -798,10 +778,6 @@ static int DetectEngineHttpCookieTest06(void) end: if (alp_tctx != NULL) AppLayerParserThreadCtxFree(alp_tctx); - if (de_ctx != NULL) - SigGroupCleanup(de_ctx); - if (de_ctx != NULL) - SigCleanSignatures(de_ctx); if (de_ctx != NULL) DetectEngineCtxFree(de_ctx); @@ -897,10 +873,6 @@ static int DetectEngineHttpCookieTest07(void) end: if (alp_tctx != NULL) AppLayerParserThreadCtxFree(alp_tctx); - if (de_ctx != NULL) - SigGroupCleanup(de_ctx); - if (de_ctx != NULL) - SigCleanSignatures(de_ctx); if (de_ctx != NULL) DetectEngineCtxFree(de_ctx); @@ -996,10 +968,6 @@ static int DetectEngineHttpCookieTest08(void) end: if (alp_tctx != NULL) AppLayerParserThreadCtxFree(alp_tctx); - if (de_ctx != NULL) - SigGroupCleanup(de_ctx); - if (de_ctx != NULL) - SigCleanSignatures(de_ctx); if (de_ctx != NULL) DetectEngineCtxFree(de_ctx); @@ -1095,10 +1063,6 @@ static int DetectEngineHttpCookieTest09(void) end: if (alp_tctx != NULL) AppLayerParserThreadCtxFree(alp_tctx); - if (de_ctx != NULL) - SigGroupCleanup(de_ctx); - if (de_ctx != NULL) - SigCleanSignatures(de_ctx); if (de_ctx != NULL) DetectEngineCtxFree(de_ctx); @@ -1195,10 +1159,6 @@ static int DetectEngineHttpCookieTest10(void) end: if (alp_tctx != NULL) AppLayerParserThreadCtxFree(alp_tctx); - if (de_ctx != NULL) - SigGroupCleanup(de_ctx); - if (de_ctx != NULL) - SigCleanSignatures(de_ctx); if (de_ctx != NULL) DetectEngineCtxFree(de_ctx); @@ -1295,10 +1255,6 @@ static int DetectEngineHttpCookieTest11(void) end: if (alp_tctx != NULL) AppLayerParserThreadCtxFree(alp_tctx); - if (de_ctx != NULL) - SigGroupCleanup(de_ctx); - if (de_ctx != NULL) - SigCleanSignatures(de_ctx); if (de_ctx != NULL) DetectEngineCtxFree(de_ctx); @@ -1395,10 +1351,6 @@ static int DetectEngineHttpCookieTest12(void) end: if (alp_tctx != NULL) AppLayerParserThreadCtxFree(alp_tctx); - if (de_ctx != NULL) - SigGroupCleanup(de_ctx); - if (de_ctx != NULL) - SigCleanSignatures(de_ctx); if (de_ctx != NULL) DetectEngineCtxFree(de_ctx); @@ -1495,10 +1447,6 @@ static int DetectEngineHttpCookieTest13(void) end: if (alp_tctx != NULL) AppLayerParserThreadCtxFree(alp_tctx); - if (de_ctx != NULL) - SigGroupCleanup(de_ctx); - if (de_ctx != NULL) - SigCleanSignatures(de_ctx); if (de_ctx != NULL) DetectEngineCtxFree(de_ctx); @@ -1595,10 +1543,6 @@ static int DetectEngineHttpCookieTest14(void) end: if (alp_tctx != NULL) AppLayerParserThreadCtxFree(alp_tctx); - if (de_ctx != NULL) - SigGroupCleanup(de_ctx); - if (de_ctx != NULL) - SigCleanSignatures(de_ctx); if (de_ctx != NULL) DetectEngineCtxFree(de_ctx); @@ -1695,10 +1639,6 @@ static int DetectEngineHttpCookieTest15(void) end: if (alp_tctx != NULL) AppLayerParserThreadCtxFree(alp_tctx); - if (de_ctx != NULL) - SigGroupCleanup(de_ctx); - if (de_ctx != NULL) - SigCleanSignatures(de_ctx); if (de_ctx != NULL) DetectEngineCtxFree(de_ctx); @@ -1795,10 +1735,6 @@ static int DetectEngineHttpCookieTest16(void) end: if (alp_tctx != NULL) AppLayerParserThreadCtxFree(alp_tctx); - if (de_ctx != NULL) - SigGroupCleanup(de_ctx); - if (de_ctx != NULL) - SigCleanSignatures(de_ctx); if (de_ctx != NULL) DetectEngineCtxFree(de_ctx); @@ -1895,10 +1831,6 @@ static int DetectEngineHttpCookieTest17(void) end: if (alp_tctx != NULL) AppLayerParserThreadCtxFree(alp_tctx); - if (de_ctx != NULL) - SigGroupCleanup(de_ctx); - if (de_ctx != NULL) - SigCleanSignatures(de_ctx); if (de_ctx != NULL) DetectEngineCtxFree(de_ctx); diff --git a/src/detect-http-cookie.c b/src/detect-http-cookie.c index 90e02af79c..f337787479 100644 --- a/src/detect-http-cookie.c +++ b/src/detect-http-cookie.c @@ -1,4 +1,4 @@ -/* Copyright (C) 2007-2010 Open Information Security Foundation +/* Copyright (C) 2007-2018 Open Information Security Foundation * * You can copy, redistribute or modify this Program under the terms of * the GNU General Public License version 2 as published by the Free @@ -63,7 +63,6 @@ static int DetectHttpCookieSetup (DetectEngineCtx *, Signature *, const char *); static void DetectHttpCookieRegisterTests(void); -static void DetectHttpCookieFree(void *); static int g_http_cookie_buffer_id = 0; /** @@ -74,9 +73,7 @@ void DetectHttpCookieRegister(void) sigmatch_table[DETECT_AL_HTTP_COOKIE].name = "http_cookie"; sigmatch_table[DETECT_AL_HTTP_COOKIE].desc = "content modifier to match only on the HTTP cookie-buffer"; sigmatch_table[DETECT_AL_HTTP_COOKIE].url = DOC_URL DOC_VERSION "/rules/http-keywords.html#http-cookie"; - sigmatch_table[DETECT_AL_HTTP_COOKIE].Match = NULL; sigmatch_table[DETECT_AL_HTTP_COOKIE].Setup = DetectHttpCookieSetup; - sigmatch_table[DETECT_AL_HTTP_COOKIE].Free = DetectHttpCookieFree; sigmatch_table[DETECT_AL_HTTP_COOKIE].RegisterTests = DetectHttpCookieRegisterTests; sigmatch_table[DETECT_AL_HTTP_COOKIE].flags |= SIGMATCH_NOOPT; @@ -99,21 +96,6 @@ void DetectHttpCookieRegister(void) g_http_cookie_buffer_id = DetectBufferTypeGetByName("http_cookie"); } -/** - * \brief this function clears the memory of http_cookie modifier keyword - * - * \param ptr Pointer to the Detection Cookie data - */ -void DetectHttpCookieFree(void *ptr) -{ - DetectContentData *hcd = (DetectContentData *)ptr; - if (hcd == NULL) - return; - if (hcd->content != NULL) - SCFree(hcd->content); - SCFree(hcd); -} - /** * \brief this function setups the http_cookie modifier keyword used in the rule * @@ -257,7 +239,6 @@ static int DetectHttpCookieTest04(void) result = 1; end: - if (de_ctx != NULL) SigCleanSignatures(de_ctx); if (de_ctx != NULL) DetectEngineCtxFree(de_ctx); return result; } @@ -282,7 +263,6 @@ static int DetectHttpCookieTest05(void) result = 1; end: - if (de_ctx != NULL) SigCleanSignatures(de_ctx); if (de_ctx != NULL) DetectEngineCtxFree(de_ctx); return result; } @@ -427,7 +407,6 @@ end: DetectEngineThreadCtxDeinit(&th_v, (void *)det_ctx); } if (de_ctx != NULL) { - SigGroupCleanup(de_ctx); DetectEngineCtxFree(de_ctx); } @@ -523,7 +502,6 @@ end: DetectEngineThreadCtxDeinit(&th_v, (void *)det_ctx); } if (de_ctx != NULL) { - SigGroupCleanup(de_ctx); DetectEngineCtxFree(de_ctx); } StreamTcpFreeConfig(TRUE); @@ -616,7 +594,6 @@ end: DetectEngineThreadCtxDeinit(&th_v, (void *)det_ctx); } if (de_ctx != NULL) { - SigGroupCleanup(de_ctx); DetectEngineCtxFree(de_ctx); } @@ -711,7 +688,6 @@ end: DetectEngineThreadCtxDeinit(&th_v, (void *)det_ctx); } if (de_ctx != NULL) { - SigGroupCleanup(de_ctx); DetectEngineCtxFree(de_ctx); } @@ -806,7 +782,6 @@ end: DetectEngineThreadCtxDeinit(&th_v, (void *)det_ctx); } if (de_ctx != NULL) { - SigGroupCleanup(de_ctx); DetectEngineCtxFree(de_ctx); } @@ -901,7 +876,6 @@ end: DetectEngineThreadCtxDeinit(&th_v, (void *)det_ctx); } if (de_ctx != NULL) { - SigGroupCleanup(de_ctx); DetectEngineCtxFree(de_ctx); } @@ -995,7 +969,6 @@ end: DetectEngineThreadCtxDeinit(&th_v, (void *)det_ctx); } if (de_ctx != NULL) { - SigGroupCleanup(de_ctx); DetectEngineCtxFree(de_ctx); } @@ -1126,7 +1099,6 @@ end: DetectEngineThreadCtxDeinit(&th_v, (void *)det_ctx); } if (de_ctx != NULL) { - SigGroupCleanup(de_ctx); DetectEngineCtxFree(de_ctx); } @@ -1265,7 +1237,6 @@ end: DetectEngineThreadCtxDeinit(&th_v, (void *)det_ctx); } if (de_ctx != NULL) { - SigGroupCleanup(de_ctx); DetectEngineCtxFree(de_ctx); }