mirror of https://github.com/OISF/suricata
detect/krb5: move krb5_msg_type to rust
Makes it a generic u32 on the way Unit tests are covered by SV tests Ticket: 6723pull/13892/head
Philippe Antoine
1 year ago
committed by
Victor Julien
parent
5a4d280461
commit
0553dfa814
@ -1,243 +0,0 @@
|
||||
/* Copyright (C) 2018-2020 Open Information Security Foundation
|
||||
*
|
||||
* You can copy, redistribute or modify this Program under the terms of
|
||||
* the GNU General Public License version 2 as published by the Free
|
||||
* Software Foundation.
|
||||
*
|
||||
* This program is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU General Public License
|
||||
* version 2 along with this program; if not, write to the Free Software
|
||||
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
|
||||
* 02110-1301, USA.
|
||||
*/
|
||||
|
||||
/**
|
||||
* \file
|
||||
*
|
||||
* \author Pierre Chifflier <chifflier@wzdftpd.net>
|
||||
*/
|
||||
|
||||
#include "suricata-common.h"
|
||||
#include "util-unittest.h"
|
||||
#include "util-byte.h"
|
||||
|
||||
#include "detect-parse.h"
|
||||
#include "detect-engine.h"
|
||||
|
||||
#include "detect-krb5-msgtype.h"
|
||||
|
||||
#include "rust.h"
|
||||
|
||||
/**
|
||||
* \brief Regex for parsing our keyword options
|
||||
*/
|
||||
#define PARSE_REGEX "^\\s*([A-z0-9\\.]+|\"[A-z0-9_\\.]+\")\\s*$"
|
||||
static DetectParseRegex parse_regex;
|
||||
|
||||
/* Prototypes of functions registered in DetectKrb5MsgTypeRegister below */
|
||||
static int DetectKrb5MsgTypeMatch (DetectEngineThreadCtx *, Flow *,
|
||||
uint8_t, void *, void *, const Signature *,
|
||||
const SigMatchCtx *);
|
||||
static int DetectKrb5MsgTypeSetup (DetectEngineCtx *, Signature *, const char *);
|
||||
static void DetectKrb5MsgTypeFree (DetectEngineCtx *, void *);
|
||||
#ifdef UNITTESTS
|
||||
static void DetectKrb5MsgTypeRegisterTests (void);
|
||||
#endif
|
||||
|
||||
static int g_krb5_msg_type_list_id = 0;
|
||||
|
||||
/**
|
||||
* \brief Registration function for krb5_msg_type: keyword
|
||||
*
|
||||
* This function is called once in the 'lifetime' of the engine.
|
||||
*/
|
||||
void DetectKrb5MsgTypeRegister(void)
|
||||
{
|
||||
sigmatch_table[DETECT_KRB5_MSGTYPE].name = "krb5_msg_type";
|
||||
sigmatch_table[DETECT_KRB5_MSGTYPE].desc = "match Kerberos 5 message type";
|
||||
sigmatch_table[DETECT_KRB5_MSGTYPE].url = "/rules/kerberos-keywords.html#krb5-msg-type";
|
||||
sigmatch_table[DETECT_KRB5_MSGTYPE].Match = NULL;
|
||||
sigmatch_table[DETECT_KRB5_MSGTYPE].AppLayerTxMatch = DetectKrb5MsgTypeMatch;
|
||||
sigmatch_table[DETECT_KRB5_MSGTYPE].Setup = DetectKrb5MsgTypeSetup;
|
||||
sigmatch_table[DETECT_KRB5_MSGTYPE].Free = DetectKrb5MsgTypeFree;
|
||||
#ifdef UNITTESTS
|
||||
sigmatch_table[DETECT_KRB5_MSGTYPE].RegisterTests = DetectKrb5MsgTypeRegisterTests;
|
||||
#endif
|
||||
|
||||
DetectAppLayerInspectEngineRegister("krb5_msg_type", ALPROTO_KRB5, SIG_FLAG_TOSERVER, 0,
|
||||
DetectEngineInspectGenericList, NULL);
|
||||
|
||||
DetectAppLayerInspectEngineRegister("krb5_msg_type", ALPROTO_KRB5, SIG_FLAG_TOCLIENT, 0,
|
||||
DetectEngineInspectGenericList, NULL);
|
||||
|
||||
/* set up the PCRE for keyword parsing */
|
||||
DetectSetupParseRegexes(PARSE_REGEX, &parse_regex);
|
||||
|
||||
g_krb5_msg_type_list_id = DetectBufferTypeRegister("krb5_msg_type");
|
||||
SCLogDebug("g_krb5_msg_type_list_id %d", g_krb5_msg_type_list_id);
|
||||
}
|
||||
|
||||
/**
|
||||
* \brief This function is used to match KRB5 rule option on a packet
|
||||
*
|
||||
* \param t pointer to thread vars
|
||||
* \param det_ctx pointer to the pattern matcher thread
|
||||
* \param p pointer to the current packet
|
||||
* \param m pointer to the sigmatch with context that we will cast into DetectKrb5Data
|
||||
*
|
||||
* \retval 0 no match
|
||||
* \retval 1 match
|
||||
*/
|
||||
static int DetectKrb5MsgTypeMatch (DetectEngineThreadCtx *det_ctx,
|
||||
Flow *f, uint8_t flags, void *state,
|
||||
void *txv, const Signature *s,
|
||||
const SigMatchCtx *ctx)
|
||||
{
|
||||
uint32_t msg_type;
|
||||
const DetectKrb5MsgTypeData *dd = (const DetectKrb5MsgTypeData *)ctx;
|
||||
|
||||
SCEnter();
|
||||
|
||||
SCKrb5TxGetMsgType(txv, &msg_type);
|
||||
|
||||
if (dd->msg_type == msg_type)
|
||||
SCReturnInt(1);
|
||||
|
||||
SCReturnInt(0);
|
||||
}
|
||||
|
||||
/**
|
||||
* \brief This function is used to parse options passed via krb5_msgtype: keyword
|
||||
*
|
||||
* \param krb5str Pointer to the user provided krb5_msg_type options
|
||||
*
|
||||
* \retval krb5d pointer to DetectKrb5Data on success
|
||||
* \retval NULL on failure
|
||||
*/
|
||||
static DetectKrb5MsgTypeData *DetectKrb5MsgTypeParse (const char *krb5str)
|
||||
{
|
||||
DetectKrb5MsgTypeData *krb5d = NULL;
|
||||
char arg1[4] = "";
|
||||
int res = 0;
|
||||
size_t pcre2len;
|
||||
|
||||
pcre2_match_data *match = NULL;
|
||||
int ret = DetectParsePcreExec(&parse_regex, &match, krb5str, 0, 0);
|
||||
if (ret != 2) {
|
||||
SCLogError("parse error, ret %" PRId32 "", ret);
|
||||
goto error;
|
||||
}
|
||||
|
||||
pcre2len = sizeof(arg1);
|
||||
res = pcre2_substring_copy_bynumber(match, 1, (PCRE2_UCHAR8 *)arg1, &pcre2len);
|
||||
if (res < 0) {
|
||||
SCLogError("pcre2_substring_copy_bynumber failed");
|
||||
goto error;
|
||||
}
|
||||
|
||||
krb5d = SCMalloc(sizeof (DetectKrb5MsgTypeData));
|
||||
if (unlikely(krb5d == NULL))
|
||||
goto error;
|
||||
if (StringParseUint8(&krb5d->msg_type, 10, 0,
|
||||
(const char *)arg1) < 0) {
|
||||
goto error;
|
||||
}
|
||||
pcre2_match_data_free(match);
|
||||
return krb5d;
|
||||
|
||||
error:
|
||||
if (match) {
|
||||
pcre2_match_data_free(match);
|
||||
}
|
||||
if (krb5d)
|
||||
SCFree(krb5d);
|
||||
return NULL;
|
||||
}
|
||||
|
||||
/**
|
||||
* \brief parse the options from the 'krb5_msg_type' keyword in the rule into
|
||||
* the Signature data structure.
|
||||
*
|
||||
* \param de_ctx pointer to the Detection Engine Context
|
||||
* \param s pointer to the Current Signature
|
||||
* \param krb5str pointer to the user provided options
|
||||
*
|
||||
* \retval 0 on Success
|
||||
* \retval -1 on Failure
|
||||
*/
|
||||
static int DetectKrb5MsgTypeSetup (DetectEngineCtx *de_ctx, Signature *s, const char *krb5str)
|
||||
{
|
||||
DetectKrb5MsgTypeData *krb5d = NULL;
|
||||
|
||||
if (SCDetectSignatureSetAppProto(s, ALPROTO_KRB5) != 0)
|
||||
return -1;
|
||||
|
||||
krb5d = DetectKrb5MsgTypeParse(krb5str);
|
||||
if (krb5d == NULL)
|
||||
goto error;
|
||||
|
||||
if (SCSigMatchAppendSMToList(de_ctx, s, DETECT_KRB5_MSGTYPE, (SigMatchCtx *)krb5d,
|
||||
g_krb5_msg_type_list_id) == NULL) {
|
||||
goto error;
|
||||
}
|
||||
|
||||
return 0;
|
||||
|
||||
error:
|
||||
if (krb5d != NULL)
|
||||
DetectKrb5MsgTypeFree(de_ctx, krb5d);
|
||||
return -1;
|
||||
}
|
||||
|
||||
/**
|
||||
* \brief this function will free memory associated with DetectKrb5Data
|
||||
*
|
||||
* \param ptr pointer to DetectKrb5Data
|
||||
*/
|
||||
static void DetectKrb5MsgTypeFree(DetectEngineCtx *de_ctx, void *ptr) {
|
||||
DetectKrb5MsgTypeData *krb5d = (DetectKrb5MsgTypeData *)ptr;
|
||||
|
||||
SCFree(krb5d);
|
||||
}
|
||||
|
||||
#ifdef UNITTESTS
|
||||
|
||||
/**
|
||||
* \test description of the test
|
||||
*/
|
||||
|
||||
static int DetectKrb5MsgTypeParseTest01 (void)
|
||||
{
|
||||
DetectKrb5MsgTypeData *krb5d = DetectKrb5MsgTypeParse("10");
|
||||
FAIL_IF_NULL(krb5d);
|
||||
FAIL_IF(!(krb5d->msg_type == 10));
|
||||
DetectKrb5MsgTypeFree(NULL, krb5d);
|
||||
PASS;
|
||||
}
|
||||
|
||||
static int DetectKrb5MsgTypeSignatureTest01 (void)
|
||||
{
|
||||
DetectEngineCtx *de_ctx = DetectEngineCtxInit();
|
||||
FAIL_IF_NULL(de_ctx);
|
||||
|
||||
Signature *sig = DetectEngineAppendSig(de_ctx, "alert krb5 any any -> any any (krb5_msg_type:10; sid:1; rev:1;)");
|
||||
FAIL_IF_NULL(sig);
|
||||
|
||||
DetectEngineCtxFree(de_ctx);
|
||||
PASS;
|
||||
}
|
||||
|
||||
/**
|
||||
* \brief this function registers unit tests for DetectKrb5MsgType
|
||||
*/
|
||||
static void DetectKrb5MsgTypeRegisterTests(void)
|
||||
{
|
||||
UtRegisterTest("DetectKrb5MsgTypeParseTest01", DetectKrb5MsgTypeParseTest01);
|
||||
UtRegisterTest("DetectKrb5MsgTypeSignatureTest01",
|
||||
DetectKrb5MsgTypeSignatureTest01);
|
||||
}
|
||||
#endif /* UNITTESTS */
|
||||
@ -1,33 +0,0 @@
|
||||
/* Copyright (C) 2015-2017 Open Information Security Foundation
|
||||
*
|
||||
* You can copy, redistribute or modify this Program under the terms of
|
||||
* the GNU General Public License version 2 as published by the Free
|
||||
* Software Foundation.
|
||||
*
|
||||
* This program is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU General Public License
|
||||
* version 2 along with this program; if not, write to the Free Software
|
||||
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
|
||||
* 02110-1301, USA.
|
||||
*/
|
||||
|
||||
/**
|
||||
* \file
|
||||
*
|
||||
* \author Pierre Chifflier <chifflier@wzdftpd.net>
|
||||
*/
|
||||
|
||||
#ifndef SURICATA_DETECT_KRB5_MSGTYPE_H
|
||||
#define SURICATA_DETECT_KRB5_MSGTYPE_H
|
||||
|
||||
typedef struct DetectKrb5MsgTypeData_ {
|
||||
uint8_t msg_type;
|
||||
} DetectKrb5MsgTypeData;
|
||||
|
||||
void DetectKrb5MsgTypeRegister(void);
|
||||
|
||||
#endif /* SURICATA_DETECT_KRB5_MSGTYPE_H */
|
||||
Loading…
Reference in New Issue