ndpi: flow storage can fail, cleanup if it does

3 months ago · 038d4a21e3
parent f739a8a73c
commit 038d4a21e3
1 changed files with 4 additions and 1 deletions
--- a/plugins/ndpi/ndpi.c
+++ b/plugins/ndpi/ndpi.c
@ -121,7 +121,10 @@ static void OnFlowInit(ThreadVars *tv, Flow *f, const Packet *p, void *_data)

    memset(flowctx->ndpi_flow, 0, SIZEOF_FLOW_STRUCT);
    flowctx->detection_completed = false;
-    SCFlowSetStorageById(f, flow_storage_id, flowctx);
+    if (SCFlowSetStorageById(f, flow_storage_id, flowctx) != 0) {
+        SCLogDebug("Failed to set nDPI flow storage");
+        FlowStorageFree(flowctx);
+    }
 }

 static void OnFlowUpdate(ThreadVars *tv, Flow *f, Packet *p, void *_data)