You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
suricata/src/detect-ack.c

298 lines
7.6 KiB
C

/* Copyright (C) 2007-2010 Open Information Security Foundation
*
* You can copy, redistribute or modify this Program under the terms of
* the GNU General Public License version 2 as published by the Free
* Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* version 2 along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
* 02110-1301, USA.
*/
16 years ago
/**
* \file
*
16 years ago
* \author Brian Rectanus <brectanu@gmail.com>
*
* Implements the "ack" keyword.
*/
#include "suricata-common.h"
16 years ago
#include "debug.h"
#include "decode.h"
#include "detect.h"
#include "detect-parse.h"
#include "detect-engine.h"
#include "detect-engine-mpm.h"
#include "detect-ack.h"
#include "util-byte.h"
#include "util-unittest.h"
#include "util-unittest-helper.h"
#include "util-debug.h"
16 years ago
/* prototypes */
static int DetectAckSetup(DetectEngineCtx *, Signature *, char *);
static int DetectAckMatch(ThreadVars *, DetectEngineThreadCtx *,
Packet *, Signature *, SigMatch *);
16 years ago
static void DetectAckRegisterTests(void);
static void DetectAckFree(void *);
16 years ago
void DetectAckRegister(void) {
sigmatch_table[DETECT_ACK].name = "ack";
sigmatch_table[DETECT_ACK].Match = DetectAckMatch;
sigmatch_table[DETECT_ACK].Setup = DetectAckSetup;
sigmatch_table[DETECT_ACK].Free = DetectAckFree;
sigmatch_table[DETECT_ACK].RegisterTests = DetectAckRegisterTests;
}
/**
* \internal
* \brief This function is used to match packets with a given Ack number
*
* \param t pointer to thread vars
* \param det_ctx pointer to the pattern matcher thread
* \param p pointer to the current packet
* \param m pointer to the sigmatch that we will cast into DetectAckData
*
* \retval 0 no match
* \retval 1 match
*/
static int DetectAckMatch(ThreadVars *t, DetectEngineThreadCtx *det_ctx,
Packet *p, Signature *s, SigMatch *m)
{
DetectAckData *data = (DetectAckData *)m->ctx;
16 years ago
/* This is only needed on TCP packets */
if (!(PKT_IS_TCP(p)) || PKT_IS_PSEUDOPKT(p)) {
16 years ago
return 0;
}
return (data->ack == TCP_GET_ACK(p)) ? 1 : 0;
16 years ago
}
/**
* \internal
* \brief this function is used to add the ack option into the signature
*
* \param de_ctx pointer to the Detection Engine Context
* \param s pointer to the Current Signature
* \param m pointer to the Current SigMatch
* \param optstr pointer to the user provided options
*
* \retval 0 on Success
* \retval -1 on Failure
*/
static int DetectAckSetup(DetectEngineCtx *de_ctx, Signature *s, char *optstr)
16 years ago
{
Memory leak cleanup in detectors Hello, I ran the code through an analysis program and found several leaks that should be cleaned up. *In src/detect-engine-address-ipv4.c at line 472, the test for ag == NULL will never be true since that is the loop entry test. *In src/detect-engine-port.c at line 1133, the test for p == NULL will never be true since that is the loop entry test. *In src/detect-engine-mpm.c at line 263 is a return without freeing fast_pattern *In src/detect-ack.c at line 80 and 85, data catches the return from malloc. One of them should be deleted. *In src/detect-seq.c at line 81 and 86, data catches the return from malloc. One of them should be deleted. *In src/detect-content.c at line 749, many of the paths that lead to the error exit still has temp pointing to allocated memory. To clean this up, temp should be set to NULL if not immediately assigning and new value. *In src/detect-uricontent.c at line 319, both cd and str needto be freed. At lines 344, str needs to be freed. And at line 347 str and temp need to be freed. *In src/detect-flowbits.c at line 231 and 235, str was not being freed. cd was not being freed at line 235. *In src/detect-flowvar.c at line 127, str was not being freed. At line 194, cd and str were not being freed. *In src/detect-flowint.c at line 277, sfd was not being freed. At line 315, str was not being freed. *In src/detect-pktvar.c at line 121, str was not being freed. At line 188, str and cd was not being freed. *In src/detect-pcre.c at line 389, there is an extra free of "re" that should be deleted. *In src/detect-depth.c at line 42 & 48, str has not been freed. *In src/detect-distance.c at line 49 and 55, str has not been freed *In src/detect-offset.c at line 45, str has not been freed. The patch below fixes these issues. -Steve
16 years ago
DetectAckData *data;
16 years ago
SigMatch *sm = NULL;
data = SCMalloc(sizeof(DetectAckData));
if (unlikely(data == NULL))
16 years ago
goto error;
sm = SigMatchAlloc();
if (sm == NULL) {
goto error;
}
sm->type = DETECT_ACK;
if (-1 == ByteExtractStringUint32(&data->ack, 10, 0, optstr)) {
16 years ago
goto error;
}
sm->ctx = data;
16 years ago
SigMatchAppendSMToList(s, sm, DETECT_SM_LIST_MATCH);
s->flags |= SIG_FLAG_REQUIRE_PACKET;
16 years ago
return 0;
error:
if (data) SCFree(data);
16 years ago
return -1;
}
/**
* \internal
* \brief this function will free memory associated with ack option
*
* \param data pointer to ack configuration data
*/
static void DetectAckFree(void *ptr)
{
DetectAckData *data = (DetectAckData *)ptr;
SCFree(data);
16 years ago
}
#ifdef UNITTESTS
/**
* \internal
* \brief This test tests sameip success and failure.
*/
static int DetectAckSigTest01Real(int mpm_type)
{
Packet *p1 = NULL;
Packet *p2 = NULL;
Packet *p3 = NULL;
16 years ago
ThreadVars th_v;
DetectEngineThreadCtx *det_ctx;
int result = 0;
memset(&th_v, 0, sizeof(th_v));
/* TCP w/ack=42 */
p1 = UTHBuildPacket(NULL, 0, IPPROTO_TCP);
p1->tcph->th_ack = htonl(42);
16 years ago
/* TCP w/ack=100 */
p2 = UTHBuildPacket(NULL, 0, IPPROTO_TCP);
p2->tcph->th_ack = htonl(100);
16 years ago
/* ICMP */
p3 = UTHBuildPacket(NULL, 0, IPPROTO_ICMP);
16 years ago
DetectEngineCtx *de_ctx = DetectEngineCtxInit();
if (de_ctx == NULL) {
goto end;
}
de_ctx->mpm_matcher = mpm_type;
16 years ago
de_ctx->flags |= DE_QUIET;
/* These three are crammed in here as there is no Parse */
if (SigInit(de_ctx,
"alert tcp any any -> any any "
"(msg:\"Testing ack\";ack:foo;sid:1;)") != NULL)
{
printf("invalid ack accepted: ");
goto cleanup_engine;
16 years ago
}
if (SigInit(de_ctx,
"alert tcp any any -> any any "
"(msg:\"Testing ack\";ack:9999999999;sid:1;)") != NULL)
{
printf("overflowing ack accepted: ");
goto cleanup_engine;
16 years ago
}
if (SigInit(de_ctx,
"alert tcp any any -> any any "
"(msg:\"Testing ack\";ack:-100;sid:1;)") != NULL)
{
printf("negative ack accepted: ");
goto cleanup_engine;
16 years ago
}
de_ctx->sig_list = SigInit(de_ctx,
"alert tcp any any -> any any "
"(msg:\"Testing ack\";ack:41;sid:1;)");
16 years ago
if (de_ctx->sig_list == NULL) {
goto cleanup_engine;
16 years ago
}
de_ctx->sig_list->next = SigInit(de_ctx,
"alert tcp any any -> any any "
"(msg:\"Testing ack\";ack:42;sid:2;)");
if (de_ctx->sig_list->next == NULL) {
goto cleanup_engine;
16 years ago
}
SigGroupBuild(de_ctx);
DetectEngineThreadCtxInit(&th_v, (void *)de_ctx, (void *)&det_ctx);
SigMatchSignatures(&th_v, de_ctx, det_ctx, p1);
if (PacketAlertCheck(p1, 1) != 0) {
16 years ago
printf("sid 1 alerted, but should not have: ");
goto cleanup;
}
if (PacketAlertCheck(p1, 2) == 0) {
16 years ago
printf("sid 2 did not alert, but should have: ");
goto cleanup;
}
SigMatchSignatures(&th_v, de_ctx, det_ctx, p2);
if (PacketAlertCheck(p2, 1) != 0) {
16 years ago
printf("sid 1 alerted, but should not have: ");
goto cleanup;
}
if (PacketAlertCheck(p2, 2) != 0) {
16 years ago
printf("sid 2 alerted, but should not have: ");
goto cleanup;
}
SigMatchSignatures(&th_v, de_ctx, det_ctx, p3);
if (PacketAlertCheck(p3, 1) != 0) {
16 years ago
printf("sid 1 alerted, but should not have: ");
goto cleanup;
}
if (PacketAlertCheck(p3, 2) != 0) {
16 years ago
printf("sid 2 alerted, but should not have: ");
goto cleanup;
}
result = 1;
cleanup:
SigGroupCleanup(de_ctx);
SigCleanSignatures(de_ctx);
DetectEngineThreadCtxDeinit(&th_v, (void *)det_ctx);
cleanup_engine:
16 years ago
DetectEngineCtxFree(de_ctx);
end:
return result;
}
/**
* \test DetectAckSigTest01B2g tests sameip under B2g MPM
*/
static int DetectAckSigTest01B2g(void)
{
return DetectAckSigTest01Real(MPM_B2G);
}
/**
* \test DetectAckSigTest01B2g tests sameip under B3g MPM
*/
static int DetectAckSigTest01B3g(void)
{
return DetectAckSigTest01Real(MPM_B3G);
}
/**
* \test DetectAckSigTest01B2g tests sameip under WuManber MPM
*/
static int DetectAckSigTest01Wm(void)
{
return DetectAckSigTest01Real(MPM_WUMANBER);
}
#endif /* UNITTESTS */
/**
* \internal
* \brief This function registers unit tests for DetectAck
*/
static void DetectAckRegisterTests(void)
{
#ifdef UNITTESTS
UtRegisterTest("DetectAckSigTest01B2g", DetectAckSigTest01B2g, 1);
UtRegisterTest("DetectAckSigTest01B3g", DetectAckSigTest01B3g, 1);
UtRegisterTest("DetectAckSigTest01Wm", DetectAckSigTest01Wm, 1);
#endif /* UNITTESTS */
}