You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
suricata/src/detect-flowvar.c

360 lines
10 KiB
C

/* Copyright (C) 2007-2020 Open Information Security Foundation
*
* You can copy, redistribute or modify this Program under the terms of
* the GNU General Public License version 2 as published by the Free
* Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* version 2 along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
* 02110-1301, USA.
*/
/**
* \file
*
* \author Victor Julien <victor@inliniac.net>
*
* Simple flowvar content match part of the detection engine.
*/
#include "suricata-common.h"
#include "decode.h"
#include "detect.h"
#include "detect-parse.h"
#include "detect-content.h"
#include "threads.h"
#include "flow.h"
#include "flow-var.h"
#include "pkt-var.h"
#include "detect-flowvar.h"
#include "util-spm.h"
#include "util-var-name.h"
#include "util-debug.h"
#include "util-print.h"
#define PARSE_REGEX "(.*),(.*)"
static DetectParseRegex parse_regex;
int DetectFlowvarMatch (DetectEngineThreadCtx *, Packet *,
const Signature *, const SigMatchCtx *);
static int DetectFlowvarSetup (DetectEngineCtx *, Signature *, const char *);
static int DetectFlowvarPostMatch(DetectEngineThreadCtx *det_ctx,
Packet *p, const Signature *s, const SigMatchCtx *ctx);
static void DetectFlowvarDataFree(DetectEngineCtx *, void *ptr);
void DetectFlowvarRegister (void)
{
sigmatch_table[DETECT_FLOWVAR].name = "flowvar";
sigmatch_table[DETECT_FLOWVAR].Match = DetectFlowvarMatch;
sigmatch_table[DETECT_FLOWVAR].Setup = DetectFlowvarSetup;
sigmatch_table[DETECT_FLOWVAR].Free = DetectFlowvarDataFree;
/* post-match for flowvar storage */
sigmatch_table[DETECT_FLOWVAR_POSTMATCH].name = "__flowvar__postmatch__";
sigmatch_table[DETECT_FLOWVAR_POSTMATCH].Match = DetectFlowvarPostMatch;
sigmatch_table[DETECT_FLOWVAR_POSTMATCH].Setup = NULL;
sigmatch_table[DETECT_FLOWVAR_POSTMATCH].Free = DetectFlowvarDataFree;
DetectSetupParseRegexes(PARSE_REGEX, &parse_regex);
}
/**
* \brief this function will SCFree memory associated with DetectFlowvarData
*
2 years ago
* \param cd pointer to DetectContentData
*/
static void DetectFlowvarDataFree(DetectEngineCtx *de_ctx, void *ptr)
{
if (ptr == NULL)
SCReturn;
DetectFlowvarData *fd = (DetectFlowvarData *)ptr;
var-names: reimplement var name handling Implement a new design for handling var name id's. The old logic was aware of detection engine versions and generally didn't work well for multi-tenancy cases. Other than memory leaks and crashes, logging of var names worked or failed based on which tenant was loaded last. This patch implements a new approach, where there is a global store of vars and their id's for the lifetime of the program. Overall Design: Base Store: "base" Used during keyword registration. Operates under lock. Base is shared between all detect engines, detect engine versions and tenants. Each variable name is ref counted. During the freeing of a detect engine / tenant, unregistration decreases the ref cnt. Base has both a string to id and a id to string hash table. String to id is used during parsing/registration. id to string during unregistration. Active Store Pointer (atomic) The "active" store atomic pointer points to the active lookup store. The call to `VarNameStoreActivate` will build a new lookup store and hot swap the pointer. Ensuring memory safety. During the hot swap, the pointer is replaced, so any new call to the lookup functions will automatically use the new store. This leaves the case of any lookup happening concurrently with the pointer swap. For this case we add the old store to a free list. It gets a timestamp before which it cannot be freed. Free List The free list contains old stores that are waiting to get removed. They contain a timestamp that is checked before they are freed. Bug: #6044. Bug: #6201.
2 years ago
/* leave unregistration to pcre keyword */
if (!fd->post_match)
VarNameStoreUnregister(fd->idx, VAR_TYPE_FLOW_VAR);
if (fd->name)
SCFree(fd->name);
if (fd->content)
SCFree(fd->content);
SCFree(fd);
}
/*
* returns 0: no match
* 1: match
* -1: error
*/
int DetectFlowvarMatch (DetectEngineThreadCtx *det_ctx, Packet *p,
const Signature *s, const SigMatchCtx *ctx)
{
int ret = 0;
DetectFlowvarData *fd = (DetectFlowvarData *)ctx;
FlowVar *fv = FlowVarGet(p->flow, fd->idx);
if (fv != NULL) {
uint8_t *ptr = SpmSearch(fv->data.fv_str.value,
fv->data.fv_str.value_len,
fd->content, fd->content_len);
if (ptr != NULL)
ret = 1;
}
return ret;
}
static int DetectFlowvarSetup (DetectEngineCtx *de_ctx, Signature *s, const char *rawstr)
{
DetectFlowvarData *fd = NULL;
char varname[64], varcontent[64];
int res = 0;
size_t pcre2len;
uint8_t *content = NULL;
uint16_t contentlen = 0;
uint32_t contentflags = s->init_data->negated ? DETECT_CONTENT_NEGATED : 0;
pcre2_match_data *match = NULL;
int ret = DetectParsePcreExec(&parse_regex, &match, rawstr, 0, 0);
if (ret != 3) {
SCLogError("\"%s\" is not a valid setting for flowvar.", rawstr);
if (match) {
pcre2_match_data_free(match);
}
return -1;
}
pcre2len = sizeof(varname);
res = pcre2_substring_copy_bynumber(match, 1, (PCRE2_UCHAR8 *)varname, &pcre2len);
if (res < 0) {
pcre2_match_data_free(match);
SCLogError("pcre2_substring_copy_bynumber failed");
return -1;
}
pcre2len = sizeof(varcontent);
res = pcre2_substring_copy_bynumber(match, 2, (PCRE2_UCHAR8 *)varcontent, &pcre2len);
pcre2_match_data_free(match);
if (res < 0) {
SCLogError("pcre2_substring_copy_bynumber failed");
return -1;
Memory leak cleanup in detectors Hello, I ran the code through an analysis program and found several leaks that should be cleaned up. *In src/detect-engine-address-ipv4.c at line 472, the test for ag == NULL will never be true since that is the loop entry test. *In src/detect-engine-port.c at line 1133, the test for p == NULL will never be true since that is the loop entry test. *In src/detect-engine-mpm.c at line 263 is a return without freeing fast_pattern *In src/detect-ack.c at line 80 and 85, data catches the return from malloc. One of them should be deleted. *In src/detect-seq.c at line 81 and 86, data catches the return from malloc. One of them should be deleted. *In src/detect-content.c at line 749, many of the paths that lead to the error exit still has temp pointing to allocated memory. To clean this up, temp should be set to NULL if not immediately assigning and new value. *In src/detect-uricontent.c at line 319, both cd and str needto be freed. At lines 344, str needs to be freed. And at line 347 str and temp need to be freed. *In src/detect-flowbits.c at line 231 and 235, str was not being freed. cd was not being freed at line 235. *In src/detect-flowvar.c at line 127, str was not being freed. At line 194, cd and str were not being freed. *In src/detect-flowint.c at line 277, sfd was not being freed. At line 315, str was not being freed. *In src/detect-pktvar.c at line 121, str was not being freed. At line 188, str and cd was not being freed. *In src/detect-pcre.c at line 389, there is an extra free of "re" that should be deleted. *In src/detect-depth.c at line 42 & 48, str has not been freed. *In src/detect-distance.c at line 49 and 55, str has not been freed *In src/detect-offset.c at line 45, str has not been freed. The patch below fixes these issues. -Steve
16 years ago
}
int varcontent_index = 0;
if (strlen(varcontent) >= 2) {
if (varcontent[0] == '"')
varcontent_index++;
if (varcontent[strlen(varcontent)-1] == '"')
varcontent[strlen(varcontent)-1] = '\0';
}
SCLogDebug("varcontent %s", &varcontent[varcontent_index]);
res = DetectContentDataParse("flowvar", &varcontent[varcontent_index], &content, &contentlen);
if (res == -1)
goto error;
fd = SCCalloc(1, sizeof(DetectFlowvarData));
if (unlikely(fd == NULL))
goto error;
fd->content = SCMalloc(contentlen);
if (unlikely(fd->content == NULL))
goto error;
memcpy(fd->content, content, contentlen);
fd->content_len = contentlen;
fd->flags = contentflags;
fd->name = SCStrdup(varname);
if (unlikely(fd->name == NULL))
goto error;
var-names: reimplement var name handling Implement a new design for handling var name id's. The old logic was aware of detection engine versions and generally didn't work well for multi-tenancy cases. Other than memory leaks and crashes, logging of var names worked or failed based on which tenant was loaded last. This patch implements a new approach, where there is a global store of vars and their id's for the lifetime of the program. Overall Design: Base Store: "base" Used during keyword registration. Operates under lock. Base is shared between all detect engines, detect engine versions and tenants. Each variable name is ref counted. During the freeing of a detect engine / tenant, unregistration decreases the ref cnt. Base has both a string to id and a id to string hash table. String to id is used during parsing/registration. id to string during unregistration. Active Store Pointer (atomic) The "active" store atomic pointer points to the active lookup store. The call to `VarNameStoreActivate` will build a new lookup store and hot swap the pointer. Ensuring memory safety. During the hot swap, the pointer is replaced, so any new call to the lookup functions will automatically use the new store. This leaves the case of any lookup happening concurrently with the pointer swap. For this case we add the old store to a free list. It gets a timestamp before which it cannot be freed. Free List The free list contains old stores that are waiting to get removed. They contain a timestamp that is checked before they are freed. Bug: #6044. Bug: #6201.
2 years ago
fd->idx = VarNameStoreRegister(varname, VAR_TYPE_FLOW_VAR);
/* Okay so far so good, lets get this into a SigMatch
* and put it in the Signature. */
if (SigMatchAppendSMToList(
de_ctx, s, DETECT_FLOWVAR, (SigMatchCtx *)fd, DETECT_SM_LIST_MATCH) == NULL) {
goto error;
}
SCFree(content);
return 0;
error:
if (fd != NULL)
DetectFlowvarDataFree(de_ctx, fd);
if (content != NULL)
SCFree(content);
return -1;
}
/** \brief Store flowvar in det_ctx so we can exec it post-match */
int DetectVarStoreMatchKeyValue(DetectEngineThreadCtx *det_ctx, uint8_t *key, uint16_t key_len,
uint8_t *buffer, uint16_t len, uint16_t type)
{
DetectVarList *fs = SCCalloc(1, sizeof(*fs));
if (unlikely(fs == NULL))
return -1;
fs->len = len;
fs->type = type;
fs->buffer = buffer;
fs->key = key;
fs->key_len = key_len;
fs->next = det_ctx->varlist;
det_ctx->varlist = fs;
return 0;
}
/** \brief Store flowvar in det_ctx so we can exec it post-match */
int DetectVarStoreMatch(
DetectEngineThreadCtx *det_ctx, uint32_t idx, uint8_t *buffer, uint16_t len, uint16_t type)
{
DetectVarList *fs = det_ctx->varlist;
/* first check if we have had a previous match for this idx */
for ( ; fs != NULL; fs = fs->next) {
if (fs->idx == idx) {
/* we're replacing the older store */
SCFree(fs->buffer);
fs->buffer = NULL;
break;
}
}
if (fs == NULL) {
fs = SCCalloc(1, sizeof(*fs));
if (unlikely(fs == NULL))
return -1;
fs->idx = idx;
fs->next = det_ctx->varlist;
det_ctx->varlist = fs;
}
fs->len = len;
fs->type = type;
fs->buffer = buffer;
return 0;
}
/** \brief Setup a post-match for flowvar storage
* We're piggyback riding the DetectFlowvarData struct
*/
int DetectFlowvarPostMatchSetup(DetectEngineCtx *de_ctx, Signature *s, uint32_t idx)
{
DetectFlowvarData *fv = NULL;
fv = SCCalloc(1, sizeof(DetectFlowvarData));
if (unlikely(fv == NULL))
goto error;
/* we only need the idx */
fv->idx = idx;
var-names: reimplement var name handling Implement a new design for handling var name id's. The old logic was aware of detection engine versions and generally didn't work well for multi-tenancy cases. Other than memory leaks and crashes, logging of var names worked or failed based on which tenant was loaded last. This patch implements a new approach, where there is a global store of vars and their id's for the lifetime of the program. Overall Design: Base Store: "base" Used during keyword registration. Operates under lock. Base is shared between all detect engines, detect engine versions and tenants. Each variable name is ref counted. During the freeing of a detect engine / tenant, unregistration decreases the ref cnt. Base has both a string to id and a id to string hash table. String to id is used during parsing/registration. id to string during unregistration. Active Store Pointer (atomic) The "active" store atomic pointer points to the active lookup store. The call to `VarNameStoreActivate` will build a new lookup store and hot swap the pointer. Ensuring memory safety. During the hot swap, the pointer is replaced, so any new call to the lookup functions will automatically use the new store. This leaves the case of any lookup happening concurrently with the pointer swap. For this case we add the old store to a free list. It gets a timestamp before which it cannot be freed. Free List The free list contains old stores that are waiting to get removed. They contain a timestamp that is checked before they are freed. Bug: #6044. Bug: #6201.
2 years ago
fv->post_match = true;
if (SigMatchAppendSMToList(de_ctx, s, DETECT_FLOWVAR_POSTMATCH, (SigMatchCtx *)fv,
DETECT_SM_LIST_POSTMATCH) == NULL) {
goto error;
}
return 0;
error:
if (fv != NULL)
DetectFlowvarDataFree(de_ctx, fv);
return -1;
}
/** \internal
* \brief post-match func to store flowvars in the flow
* \param sm sigmatch containing the idx to store
* \retval 1 or -1 in case of error
*/
static int DetectFlowvarPostMatch(
DetectEngineThreadCtx *det_ctx,
Packet *p, const Signature *s, const SigMatchCtx *ctx)
{
DetectVarList *fs, *prev;
const DetectFlowvarData *fd;
if (det_ctx->varlist == NULL)
return 1;
fd = (const DetectFlowvarData *)ctx;
prev = NULL;
fs = det_ctx->varlist;
while (fs != NULL) {
if (fd->idx == 0 || fd->idx == fs->idx) {
SCLogDebug("adding to the flow %u:", fs->idx);
//PrintRawDataFp(stdout, fs->buffer, fs->len);
if (fs->type == DETECT_VAR_TYPE_FLOW_POSTMATCH && p && p->flow) {
FlowVarAddIdValue(p->flow, fs->idx, fs->buffer, fs->len);
/* memory at fs->buffer is now the responsibility of
* the flowvar code. */
} else if (fs->type == DETECT_VAR_TYPE_PKT_POSTMATCH && fs->key && p) {
/* pkt key/value */
if (PktVarAddKeyValue(p, (uint8_t *)fs->key, fs->key_len,
(uint8_t *)fs->buffer, fs->len) == -1)
{
SCFree(fs->key);
SCFree(fs->buffer);
/* the rest of fs is freed below */
}
} else if (fs->type == DETECT_VAR_TYPE_PKT_POSTMATCH && p) {
if (PktVarAdd(p, fs->idx, fs->buffer, fs->len) == -1) {
SCFree(fs->buffer);
/* the rest of fs is freed below */
}
}
if (fs == det_ctx->varlist) {
det_ctx->varlist = fs->next;
SCFree(fs);
fs = det_ctx->varlist;
} else {
prev->next = fs->next;
SCFree(fs);
fs = prev->next;
}
} else {
prev = fs;
fs = fs->next;
}
}
return 1;
}
/** \brief Handle flowvar candidate list in det_ctx: clean up the list
*
* Only called from DetectVarProcessList() when varlist is not NULL.
*/
void DetectVarProcessListInternal(DetectVarList *fs, Flow *f, Packet *p)
{
DetectVarList *next;
do {
next = fs->next;
if (fs->key) {
SCFree(fs->key);
}
SCFree(fs->buffer);
SCFree(fs);
fs = next;
} while (fs != NULL);
}