pixelfed

You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

History

Ashley c0f50617f9 Use encodeURIComponent for DM external link redirect The DM external-link interstitial built /i/redirect?url= with encodeURI, which leaves reserved chars (& ? = #) unescaped. A shared url with a query string got truncated at the first ampersand on the server, dropping the rest and sometimes 404ing. encodeURIComponent escapes the value as a single query parameter, matching app.js and spa.js. Verified with vendor/bin/pest tests/Feature/Site/RedirectUrlEncodingTest.php (2 passed): a percent-encoded url survives intact to the redirect view, while a raw-ampersand url does not.	1 week ago
..
CommunityGuidelinesLayoutStaleTest.php	…
RedirectUrlEncodingTest.php	Use encodeURIComponent for DM external link redirect	1 week ago

Ashley c0f50617f9 Use encodeURIComponent for DM external link redirect

The DM external-link interstitial built /i/redirect?url= with encodeURI,
which leaves reserved chars (& ? = #) unescaped. A shared url with a query
string got truncated at the first ampersand on the server, dropping the rest
and sometimes 404ing. encodeURIComponent escapes the value as a single query
parameter, matching app.js and spa.js.

Verified with vendor/bin/pest tests/Feature/Site/RedirectUrlEncodingTest.php
(2 passed): a percent-encoded url survives intact to the redirect view, while
a raw-ampersand url does not.

CommunityGuidelinesLayoutStaleTest.php

…

RedirectUrlEncodingTest.php

Use encodeURIComponent for DM external link redirect