pixelfed

Commit Graph

Author	SHA1	Message	Date
Your Name	62d3bc8406	Stop swallowing overlay ValidationException into a generic 500 publishNext() throws ValidationException::withMessages() for invalid story overlays (bad text/hashtag/mention/url/type), but the enclosing catch (\Exception $e) caught it too, since ValidationException extends Exception. Clients got a generic 500 "Failed to create story" instead of the intended 422 with field-level errors, and the log was flooded with ordinary user-input validation failures logged as server errors. Catch ValidationException separately, roll back, and rethrow it so Laravel's exception handler renders the normal 422 response.	2 weeks ago

Author

SHA1

Message

Date

Your Name

62d3bc8406

Stop swallowing overlay ValidationException into a generic 500

publishNext() throws ValidationException::withMessages() for invalid
story overlays (bad text/hashtag/mention/url/type), but the enclosing
catch (\Exception $e) caught it too, since ValidationException extends
Exception. Clients got a generic 500 "Failed to create story" instead
of the intended 422 with field-level errors, and the log was flooded
with ordinary user-input validation failures logged as server errors.
Catch ValidationException separately, roll back, and rethrow it so
Laravel's exception handler renders the normal 422 response.

1 Commits (e1df7d657c33bb3b814c31d48d1dd990d71fda57)