pixelfed

Commit Graph

Author	SHA1	Message	Date
Your Name	c0f29d4a4b	Fix web notifications not loading (#7195 ) Notification status hydration compared item_type strictly against Status::class (App\Models\Status). Rows created before the App\ -> App\Models\ namespace migration store the legacy 'App\Status' morph-map alias, so the comparison failed and favourite/comment/mention notifications came back with no attached status. The web UI filters those out client-side but keeps paginating (response never empty), leaving the infinite-scroll loader spinning forever. - NotificationTransformer + Mastodon NotificationTransformer: match both the legacy alias and the current FQCN when hydrating status. - NotificationService::buildNotification: same alias-aware deleted-item guard. - NotificationService::getMaxPage/getMinPage: filter out unrenderable notifications (status-type without a hydrated status) so the endpoint never returns rows the UI discards, fixing pagination termination; warn on unexpected notification types. - Tests for transformer hydration (legacy + current), renderable filtering, the unexpected-type warning, and pagination termination.	2 weeks ago
Your Name	6d8ad3885a	Convert string class references to ::class Applies the ::class conversion from pixelfed-staging PR #9 (patch 1/21), formatted with Pint (short imported ::class form). Excludes the ModelNamespaceMigrationTest namespace assertions, which intentionally compare against literal namespace strings.	3 weeks ago
Your Name	e7b70c6084	refactor: extract duplicate patterns into shared methods 1. Add FractalService with static item() and collection() helpers replacing 22 call sites that repeated the 4-line Fractal Manager + ArraySerializer boilerplate. 2. Add AccountInterstitial::createFromStatus() factory method consolidating 4 identical 15-line blocks that create interstitials with status metadata. 3. Add NotificationService::createNotification() to handle the repeated pattern of creating, caching, and registering a notification in the recipient's feed. 4. Add NotificationService::firstOrCreateNotification() for idempotent notifications (share/boost, mention) that should only notify once per actor+action+item combination.	4 weeks ago

Author

SHA1

Message

Date

Your Name

c0f29d4a4b

Fix web notifications not loading (#7195 )

Notification status hydration compared item_type strictly against
Status::class (App\Models\Status). Rows created before the App\ ->
App\Models\ namespace migration store the legacy 'App\Status' morph-map
alias, so the comparison failed and favourite/comment/mention
notifications came back with no attached status. The web UI filters those
out client-side but keeps paginating (response never empty), leaving the
infinite-scroll loader spinning forever.

- NotificationTransformer + Mastodon NotificationTransformer: match both
  the legacy alias and the current FQCN when hydrating status.
- NotificationService::buildNotification: same alias-aware deleted-item guard.
- NotificationService::getMaxPage/getMinPage: filter out unrenderable
  notifications (status-type without a hydrated status) so the endpoint
  never returns rows the UI discards, fixing pagination termination; warn
  on unexpected notification types.
- Tests for transformer hydration (legacy + current), renderable filtering,
  the unexpected-type warning, and pagination termination.

Your Name

6d8ad3885a

Convert string class references to ::class

Applies the ::class conversion from pixelfed-staging PR #9 (patch 1/21),
formatted with Pint (short imported ::class form). Excludes the
ModelNamespaceMigrationTest namespace assertions, which intentionally
compare against literal namespace strings.

Your Name

e7b70c6084

refactor: extract duplicate patterns into shared methods

1. Add FractalService with static item() and collection() helpers
   replacing 22 call sites that repeated the 4-line Fractal Manager
   + ArraySerializer boilerplate.

2. Add AccountInterstitial::createFromStatus() factory method
   consolidating 4 identical 15-line blocks that create interstitials
   with status metadata.

3. Add NotificationService::createNotification() to handle the
   repeated pattern of creating, caching, and registering a
   notification in the recipient's feed.

4. Add NotificationService::firstOrCreateNotification() for
   idempotent notifications (share/boost, mention) that should
   only notify once per actor+action+item combination.

3 Commits (a2e38e5ffe26e5569195445698dfd5b329fb2105)