pixelfed

Commit Graph

Author	SHA1	Message	Date
Your Name	cd873c8976	Compute Year-in-Review averages in SQL instead of in PHP SeasonalController::getData computed the average posts/likes per profile by grouping in SQL, then pulling every grouped row into a collection and calling ->pluck('count')->avg() in PHP. This loaded one row per profile into memory just to average. Wrap the grouped per-profile counts in a subquery and let the database compute AVG(count), returning a single value. Also drops the invalid SELECT * with GROUP BY (ONLY_FULL_GROUP_BY) by selecting count(*) only. Adds a test verifying the average-of-per-profile-counts and its exclusions (remote, wrong type, out-of-range date), plus the empty case.	3 weeks ago

Author

SHA1

Message

Date

Your Name

cd873c8976

Compute Year-in-Review averages in SQL instead of in PHP

SeasonalController::getData computed the average posts/likes per profile
by grouping in SQL, then pulling every grouped row into a collection and
calling ->pluck('count')->avg() in PHP. This loaded one row per profile
into memory just to average.

Wrap the grouped per-profile counts in a subquery and let the database
compute AVG(count), returning a single value. Also drops the invalid
SELECT * with GROUP BY (ONLY_FULL_GROUP_BY) by selecting count(*) only.

Adds a test verifying the average-of-per-profile-counts and its
exclusions (remote, wrong type, out-of-range date), plus the empty case.

1 Commits (7ad550d2f74ea75b7a5c484b8f491337ca5ce317)