pixelfed

Commit Graph

Author	SHA1	Message	Date
Your Name	e4e12fad7c	Extract duplicated blocked-id and duplicate-shortcode query patterns Two query patterns were copy-pasted across several call sites: - The 'users who blocked me, plus myself' list used to filter profile search (UserFilter::whereFilterableId($pid)->pluck('user_id')->push($pid)) appeared in ComposeController (x2) and DirectMessageController. Extracted to UserFilterService::searchExcludedProfileIds(). Note this is the inverse of blocks() (who I blocked), so it is a distinct method. - CustomEmoji duplicate detection (groupBy('shortcode')->havingRaw( 'count(*) > 1')) appeared three times in AdminController. Extracted to a CustomEmoji::duplicateShortcodes() query scope. Adds tests for both. No behaviour change.	3 weeks ago

Author

SHA1

Message

Date

Your Name

e4e12fad7c

Extract duplicated blocked-id and duplicate-shortcode query patterns

Two query patterns were copy-pasted across several call sites:

- The 'users who blocked me, plus myself' list used to filter profile
  search (UserFilter::whereFilterableId($pid)->pluck('user_id')->push($pid))
  appeared in ComposeController (x2) and DirectMessageController. Extracted
  to UserFilterService::searchExcludedProfileIds(). Note this is the
  inverse of blocks() (who I blocked), so it is a distinct method.

- CustomEmoji duplicate detection (groupBy('shortcode')->havingRaw(
  'count(*) > 1')) appeared three times in AdminController. Extracted to a
  CustomEmoji::duplicateShortcodes() query scope.

Adds tests for both. No behaviour change.

1 Commits (252dea7016b961e81fb692730d6001412f878dda)