pixelfed

Commit Graph

Author	SHA1	Message	Date
Ashley	1df355b82a	Return 404 for reply permalinks whose parent was deleted Status::parent() returns null once a parent is soft- or force-deleted, so the reply permalink page dereferenced null and threw a 500 for guests. StatusController::show() now aborts 404 when a reply's parent is gone, and reply.blade.php guards the parent/grandparent blocks so rendering can never null-deref. Verified red->green: before the fix the soft-delete and force-delete cases returned 500 (Call to a member function parent() on null); after the fix all three cases pass (parent alive 200, soft-deleted 404, force-deleted 404).	1 week ago

Author

SHA1

Message

Date

Ashley

1df355b82a

Return 404 for reply permalinks whose parent was deleted

Status::parent() returns null once a parent is soft- or force-deleted, so the reply permalink page dereferenced null and threw a 500 for guests. StatusController::show() now aborts 404 when a reply's parent is gone, and reply.blade.php guards the parent/grandparent blocks so rendering can never null-deref.

Verified red->green: before the fix the soft-delete and force-delete cases returned 500 (Call to a member function parent() on null); after the fix all three cases pass (parent alive 200, soft-deleted 404, force-deleted 404).

1 Commits (dev)