pixelfed

Commit Graph

Author	SHA1	Message	Date
Your Name	0d01d5a963	Fix duplicate-key violation when importing remote media attachments Helpers::importNoteAttachment unconditionally inserted a new Media row per attachment, so re-importing a remote status (an Announce racing another inbox job, a re-fetch, or a duplicate url within one activity) hit the media_status_id_media_path_unique constraint and crashed the queue job with a 1062 UniqueConstraintViolationException, dropping the boost/import. Make createMediaAttachment idempotent on (status_id, media_path): skip when a row already exists, and catch the unique-constraint violation as a lost-race no-op, returning null so the caller skips re-dispatching storage. Adds regression tests (re-import no-op, distinct urls still stored, concurrent-insert returns null).	4 weeks ago

Author

SHA1

Message

Date

Your Name

0d01d5a963

Fix duplicate-key violation when importing remote media attachments

Helpers::importNoteAttachment unconditionally inserted a new Media row per
attachment, so re-importing a remote status (an Announce racing another
inbox job, a re-fetch, or a duplicate url within one activity) hit the
media_status_id_media_path_unique constraint and crashed the queue job with
a 1062 UniqueConstraintViolationException, dropping the boost/import.

Make createMediaAttachment idempotent on (status_id, media_path): skip when
a row already exists, and catch the unique-constraint violation as a
lost-race no-op, returning null so the caller skips re-dispatching storage.

Adds regression tests (re-import no-op, distinct urls still stored,
concurrent-insert returns null).

1 Commits (dev)