Merge pull request #6243 from pixelfed/shleeable-patch-6

Larastan: Update ResilientMediaStorageService.php (Variable $file might not be defined. )
2 weeks ago · e9c742a5e2
parent 3ea137dfd6 b59443d5f5
commit e9c742a5e2
1 changed files with 5 additions and 2 deletions
--- a/app/Services/ResilientMediaStorageService.php
+++ b/app/Services/ResilientMediaStorageService.php
@ -41,8 +41,11 @@ class ResilientMediaStorageService
            try {
                $disk = Storage::disk($baseDisk);
                $file = $disk->putFileAs($storagePath, new File($path), $name, 'public');
-            } catch (S3Exception | ClientException | ConnectException | UnableToWriteFile | Exception $e) {}
-            return $disk->url($file);
+                return $disk->url($file);
+            } catch (S3Exception | ClientException | ConnectException | UnableToWriteFile | Exception $e) {
+                Log::warning("ResilientMediaStorageService: Failed to handle Resilient Store {$file} : " . $e->getMessage());
+                throw $e;
+            }
        }, function (int $attempt, Exception $exception) {
            return $attempt * 200;
        });