Update StatusController, improve share api perf (11s to 72ms)

4 years ago · d48ebb829c
parent 3741c76da3
commit d48ebb829c
1 changed files with 4 additions and 5 deletions
--- a/app/Http/Controllers/StatusController.php
+++ b/app/Http/Controllers/StatusController.php
@ -237,16 +237,15 @@ class StatusController extends Controller

 		$user = Auth::user();
 		$profile = $user->profile;
-		$status = Status::withCount('shares')
-			->whereIn('scope', ['public', 'unlisted'])
+		$status = Status::whereIn('scope', ['public', 'unlisted'])
 			->findOrFail($request->input('item'));

-		$count = $status->shares()->count();
+		$count = $status->reblogs_count;

 		$exists = Status::whereProfileId(Auth::user()->profile->id)
 				  ->whereReblogOfId($status->id)
-				  ->count();
-		if ($exists !== 0) {
+				  ->exists();
+		if ($exists == true) {
 			$shares = Status::whereProfileId(Auth::user()->profile->id)
 				  ->whereReblogOfId($status->id)
 				  ->get();