From cd353a8305514377d8e55b3b3f7a026e1dc1988e Mon Sep 17 00:00:00 2001
From: Your Name <you@example.com>
Date: Sat, 29 Aug 2026 19:17:57 +0930
Subject: [PATCH] refactor: move resolved one-off migrations to Deprecated/

status:dedup and fix:avatars address historical data states that can no
longer occur (unique statuses.uri index since 2019; SVG identicon avatars
no longer generated). Move both to a Deprecated/ folder and update the
README audit accordingly. media:fix stays in FixBugs/ since image filters
are still an active feature.
---
 .../AvatarDefaultMigration.php                |  2 +-
 .../{FixBugs => Deprecated}/StatusDedupe.php  |  2 +-
 app/Console/Commands/README.md                | 43 +++++++++++++------
 3 files changed, 33 insertions(+), 14 deletions(-)
 rename app/Console/Commands/{FixBugs => Deprecated}/AvatarDefaultMigration.php (98%)
 rename app/Console/Commands/{FixBugs => Deprecated}/StatusDedupe.php (97%)

diff --git a/app/Console/Commands/FixBugs/AvatarDefaultMigration.php b/app/Console/Commands/Deprecated/AvatarDefaultMigration.php
similarity index 98%
rename from app/Console/Commands/FixBugs/AvatarDefaultMigration.php
rename to app/Console/Commands/Deprecated/AvatarDefaultMigration.php
index a46de5505..772555af2 100644
--- a/app/Console/Commands/FixBugs/AvatarDefaultMigration.php
+++ b/app/Console/Commands/Deprecated/AvatarDefaultMigration.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace App\Console\Commands\FixBugs;
+namespace App\Console\Commands\Deprecated;
 
 use App\Models\Avatar;
 use Illuminate\Console\Command;
diff --git a/app/Console/Commands/FixBugs/StatusDedupe.php b/app/Console/Commands/Deprecated/StatusDedupe.php
similarity index 97%
rename from app/Console/Commands/FixBugs/StatusDedupe.php
rename to app/Console/Commands/Deprecated/StatusDedupe.php
index 5d75016f8..8a69221a6 100644
--- a/app/Console/Commands/FixBugs/StatusDedupe.php
+++ b/app/Console/Commands/Deprecated/StatusDedupe.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace App\Console\Commands\FixBugs;
+namespace App\Console\Commands\Deprecated;
 
 use App\Jobs\StatusPipeline\StatusDelete;
 use App\Models\Status;
diff --git a/app/Console/Commands/README.md b/app/Console/Commands/README.md
index 939339875..cba979f73 100644
--- a/app/Console/Commands/README.md
+++ b/app/Console/Commands/README.md
@@ -13,6 +13,7 @@ full argument and option list.
 | Folder | Namespace | Purpose |
 | --- | --- | --- |
 | `Admin/` | `App\Console\Commands\Admin` | Instance administration and operator tooling |
+| `Deprecated/` | `App\Console\Commands\Deprecated` | Historical one-off migrations whose root issue is already resolved; kept for reference only |
 | `Dev/` | `App\Console\Commands\Dev` | Local development and localization build helpers |
 | `FixBugs/` | `App\Console\Commands\FixBugs` | One-off repair and data-fix utilities |
 | `Install/` | `App\Console\Commands\Install` | Installation and upgrade |
@@ -70,8 +71,7 @@ full argument and option list.
 | `admin:fixProfileCounts` | Resync a profile's cached counts (followers, following, statuses) from source tables; supports bulk `--all`/`--active`. |
 | `fix:usernames` | Fix invalid usernames. |
 | `app:hashtag-related-generate` | Generate related-hashtag data for a given tag. |
-| `media:fix` | Repair media filter data (legacy, requires v0.10.8+). |
-| `status:dedup` | Remove duplicate statuses from before the unique-URI migration. |
+| `media:fix` | Null out media `filter_class` values no longer present in `Filter::classes()`. Still relevant: image filters remain an active feature. |
 
 ## Install
 
@@ -106,6 +106,17 @@ These are primarily invoked by the scheduler (see `bootstrap/app.php`) rather th
 | `app:transform-imports` | Transform completed imports into statuses. |
 | `app:weekly-instance-scan` | Scan instance nodeinfo weekly. |
 
+## Deprecated
+
+Historical one-off migrations whose underlying issue is already resolved in the
+current codebase. Retained for reference and rare legacy-data recovery; not
+expected to be needed on a current install.
+
+| Command | Description | Why deprecated |
+| --- | --- | --- |
+| `status:dedup` | Remove duplicate statuses from before the unique-URI migration. | `statuses.uri` has had a unique index since the 2019 `add_unique_to_statuses_table` migration, so duplicate URIs can no longer be inserted. |
+| `fix:avatars` | Replace old SVG identicon avatars with the default PNG/JPG avatar. | SVG identicon avatars are no longer generated anywhere; new avatars default to `public/avatars/default.jpg`. |
+
 ## Status (debug/diagnostics)
 
 Read-only inspectors for troubleshooting. They do not modify data.
@@ -150,18 +161,26 @@ exist), and there are no duplicate command names.
 The items below are cleanup opportunities, not failures. Nothing here is deleted
 automatically — these are recommendations for a maintainer to confirm.
 
-### Likely obsolete (legacy one-off migrations)
+### Deprecated (root issue resolved — moved to `Deprecated/`)
+
+These were written to repair specific historical data states that can no longer
+occur in the current codebase. They have been moved to `Deprecated/`:
+
+- `Deprecated/StatusDedupe.php` (`status:dedup`) — dedupes statuses created
+  *before* the unique-URI migration. The unique index on `statuses.uri` has
+  existed since 2019 (`add_unique_to_statuses_table`), so duplicates can no
+  longer be inserted.
+- `Deprecated/AvatarDefaultMigration.php` (`fix:avatars`) — replaces old SVG
+  identicon avatars. No code generates SVG identicon avatars anymore; the
+  default is now `public/avatars/default.jpg`.
 
-These were written to repair specific historical data states and are unlikely to
-be needed on a current install. Candidates for removal after confirming they are
-no longer required:
+### Reviewed but kept
 
-- `FixBugs/MediaFix.php` (`media:fix`) — repairs image-filter data and refuses to
-  run below v0.10.8. Image filters are a deprecated feature.
-- `FixBugs/StatusDedupe.php` (`status:dedup`) — dedupes statuses created *before*
-  the unique-URI migration; not compatible with Postgres.
-- `FixBugs/AvatarDefaultMigration.php` (`fix:avatars`) — replaces old SVG
-  identicon avatars, a long-since-removed avatar style.
+- `FixBugs/MediaFix.php` (`media:fix`) — considered for deprecation, but **image
+  filters are still an active feature**: `filter_class` is validated and written
+  in `ComposeController`, `ApiV1Controller`, and `ApiV2Controller`, and
+  `Filter::classes()` returns a live list. The command still repairs media that
+  reference filter classes since removed from the set, so it stays in `FixBugs/`.
 
 ### Missing descriptions (metadata only)