From 2be73c4879773e84fac268f5199bd3132e8fef5f Mon Sep 17 00:00:00 2001 From: Your Name Date: Fri, 18 Sep 2026 14:01:31 +0930 Subject: [PATCH] Larastan Level 1 --- app/Http/Controllers/AvatarController.php | 1 + app/Http/Controllers/DiscoverController.php | 1 + app/Http/Controllers/GroupController.php | 1 + app/Http/Controllers/PublicApiController.php | 1 + app/Http/Controllers/Settings/RelationshipSettings.php | 1 + app/Jobs/GroupsPipeline/ImageS3UploadPipeline.php | 2 +- app/Jobs/ImportPipeline/ImportInstagram.php | 1 + app/Services/MediaStorageService.php | 2 ++ app/Services/ResilientMediaStorageService.php | 2 +- 9 files changed, 10 insertions(+), 2 deletions(-) diff --git a/app/Http/Controllers/AvatarController.php b/app/Http/Controllers/AvatarController.php index 1593ab21a..d6f616aed 100644 --- a/app/Http/Controllers/AvatarController.php +++ b/app/Http/Controllers/AvatarController.php @@ -84,6 +84,7 @@ class AvatarController extends Controller { $padded = str_pad($id, 19, 0, STR_PAD_LEFT); $parts = str_split($padded, 3); + $avatarpath = ''; foreach ($parts as $k => $part) { if ($k === 0) { $prefix = storage_path('app/public/avatars/'.$parts[0]); diff --git a/app/Http/Controllers/DiscoverController.php b/app/Http/Controllers/DiscoverController.php index 859c05325..e469ea53d 100644 --- a/app/Http/Controllers/DiscoverController.php +++ b/app/Http/Controllers/DiscoverController.php @@ -216,6 +216,7 @@ class DiscoverController extends Controller $pid = $request->user()->profile_id; abort_if(! $this->config()['memories']['enabled'], 404); $type = $request->input('type') ?? 'posts'; + $res = collect(); switch ($type) { case 'posts': diff --git a/app/Http/Controllers/GroupController.php b/app/Http/Controllers/GroupController.php index 934f599b7..52cb0e98d 100644 --- a/app/Http/Controllers/GroupController.php +++ b/app/Http/Controllers/GroupController.php @@ -325,6 +325,7 @@ class GroupController extends GroupFederationController $type = $request->input('type'); $item = $request->input('item'); + $res = null; switch ($type) { case 'instance': diff --git a/app/Http/Controllers/PublicApiController.php b/app/Http/Controllers/PublicApiController.php index 846f7357e..4ab13c46a 100644 --- a/app/Http/Controllers/PublicApiController.php +++ b/app/Http/Controllers/PublicApiController.php @@ -173,6 +173,7 @@ class PublicApiController extends Controller $scope = ['public', 'unlisted']; } + $replies = collect(); if ($request->filled('min_id') || $request->filled('max_id')) { if ($request->filled('min_id')) { $replies = $status->comments() diff --git a/app/Http/Controllers/Settings/RelationshipSettings.php b/app/Http/Controllers/Settings/RelationshipSettings.php index 74dcbee9f..5e89bb5fb 100644 --- a/app/Http/Controllers/Settings/RelationshipSettings.php +++ b/app/Http/Controllers/Settings/RelationshipSettings.php @@ -14,6 +14,7 @@ trait RelationshipSettings $mode = $request->input('mode') ?? 'followers'; $profile = $request->user()->profile; + $data = null; switch ($mode) { case 'following': diff --git a/app/Jobs/GroupsPipeline/ImageS3UploadPipeline.php b/app/Jobs/GroupsPipeline/ImageS3UploadPipeline.php index c60878804..2b83c607d 100644 --- a/app/Jobs/GroupsPipeline/ImageS3UploadPipeline.php +++ b/app/Jobs/GroupsPipeline/ImageS3UploadPipeline.php @@ -99,7 +99,7 @@ class ImageS3UploadPipeline implements ShouldQueue return $disk->url($file); } catch (S3Exception|ClientException|ConnectException|UnableToWriteFile|Exception $e) { - Log::warning("Groups ImageS3UploadPipeline: Failed to handle Resilient Store {$file} : ".$e->getMessage()); + Log::warning('Groups ImageS3UploadPipeline: Failed to handle Resilient Store : '.$e->getMessage()); throw $e; } }, function (int $attempt, Exception $exception) { diff --git a/app/Jobs/ImportPipeline/ImportInstagram.php b/app/Jobs/ImportPipeline/ImportInstagram.php index ef5535e0d..e39eba07b 100644 --- a/app/Jobs/ImportPipeline/ImportInstagram.php +++ b/app/Jobs/ImportPipeline/ImportInstagram.php @@ -81,6 +81,7 @@ class ImportInstagram implements ShouldQueue foreach ($collection as $import) { $caption = $import['caption']; + $taken_at = now(); try { $min = Carbon::create(2010, 10, 6, 0, 0, 0); $taken_at = Carbon::parse($import['taken_at']); diff --git a/app/Services/MediaStorageService.php b/app/Services/MediaStorageService.php index 60462a1a9..4fe5b9830 100644 --- a/app/Services/MediaStorageService.php +++ b/app/Services/MediaStorageService.php @@ -178,6 +178,8 @@ class MediaStorageService return; } + $ext = ''; + switch ($mime) { case 'image/png': $ext = '.png'; diff --git a/app/Services/ResilientMediaStorageService.php b/app/Services/ResilientMediaStorageService.php index 387ce757b..07d7658a3 100644 --- a/app/Services/ResilientMediaStorageService.php +++ b/app/Services/ResilientMediaStorageService.php @@ -47,7 +47,7 @@ class ResilientMediaStorageService return $disk->url($file); } catch (S3Exception|ClientException|ConnectException|UnableToWriteFile|Exception $e) { - Log::warning("ResilientMediaStorageService: Failed to handle Resilient Store {$file} : ".$e->getMessage()); + Log::warning('ResilientMediaStorageService: Failed to handle Resilient Store : '.$e->getMessage()); throw $e; } }, function (int $attempt, Exception $exception) {