Merge pull request #6244 from pixelfed/shleeable-patch-7

Larastan: Update ImageS3UploadPipeline.php (Variable $file might not be defined. )
2 weeks ago · 224053ecfa
parent e9c742a5e2 57307aaff1
commit 224053ecfa
1 changed files with 5 additions and 2 deletions
--- a/app/Jobs/GroupsPipeline/ImageS3UploadPipeline.php
+++ b/app/Jobs/GroupsPipeline/ImageS3UploadPipeline.php
@ -93,8 +93,11 @@ class ImageS3UploadPipeline implements ShouldQueue
            try {
                $disk = Storage::disk($baseDisk);
                $file = $disk->putFileAs($storagePath, new File($path), $name, 'public');
-            } catch (S3Exception | ClientException | ConnectException | UnableToWriteFile | Exception $e) {}
-            return $disk->url($file);
+                return $disk->url($file);
+            } catch (S3Exception | ClientException | ConnectException | UnableToWriteFile | Exception $e) {
+                Log::warning("Groups ImageS3UploadPipeline: Failed to handle Resilient Store {$file} : " . $e->getMessage());
+                throw $e;
+            }
        }, function (int $attempt, Exception $exception) {
            return $attempt * 200;
        });