added return type to function

app/Http/Controllers/Admin/AdminDirectoryController.php

@@ -24,7 +24,10 @@ trait AdminDirectoryController
         return view('admin.directory.home');
     }
 
-    public function directoryInitialData(Request $request)
+    /**
+     * @return mixed[]
+     */
+    public function directoryInitialData(Request $request): array
     {
         $res = [];
 
@@ -388,7 +391,7 @@ trait AdminDirectoryController
         return $existing;
     }
 
-    public function directorySaveTestimonial(Request $request)
+    public function directorySaveTestimonial(Request $request): array
     {
         $this->validate($request, [
             'username' => 'required',

app/Http/Controllers/Admin/AdminReportController.php

@@ -633,7 +633,7 @@ trait AdminReportController
         return [200];
     }
 
-    public function reportsStats(Request $request)
+    public function reportsStats(Request $request): array
     {
         $stats = [
             'total' => Report::count(),

app/Http/Controllers/Admin/AdminSettingsController.php

@@ -647,7 +647,7 @@ trait AdminSettingsController
         return $request->all();
     }
 
-    public function settingsApiUpdatePostsType($request)
+    public function settingsApiUpdatePostsType($request): array
     {
         $this->validate($request, [
             'max_caption_length' => 'required|integer|min:5|max:10000',
@@ -668,7 +668,7 @@ trait AdminSettingsController
         return $res;
     }
 
-    public function settingsApiUpdatePlatformType($request)
+    public function settingsApiUpdatePlatformType($request): array
     {
         $this->validate($request, [
             'allow_app_registration' => 'required',

app/Http/Controllers/AdminController.php

@@ -93,7 +93,7 @@ class AdminController extends Controller
         return AdminStatsService::summary();
     }
 
-    public function getAccounts()
+    public function getAccounts(): array
     {
         $users = User::orderByDesc('id')->cursorPaginate(10);
 
@@ -122,7 +122,7 @@ class AdminController extends Controller
         return $res;
     }
 
-    public function getPosts()
+    public function getPosts(): array
     {
         $posts = DB::table('statuses')
             ->orderByDesc('id')

app/Http/Controllers/Api/AdminApiController.php

@@ -98,7 +98,10 @@ class AdminApiController extends Controller
         return $appeals;
     }
 
-    public function autospamHandle(Request $request)
+    /**
+     * @return 'success'[]
+     */
+    public function autospamHandle(Request $request): array
     {
         abort_if(! $request->user() || ! $request->user()->token(), 404);
 

app/Http/Controllers/AvatarController.php

@@ -58,7 +58,7 @@ class AvatarController extends Controller
         return redirect()->back()->with('status', 'Avatar updated successfully. It may take a few minutes to update across the site.');
     }
 
-    public function getPath($user, $file)
+    public function getPath($user, $file): array
     {
         $basePath = storage_path('app/public/avatars');
         $this->checkDir($basePath);

app/Http/Controllers/ComposeController.php

@@ -164,7 +164,7 @@ class ComposeController extends Controller
         return response()->json($res);
     }
 
-    public function mediaUpdate(Request $request)
+    public function mediaUpdate(Request $request): array
     {
         $this->validate($request, [
             'id' => 'required',

app/Http/Controllers/Groups/GroupsCommentController.php

@@ -276,7 +276,7 @@ class GroupsCommentController extends Controller
         return redirect('/groups/feed');
     }
 
-    public function likePost(Request $request)
+    public function likePost(Request $request): array
     {
         $this->validate($request, [
             'gid' => 'required',
@@ -326,7 +326,7 @@ class GroupsCommentController extends Controller
         return $response;
     }
 
-    public function unlikePost(Request $request)
+    public function unlikePost(Request $request): array
     {
         $this->validate($request, [
             'gid' => 'required',

app/Http/Controllers/Groups/GroupsPostController.php

@@ -258,7 +258,7 @@ class GroupsPostController extends Controller
         }
     }
 
-    public function likePost(Request $request)
+    public function likePost(Request $request): array
     {
         $this->validate($request, [
             'gid' => 'required',
@@ -332,7 +332,7 @@ class GroupsPostController extends Controller
         return $response;
     }
 
-    public function unlikePost(Request $request)
+    public function unlikePost(Request $request): array
     {
         $this->validate($request, [
             'gid' => 'required',

app/Http/Controllers/InstallController.php

@@ -17,7 +17,7 @@ class InstallController extends Controller
         return view('installer.index');
     }
 
-    public function getRequirements()
+    public function getRequirements(): array
     {
         abort_if(file_exists(base_path('.env')), 404);
         $reqs = [];

app/Http/Controllers/LiveStreamController.php

@@ -194,7 +194,7 @@ class LiveStreamController extends Controller
         return $res;
     }
 
-    public function addChatComment(Request $request)
+    public function addChatComment(Request $request): array
     {
         abort_if(! config('livestreaming.enabled'), 400);
         abort_if(! $request->user(), 403);

app/Http/Controllers/ParentalControlsController.php

@@ -215,7 +215,7 @@ class ParentalControlsController extends Controller
         return redirect('/settings/parental-controls');
     }
 
-    protected function requestFormFields($request)
+    protected function requestFormFields($request): array
     {
         $state = [];
         $fields = [

app/Http/Controllers/PortfolioController.php

@@ -268,7 +268,10 @@ class PortfolioController extends Controller
         })->first();
     }
 
-    public function getAccountSettings(Request $request)
+    /**
+     * @return mixed[]
+     */
+    public function getAccountSettings(Request $request): array
     {
         $this->validate($request, [
             'id' => 'required|integer',

app/Http/Controllers/Settings/SecuritySettings.php

@@ -61,7 +61,10 @@ trait SecuritySettings
         return view('settings.security.2fa.setup', ['user' => $user, 'qrcode' => $qrcode, 'backups' => $backups]);
     }
 
-    protected function generateBackupCodes()
+    /**
+     * @return mixed[]
+     */
+    protected function generateBackupCodes(): array
     {
         $keys = [];
         for ($i = 0; $i < 11; $i++) {

app/Http/Controllers/Stories/StoryApiV1Controller.php

@@ -281,7 +281,7 @@ class StoryApiV1Controller extends Controller
         return response()->json($res, 200, [], JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES);
     }
 
-    public function add(Request $request)
+    public function add(Request $request): array
     {
         abort_if(! (bool) config_cache('instance.stories.enabled') || ! $request->user(), 404);
 

app/Models/CustomFilter.php

@@ -358,7 +358,7 @@ class CustomFilter extends Model
      * @param  mixed  $status  The status to check
      * @return array The filter matches
      */
-    public static function applyCachedFilters($cachedFilters, $status)
+    public static function applyCachedFilters($cachedFilters, $status): array
     {
         $results = [];
 

app/Models/Profile.php

@@ -320,7 +320,10 @@ class Profile extends Model
         return $this->is_private == true ? 'private' : 'public';
     }
 
-    public function getAudience($scope = false)
+    /**
+     * @return mixed[][]
+     */
+    public function getAudience($scope = false): array
     {
         if ($this->remote_url) {
             return [];

app/Models/Status.php

@@ -313,7 +313,7 @@ class Status extends Model
         return route('report.form')."?type=post&id={$this->id}";
     }
 
-    public function toActivityStream()
+    public function toActivityStream(): array
     {
         $media = $this->media;
         $mediaCollection = [];

app/Models/Story.php

@@ -91,7 +91,10 @@ class Story extends Model
         return Bearcap::encode($this->url(), $this->bearcap_token);
     }
 
-    public function scopeToAudience($scope)
+    /**
+     * @return list
+     */
+    public function scopeToAudience($scope): array
     {
         $res = [];
 

app/Services/AdminSettingsService.php

@@ -192,7 +192,10 @@ class AdminSettingsService
         ];
     }
 
-    public static function getCuratedOnboarding()
+    /**
+     * @return mixed[]
+     */
+    public static function getCuratedOnboarding(): array
     {
         $openReg = (bool) config_cache('pixelfed.open_registration');
         $curOnboarding = (bool) config_cache('instance.curated_registration.enabled');

app/Services/Groups/GroupsLikeService.php

@@ -71,7 +71,7 @@ class GroupsLikeService
         });
     }
 
-    public static function likedBy($status)
+    public static function likedBy($status): array
     {
         $empty = [
             'username' => null,

app/Services/MarkerService.php

@@ -13,7 +13,7 @@ class MarkerService
         return Cache::get(self::CACHE_KEY.$timeline.':'.$profileId);
     }
 
-    public static function set($profileId, $timeline = 'home', $entityId = false)
+    public static function set($profileId, $timeline = 'home', $entityId = false): array
     {
         $existing = self::get($profileId, $timeline);
         $key = self::CACHE_KEY.$timeline.':'.$profileId;

app/Services/SearchApiV2Service.php

@@ -372,7 +372,10 @@ class SearchApiV2Service
         }
     }
 
-    protected function resolveLocalStatus()
+    /**
+     * @return mixed[][]
+     */
+    protected function resolveLocalStatus(): array
     {
         $query = urldecode($this->query->input('q'));
         $query = last(explode('/', parse_url($query, PHP_URL_PATH)));

app/Services/UserRoleService.php

@@ -152,7 +152,7 @@ class UserRoleService
         ];
     }
 
-    public static function mapInvite($id, $data = [])
+    public static function mapInvite($id, $data = []): array
     {
         $roles = self::get($id);
 
@@ -193,7 +193,10 @@ class UserRoleService
         return $map;
     }
 
-    public static function mapActions($id, $data = [])
+    /**
+     * @return mixed[]
+     */
+    public static function mapActions($id, $data = []): array
     {
         $res = [];
         $map = [

app/Transformer/ActivityPub/ProfileTransformer.php

@@ -9,7 +9,7 @@ use League\Fractal;
 
 class ProfileTransformer extends Fractal\TransformerAbstract
 {
-    public function transform(Profile $profile)
+    public function transform(Profile $profile): array
     {
         $res = [
             '@context' => [

app/Transformer/Api/AccountTransformer.php

@@ -16,7 +16,10 @@ class AccountTransformer extends Fractal\TransformerAbstract
         // 'relationship',
     ];
 
-    public function transform(Profile $profile)
+    /**
+     * @return mixed[]
+     */
+    public function transform(Profile $profile): array
     {
         if (! $profile) {
             return [];

app/Transformer/Api/Mastodon/v1/AccountTransformer.php

@@ -8,7 +8,7 @@ use League\Fractal;
 
 class AccountTransformer extends Fractal\TransformerAbstract
 {
-    public function transform(Profile $profile)
+    public function transform(Profile $profile): array
     {
         $local = $profile->domain == null;
         $username = $local ? $profile->username : explode('@', substr($profile->username, 1))[0];

app/Transformer/Api/Mastodon/v1/MediaTransformer.php

@@ -7,7 +7,7 @@ use League\Fractal;
 
 class MediaTransformer extends Fractal\TransformerAbstract
 {
-    public function transform(Media $media)
+    public function transform(Media $media): array
     {
         $res = [
             'id' => (string) $media->id,

app/Transformer/Api/MediaTransformer.php

@@ -8,7 +8,7 @@ use League\Fractal;
 
 class MediaTransformer extends Fractal\TransformerAbstract
 {
-    public function transform(Media $media)
+    public function transform(Media $media): array
     {
         $res = [
             'id' => (string) $media->id,

app/Transformer/Api/NotificationTransformer.php

@@ -13,7 +13,7 @@ use League\Fractal;
 
 class NotificationTransformer extends Fractal\TransformerAbstract
 {
-    public function transform(Notification $notification)
+    public function transform(Notification $notification): array
     {
         $res = [
             'id' => (string) $notification->id,

app/Util/Lexer/Autolink.php

@@ -504,7 +504,7 @@ class Autolink extends Regex
      * @param  mixed  $obj
      * @return array
      */
-    protected function object2array($obj)
+    protected function object2array($obj): array
     {
         $array = (array) $obj;
         foreach ($array as $key => $var) {

app/Util/Lexer/Extractor.php

@@ -138,7 +138,7 @@ class Extractor extends Regex
      * @param  string  $tweet  The tweet to extract.
      * @return array The cashtag elements in the tweet.
      */
-    public function extractCashtags($tweet = null)
+    public function extractCashtags($tweet = null): array
     {
         $cashtagsOnly = [];
 
@@ -171,7 +171,7 @@ class Extractor extends Regex
      * @param  string  $tweet  The tweet to extract.
      * @return array The usernames elements in the tweet.
      */
-    public function extractMentionedScreennames($tweet = null)
+    public function extractMentionedScreennames($tweet = null): array
     {
         $usernamesOnly = [];
         $mentionsWithIndices = $this->extractMentionsOrListsWithIndices($tweet);
@@ -252,7 +252,7 @@ class Extractor extends Regex
      * @param  bool  $checkUrlOverlap  if true, check if extracted hashtags overlap URLs and remove overlapping ones
      * @return array The hashtag elements in the tweet.
      */
-    public function extractHashtagsWithIndices($tweet = null, $checkUrlOverlap = true)
+    public function extractHashtagsWithIndices($tweet = null, $checkUrlOverlap = true): array
     {
         if (is_null($tweet)) {
             $tweet = $this->tweet;
@@ -325,7 +325,7 @@ class Extractor extends Regex
      * @param  string  $tweet  The tweet to extract.
      * @return array The URLs elements in the tweet.
      */
-    public function extractURLsWithIndices($tweet = null)
+    public function extractURLsWithIndices($tweet = null): array
     {
         if (is_null($tweet)) {
             $tweet = $this->tweet;
@@ -447,7 +447,7 @@ class Extractor extends Regex
      * @param  string  $tweet  The tweet to extract.
      * @return array The username elements in the tweet.
      */
-    public function extractMentionsOrListsWithIndices($tweet = null)
+    public function extractMentionsOrListsWithIndices($tweet = null): array
     {
         if (is_null($tweet)) {
             $tweet = $this->tweet;
@@ -527,7 +527,7 @@ class Extractor extends Regex
      * @param  array  $entities
      * @return array
      */
-    public function removeOverlappingEntities($entities)
+    public function removeOverlappingEntities($entities): array
     {
         $result = [];
         usort($entities, [$this, 'sortEntites']);

app/Util/Lexer/RestrictedNames.php

@@ -364,7 +364,10 @@ class RestrictedNames
         '504',
     ];
 
-    public static function get()
+    /**
+     * @return mixed[]
+     */
+    public static function get(): array
     {
         $banned = [];