polish

4 weeks ago · 0ce89e9f95
parent c840d6bd71
commit 0ce89e9f95
3 changed files with 3032 additions and 13 deletions
--- a/2781
+++ b/2781
--- a/phpstan-baseline.neon
+++ b/phpstan-baseline.neon
@ -90,6 +90,12 @@ parameters:
 			count: 1
 			path: app/Http/Controllers/AccountController.php

+		-
+			message: '#^Do not use Auth\:\:user\(\) in a class that has access to the request\. Use \$request\-\>user\(\) instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 6
+			path: app/Http/Controllers/AccountController.php
+
 		-
 			message: '#^Call to static method collection\(\) on an unknown class App\\Http\\Controllers\\AdminProfile\.$#'
 			identifier: class.notFound
@ -336,6 +342,12 @@ parameters:
 			count: 1
 			path: app/Http/Controllers/Api/BaseApiController.php

+		-
+			message: '#^Do not use Auth\:\:user\(\) in a class that has access to the request\. Use \$request\-\>user\(\) instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 1
+			path: app/Http/Controllers/Api/BaseApiController.php
+
 		-
 			message: '#^Call to static method remember\(\) on an unknown class Cache\.$#'
 			identifier: class.notFound
@ -348,12 +360,48 @@ parameters:
 			count: 3
 			path: app/Http/Controllers/AvatarController.php

+		-
+			message: '#^Do not use Auth\:\:user\(\) in a class that has access to the request\. Use \$request\-\>user\(\) instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 2
+			path: app/Http/Controllers/AvatarController.php
+
+		-
+			message: '#^Do not use Auth\:\:user\(\) in a class that has access to the request\. Use \$request\-\>user\(\) instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 2
+			path: app/Http/Controllers/CircleController.php
+
+		-
+			message: '#^Do not use Auth\:\:check\(\) in a class that has access to the request\. Use \$request\-\>user\(\) \!\=\= null instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 2
+			path: app/Http/Controllers/CollectionController.php
+
+		-
+			message: '#^Do not use Auth\:\:user\(\) in a class that has access to the request\. Use \$request\-\>user\(\) instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 2
+			path: app/Http/Controllers/CollectionController.php
+
 		-
 			message: '#^Call to static method follows\(\) on an unknown class App\\Http\\Controllers\\FollowerService\.$#'
 			identifier: class.notFound
 			count: 1
 			path: app/Http/Controllers/CommentController.php

+		-
+			message: '#^Do not use Auth\:\:check\(\) in a class that has access to the request\. Use \$request\-\>user\(\) \!\=\= null instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 1
+			path: app/Http/Controllers/CommentController.php
+
+		-
+			message: '#^Do not use Auth\:\:user\(\) in a class that has access to the request\. Use \$request\-\>user\(\) instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 1
+			path: app/Http/Controllers/CommentController.php
+
 		-
 			message: '#^Call to static method forget\(\) on an unknown class Cache\.$#'
 			identifier: class.notFound
@ -366,6 +414,24 @@ parameters:
 			count: 3
 			path: app/Http/Controllers/ComposeController.php

+		-
+			message: '#^Do not use Auth\:\:user\(\) in a class that has access to the request\. Use \$request\-\>user\(\) instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 1
+			path: app/Http/Controllers/ComposeController.php
+
+		-
+			message: '#^Do not use Auth\:\:check\(\) in a class that has access to the request\. Use \$request\-\>user\(\) \!\=\= null instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 1
+			path: app/Http/Controllers/ContactController.php
+
+		-
+			message: '#^Do not use Auth\:\:user\(\) in a class that has access to the request\. Use \$request\-\>user\(\) instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 1
+			path: app/Http/Controllers/ContactController.php
+
 		-
 			message: '#^Relation ''keywords'' is not found in App\\Models\\CustomFilter model\.$#'
 			identifier: larastan.relationExistence
@ -396,6 +462,18 @@ parameters:
 			count: 3
 			path: app/Http/Controllers/DiscoverController.php

+		-
+			message: '#^Do not use Auth\:\:check\(\) in a class that has access to the request\. Use \$request\-\>user\(\) \!\=\= null instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 3
+			path: app/Http/Controllers/DiscoverController.php
+
+		-
+			message: '#^Do not use Auth\:\:user\(\) in a class that has access to the request\. Use \$request\-\>user\(\) instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 1
+			path: app/Http/Controllers/DiscoverController.php
+
 		-
 			message: '#^Call to static method get\(\) on an unknown class Cache\.$#'
 			identifier: class.notFound
@ -414,6 +492,12 @@ parameters:
 			count: 9
 			path: app/Http/Controllers/Groups/GroupsPostController.php

+		-
+			message: '#^Do not use Auth\:\:user\(\) in a class that has access to the request\. Use \$request\-\>user\(\) instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 1
+			path: app/Http/Controllers/HashtagFollowController.php
+
 		-
 			message: '#^Relation ''hashtag'' is not found in App\\HashtagFollow model\.$#'
 			identifier: larastan.relationExistence
@ -426,6 +510,12 @@ parameters:
 			count: 1
 			path: app/Http/Controllers/ImportController.php

+		-
+			message: '#^Do not use Auth\:\:user\(\) in a class that has access to the request\. Use \$request\-\>user\(\) instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 7
+			path: app/Http/Controllers/ImportController.php
+
 		-
 			message: '#^Call to static method error\(\) on an unknown class Log\.$#'
 			identifier: class.notFound
@ -450,12 +540,30 @@ parameters:
 			count: 2
 			path: app/Http/Controllers/InternalApiController.php

+		-
+			message: '#^Do not use Auth\:\:check\(\) in a class that has access to the request\. Use \$request\-\>user\(\) \!\=\= null instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 2
+			path: app/Http/Controllers/InternalApiController.php
+
+		-
+			message: '#^Do not use Auth\:\:user\(\) in a class that has access to the request\. Use \$request\-\>user\(\) instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 8
+			path: app/Http/Controllers/InternalApiController.php
+
 		-
 			message: '#^Relation ''status'' is not found in App\\DirectMessage model\.$#'
 			identifier: larastan.relationExistence
 			count: 1
 			path: app/Http/Controllers/InternalApiController.php

+		-
+			message: '#^Do not use Auth\:\:user\(\) in a class that has access to the request\. Use \$request\-\>user\(\) instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 1
+			path: app/Http/Controllers/MicroController.php
+
 		-
 			message: '#^Call to static method make\(\) on an unknown class View\.$#'
 			identifier: class.notFound
@ -468,6 +576,12 @@ parameters:
 			count: 2
 			path: app/Http/Controllers/MobileController.php

+		-
+			message: '#^Do not use Auth\:\:check\(\) in a class that has access to the request\. Use \$request\-\>user\(\) \!\=\= null instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 3
+			path: app/Http/Controllers/NewsroomController.php
+
 		-
 			message: '#^Call to static method forget\(\) on an unknown class Cache\.$#'
 			identifier: class.notFound
@ -510,6 +624,18 @@ parameters:
 			count: 9
 			path: app/Http/Controllers/ProfileController.php

+		-
+			message: '#^Do not use Auth\:\:check\(\) in a class that has access to the request\. Use \$request\-\>user\(\) \!\=\= null instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 3
+			path: app/Http/Controllers/ProfileController.php
+
+		-
+			message: '#^Do not use Auth\:\:user\(\) in a class that has access to the request\. Use \$request\-\>user\(\) instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 3
+			path: app/Http/Controllers/ProfileController.php
+
 		-
 			message: '#^Call to static method forget\(\) on an unknown class Cache\.$#'
 			identifier: class.notFound
@ -534,6 +660,24 @@ parameters:
 			count: 3
 			path: app/Http/Controllers/PublicApiController.php

+		-
+			message: '#^Do not use Auth\:\:check\(\) in a class that has access to the request\. Use \$request\-\>user\(\) \!\=\= null instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 3
+			path: app/Http/Controllers/PublicApiController.php
+
+		-
+			message: '#^Do not use Auth\:\:user\(\) in a class that has access to the request\. Use \$request\-\>user\(\) instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 1
+			path: app/Http/Controllers/PublicApiController.php
+
+		-
+			message: '#^Do not use Auth\:\:user\(\) in a class that has access to the request\. Use \$request\-\>user\(\) instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 1
+			path: app/Http/Controllers/ReportController.php
+
 		-
 			message: '#^Relation ''media'' is not found in App\\Status model\.$#'
 			identifier: larastan.relationExistence
@ -558,6 +702,12 @@ parameters:
 			count: 5
 			path: app/Http/Controllers/SiteController.php

+		-
+			message: '#^Do not use Auth\:\:check\(\) in a class that has access to the request\. Use \$request\-\>user\(\) \!\=\= null instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 1
+			path: app/Http/Controllers/SiteController.php
+
 		-
 			message: '#^Call to static method remember\(\) on an unknown class Cache\.$#'
 			identifier: class.notFound
@ -576,6 +726,18 @@ parameters:
 			count: 2
 			path: app/Http/Controllers/StatusController.php

+		-
+			message: '#^Do not use Auth\:\:check\(\) in a class that has access to the request\. Use \$request\-\>user\(\) \!\=\= null instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 1
+			path: app/Http/Controllers/StatusController.php
+
+		-
+			message: '#^Do not use Auth\:\:user\(\) in a class that has access to the request\. Use \$request\-\>user\(\) instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 8
+			path: app/Http/Controllers/StatusController.php
+
 		-
 			message: '#^Relation ''media'' is not found in App\\Status model\.$#'
 			identifier: larastan.relationExistence
@ -612,6 +774,12 @@ parameters:
 			count: 1
 			path: app/Http/Controllers/TimelineController.php

+		-
+			message: '#^Do not use Auth\:\:check\(\) in a class that has access to the request\. Use \$request\-\>user\(\) \!\=\= null instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 1
+			path: app/Http/Controllers/TimelineController.php
+
 		-
 			message: '#^Instantiated class App\\Transformer\\Api\\StatusTimelineTransformer not found\.$#'
 			identifier: class.notFound
@ -624,6 +792,18 @@ parameters:
 			count: 1
 			path: app/Http/Controllers/TimelineController.php

+		-
+			message: '#^Do not use Auth\:\:check\(\) in a class that has access to the request\. Use \$request\-\>user\(\) \!\=\= null instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 3
+			path: app/Http/Controllers/UserInviteController.php
+
+		-
+			message: '#^Do not use Auth\:\:user\(\) in a class that has access to the request\. Use \$request\-\>user\(\) instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 1
+			path: app/Http/Controllers/UserInviteController.php
+
 		-
 			message: '#^Class Laravel\\Passport\\Http\\Middleware\\CheckForAnyScope not found\.$#'
 			identifier: class.notFound
@ -636,6 +816,42 @@ parameters:
 			count: 1
 			path: app/Http/Kernel.php

+		-
+			message: '#^Do not use Auth\:\:check\(\) in a class that has access to the request\. Use \$request\-\>user\(\) \!\=\= null instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 1
+			path: app/Http/Middleware/AccountInterstitial.php
+
+		-
+			message: '#^Do not use Auth\:\:check\(\) in a class that has access to the request\. Use \$request\-\>user\(\) \!\=\= null instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 1
+			path: app/Http/Middleware/Admin.php
+
+		-
+			message: '#^Do not use Auth\:\:user\(\) in a class that has access to the request\. Use \$request\-\>user\(\) instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 1
+			path: app/Http/Middleware/Admin.php
+
+		-
+			message: '#^Do not use Auth\:\:check\(\) in a class that has access to the request\. Use \$request\-\>user\(\) \!\=\= null instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 1
+			path: app/Http/Middleware/Api/Admin.php
+
+		-
+			message: '#^Do not use Auth\:\:user\(\) in a class that has access to the request\. Use \$request\-\>user\(\) instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 1
+			path: app/Http/Middleware/Api/Admin.php
+
+		-
+			message: '#^Do not use Auth\:\:check\(\) in a class that has access to the request\. Use \$request\-\>user\(\) \!\=\= null instead\.$#'
+			identifier: larastan.noAuthFacadeInRequestScope
+			count: 1
+			path: app/Http/Middleware/DangerZone.php
+
 		-
 			message: '#^Call to static method get\(\) on an unknown class Session\.$#'
 			identifier: class.notFound
@ -1475,3 +1691,15 @@ parameters:
 			identifier: class.notFound
 			count: 1
 			path: app/Util/Site/Config.php
+
+		-
+			message: '#^Access to an undefined property Tests\\Unit\\ActivityPub\\AudienceScopeTest\:\:\$mastodon\.$#'
+			identifier: property.notFound
+			count: 3
+			path: tests/Unit/ActivityPub/AudienceScopeTest.php
+
+		-
+			message: '#^Access to an undefined property Tests\\Unit\\ActivityPub\\AudienceScopeTest\:\:\$pleroma\.$#'
+			identifier: property.notFound
+			count: 3
+			path: tests/Unit/ActivityPub/AudienceScopeTest.php
--- a/phpstan.neon
+++ b/phpstan.neon
@ -1,25 +1,35 @@
 includes:
    - vendor/larastan/larastan/extension.neon
+    - vendor/nesbot/carbon/extension.neon
    - phpstan-baseline.neon

 parameters:
-    paths:
-        - app/
-
+    # Level 10 is the highest level
    level: 0

-    ignoreErrors:
-        - '#Call to an undefined method [a-zA-Z0-9\\_]+::whereProfileId\(\)#'
-        - '#Call to an undefined method [a-zA-Z0-9\\_]+::whereFollowingId\(\)#'
-        - '#Call to an undefined method [a-zA-Z0-9\\_]+::whereUserId\(\)#'
-        - '#Call to an undefined method [a-zA-Z0-9\\_]+::whereAction\(\)#'
-        - '#Call to an undefined method [a-zA-Z0-9\\_]+::whereRegisterId\(\)#'
-        - '#Call to an undefined method [a-zA-Z0-9\\_]+::whereType\(\)#'
-        - '#Call to an undefined method [a-zA-Z0-9\\_]+::whereK\(\)#'
-        - '#Class App\\Http\\Controllers\\Settings\\FeedUnfollowPipeline not found#'
-        - '#Class App\\Observers\\FeedUnfollowPipeline not found#'
+    # Laravel specific configurations
+    noModelMake: true
+    noUnnecessaryCollectionCall: true
+    checkModelProperties: true
+    checkOctaneCompatibility: true
+    noEnvCallsOutsideOfConfig: true
+    checkModelAppends: true
+    checkModelMethodVisibility: true
+    checkAuthCallsWhenInRequestScope: true
+
+    checkMissingTranslations: false
+    translationDirectories:
+        - resources/lang
+
+    paths:
+        - app/
+        - routes/
+        - tests/

    excludePaths:
+        - bootstrap/cache/*
+        - storage/
+        - vendor/
        - app/Console/Commands/ImportCities.php
        - app/Http/Controllers/SettingsController.php
        - app/Observers/FollowerObserver.php