You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
mastodon/config
Claire 0a120d86d2
Fix error-prone SQL queries (#15828)
* Fix error-prone SQL queries in Account search

While this code seems to not present an actual vulnerability, one could
easily be introduced by mistake due to how the query is built.

This PR parameterises the `to_tsquery` input to make the query more robust.

* Harden code for Status#tagged_with_all and Status#tagged_with_none

Those two scopes aren't used in a way that could be vulnerable to an SQL
injection, but keeping them unchanged might be a hazard.

* Remove unneeded spaces surrounding tsquery term

* Please CodeClimate

* Move advanced_search_for SQL template to its own function

This avoids one level of indentation while making clearer that the SQL template
isn't build from all the dynamic parameters of advanced_search_for.

* Add tests covering tagged_with, tagged_with_all and tagged_with_none

* Rewrite tagged_with_none to avoid multiple joins and make it more robust

* Remove obsolete brakeman warnings

* Revert "Remove unneeded spaces surrounding tsquery term"

The two queries are not strictly equivalent.

This reverts commit 86f16c537e.
3 years ago
..
environments Fix SMTP_ENABLE_STARTTLS_AUTO/SMTP_TLS/SMTP_SSL environment variables don't work (#17216) 3 years ago
initializers Remove support for OAUTH_REDIRECT_AT_SIGN_IN (#17287) 3 years ago
locales Add OMNIAUTH_ONLY environment variable to enforce externa log-in (#17288) 3 years ago
webpack Bump jest from 26.6.3 to 27.1.0 (#16376) 4 years ago
application.rb Add S3_FORCE_SINGLE_REQUEST env var to work around S3 compatibility issues (#16866) 3 years ago
boot.rb Bump bootsnap from 1.6.0 to 1.8.1 (#16677) 3 years ago
brakeman.ignore Fix error-prone SQL queries (#15828) 3 years ago
database.yml
deploy.rb Change references to tootsuite/mastodon to mastodon/mastodon (#16491) 4 years ago
environment.rb
i18n-tasks.yml
navigation.rb Add batch suspend for accounts in admin UI (#17009) 3 years ago
pghero.yml
puma.rb
routes.rb Add support for editing for published statuses (#16697) 3 years ago
secrets.yml
settings.yml Change auto-following admin-selected accounts, show in recommendations (#16078) 4 years ago
sidekiq.yml Add trending links (#16917) 3 years ago
storage.yml
themes.yml
webpacker.yml