You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

ThibG 5524258da9 Fix “Email changed” notification sometimes having wrong e-mail (#13475) ... * Fix “Email changed” notification sometimes having wrong e-mail Fixes #6778 The root of the issue is that `send_devise_notification` was called before the changes were properly commited to the database, causing the mailer to pick previous values if running too early. Devise's documentation provides guidance on how to handle that[1][2], however, I have found it to not be working, as the following happens, in that order: - `send_devise_notification` is called for the `email_changed` notification. In that case, `changed?` is false and `saved_changes?` is true, so if we use the former, we have the same issue. - the `after_commit` hook is called - `send_devise_notification` is called for the `confirmation_instructions` notification. In that case, `changed?` is still false, and `saved_changes?` still true, so if we use the latter, that second notification email is simply not going to be sent (as we would be queuing the notification *after* executing the after_commit hook). This is because it may be called from either an `after_update` or `after_commit` hook, the difference not being a call to `save` but the transaction actually being committed to the database. This may arguably be a bug in Devise, or Devise's notification. The proposed workaround is inspired by Devise's documentation but checks whether a transaction is open to make the call whether to immediately send the notification or defer it to the `after_commit` hook. [1]: https://www.rubydoc.info/github/plataformatec/devise/Devise%2FModels%2FAuthenticatable:send_devise_notification [2]: 406915cb78/lib/devise/models/authenticatable.rb (L133-L194) * Fix cases when sending notifications without changing the model * Defer sending if and only if in transaction including current record		5 years ago
..
chewy	Fix bookmarks also searchable (#13293)	5 years ago
controllers	Add rate limit for reporting (#13390)	5 years ago
helpers	Add ability to filter audit log in admin UI (#13381)	5 years ago
javascript	Fix WebUI pagination of following, followers, follow requests, blocks and mutes lists (#13445)	5 years ago
lib	Add rate limit for reporting (#13390)	5 years ago
mailers	Fix error when sending moderation notification (#13014)	5 years ago
models	Fix “Email changed” notification sometimes having wrong e-mail (#13475)	5 years ago
policies	Add ability to delete files uploaded for settings in admin UI (#13192)	5 years ago
presenters	Fix n+1 query for bookmarks on statuses (#12494)	5 years ago
serializers	Change local media attachments to perform heavy processing asynchronously (#13210)	5 years ago
services	Fix returning results when searching for URL with non-zero offset (#13377)	5 years ago
validators	Improve polls: option lengths & redesign (#13257)	5 years ago
views	Fix “Email changed” notification sometimes having wrong e-mail (#13475)	5 years ago
workers	Fix trying to delete already deleted file when post-processing (#13406)	5 years ago