You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
mastodon/app
Claire 6da135a493
Fix reviving revoked sessions and invalidating login (#16943)
Up until now, we have used Devise's Rememberable mechanism to re-log users
after the end of their browser sessions. This mechanism relies on a signed
cookie containing a token. That token was stored on the user's record,
meaning it was shared across all logged in browsers, meaning truly revoking
a browser's ability to auto-log-in involves revoking the token itself, and
revoking access from *all* logged-in browsers.

We had a session mechanism that dynamically checks whether a user's session
has been disabled, and would log out the user if so. However, this would only
clear a session being actively used, and a new one could be respawned with
the `remember_user_token` cookie.

In practice, this caused two issues:
- sessions could be revived after being closed from /auth/edit (security issue)
- auto-log-in would be disabled for *all* browsers after logging out from one
  of them

This PR removes the `remember_token` mechanism and treats the `_session_id`
cookie/token as a browser-specific `remember_token`, fixing both issues.
3 years ago
..
chewy Change `tootctl search deploy` algorithm (#14300) 5 years ago
controllers Fix reviving revoked sessions and invalidating login (#16943) 3 years ago
helpers Add Northern Kurdish locale as requested by translator. It already has a project started on Crowdin. (#16548) 4 years ago
javascript ran `yarn manage:translations en` (#16912) 3 years ago
lib Add support for structured data and more OpenGraph tags to link cards (#16938) 3 years ago
mailers Prepare Mastodon for Rails 6 (#15911) 4 years ago
models Fix reviving revoked sessions and invalidating login (#16943) 3 years ago
policies Add ability to skip sign-in token authentication for specific users (#16427) 4 years ago
presenters Add graphs and retention metrics to admin dashboard (#16829) 4 years ago
serializers Add graphs and retention metrics to admin dashboard (#16829) 4 years ago
services Add support for structured data and more OpenGraph tags to link cards (#16938) 3 years ago
validators Minor memory optimizations (#16507) 4 years ago
views Add graphs and retention metrics to admin dashboard (#16829) 4 years ago
workers Fix AccountNote not having a maximum length (#16942) 3 years ago