mirror of https://github.com/mastodon/mastodon
6da135a493
Up until now, we have used Devise's Rememberable mechanism to re-log users after the end of their browser sessions. This mechanism relies on a signed cookie containing a token. That token was stored on the user's record, meaning it was shared across all logged in browsers, meaning truly revoking a browser's ability to auto-log-in involves revoking the token itself, and revoking access from *all* logged-in browsers. We had a session mechanism that dynamically checks whether a user's session has been disabled, and would log out the user if so. However, this would only clear a session being actively used, and a new one could be respawned with the `remember_user_token` cookie. In practice, this caused two issues: - sessions could be revived after being closed from /auth/edit (security issue) - auto-log-in would be disabled for *all* browsers after logging out from one of them This PR removes the `remember_token` mechanism and treats the `_session_id` cookie/token as a browser-specific `remember_token`, fixing both issues. |
3 years ago | |
|---|---|---|
| .. | ||
| chewy | 5 years ago | |
| controllers | 3 years ago | |
| helpers | 4 years ago | |
| javascript | 4 years ago | |
| lib | 3 years ago | |
| mailers | 4 years ago | |
| models | 3 years ago | |
| policies | 4 years ago | |
| presenters | 4 years ago | |
| serializers | 4 years ago | |
| services | 3 years ago | |
| validators | 4 years ago | |
| views | 4 years ago | |
| workers | 3 years ago | |