You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
mastodon/spec/lib
Claire 02851848e9
Revamp post filtering system (#18058)
* Add model for custom filter keywords

* Use CustomFilterKeyword internally

Does not change the API

* Fix /filters/edit and /filters/new

* Add migration tests

* Remove whole_word column from custom_filters (covered by custom_filter_keywords)

* Redesign /filters

Instead of a list, present a card that displays more information and handles
multiple keywords per filter.

* Redesign /filters/new and /filters/edit to add and remove keywords

This adds a new gem dependency: cocoon, as well as a npm dependency:
cocoon-js-vanilla. Those are used to easily populate and remove form fields
from the user interface when manipulating multiple keyword filters at once.

* Add /api/v2/filters to edit filter with multiple keywords

Entities:
- `Filter`: `id`, `title`, `filter_action` (either `hide` or `warn`), `context`
  `keywords`
- `FilterKeyword`: `id`, `keyword`, `whole_word`

API endpoits:
- `GET /api/v2/filters` to list filters (including keywords)
- `POST /api/v2/filters` to create a new filter
  `keywords_attributes` can also be passed to create keywords in one request
- `GET /api/v2/filters/:id` to read a particular filter
- `PUT /api/v2/filters/:id` to update a new filter
  `keywords_attributes` can also be passed to edit, delete or add keywords in
   one request
- `DELETE /api/v2/filters/:id` to delete a particular filter
- `GET /api/v2/filters/:id/keywords` to list keywords for a filter
- `POST /api/v2/filters/:filter_id/keywords/:id` to add a new keyword to a
   filter
- `GET /api/v2/filter_keywords/:id` to read a particular keyword
- `PUT /api/v2/filter_keywords/:id` to edit a particular keyword
- `DELETE /api/v2/filter_keywords/:id` to delete a particular keyword

* Change from `irreversible` boolean to `action` enum

* Remove irrelevent `irreversible_must_be_within_context` check

* Fix /filters/new and /filters/edit with update for filter_action

* Fix Rubocop/Codeclimate complaining about task names

* Refactor FeedManager#phrase_filtered?

This moves regexp building and filter caching to the `CustomFilter` class.

This does not change the functional behavior yet, but this changes how the
cache is built, doing per-custom_filter regexps so that filters can be matched
independently, while still offering caching.

* Perform server-side filtering and output result in REST API

* Fix numerous filters_changed events being sent when editing multiple keywords at once

* Add some tests

* Use the new API in the WebUI

- use client-side logic for filters we have fetched rules for.
  This is so that filter changes can be retroactively applied without
  reloading the UI.
- use server-side logic for filters we haven't fetched rules for yet
  (e.g. network error, or initial timeline loading)

* Minor optimizations and refactoring

* Perform server-side filtering on the streaming server

* Change the wording of filter action labels

* Fix issues pointed out by linter

* Change design of “Show anyway” link in accordence to review comments

* Drop “irreversible” filtering behavior

* Move /api/v2/filter_keywords to /api/v1/filters/keywords

* Rename `filter_results` attribute to `filtered`

* Rename REST::LegacyFilterSerializer to REST::V1::FilterSerializer

* Fix systemChannelId value in streaming server

* Simplify code by removing client-side filtering code

The simplifcation comes at a cost though: filters aren't retroactively
applied anymore.
3 years ago
..
activitypub Fix single Redis connection being used across all threads (#18135) 3 years ago
connection_pool Add request pool to improve delivery performance (#10353) 6 years ago
ostatus Remove Atom feeds and old URLs in the form of `GET /:username/updates/:id` (#11247) 6 years ago
settings Add a test for Settings::Extend#settings (#5720) 7 years ago
delivery_failure_tracker_spec.rb Fix single Redis connection being used across all threads (#18135) 3 years ago
emoji_formatter_spec.rb Change RSS feeds (#18356) 3 years ago
entity_cache_spec.rb Fix cache_collection crashing when given an empty collection (#15921) 4 years ago
extractor_spec.rb Spec Extractor (#3540) 8 years ago
fast_ip_map_spec.rb Add IP-based rules (#14963) 4 years ago
feed_manager_spec.rb Revamp post filtering system (#18058) 3 years ago
hash_object_spec.rb Spec HashObject (#3544) 8 years ago
html_aware_formatter_spec.rb Fix test-related issues (#17888) 3 years ago
link_details_extractor_spec.rb Add workaround for YouTube Shorts links (#17869) 3 years ago
permalink_redirector_spec.rb Change routing paths to use usernames in web UI (#16171) 4 years ago
plain_text_formatter_spec.rb Refactor formatter (#17828) 3 years ago
request_pool_spec.rb Add request pool to improve delivery performance (#10353) 6 years ago
request_spec.rb Fix connect timeout not being enforced (#9329) 6 years ago
sanitize_config_spec.rb Prepare Mastodon for zeitwerk autoloader (#15917) 4 years ago
scope_transformer_spec.rb Change authorized applications page (#17656) 3 years ago
status_filter_spec.rb Record account suspend/silence time and keep track of domain blocks (#10660) 6 years ago
status_finder_spec.rb Remove Atom feeds and old URLs in the form of `GET /:username/updates/:id` (#11247) 6 years ago
status_reach_finder_spec.rb Add support for editing for published statuses (#16697) 3 years ago
suspicious_sign_in_detector_spec.rb Remove sign-in token authentication, instead send e-mail about new sign-in (#17970) 3 years ago
tag_manager_spec.rb Spelling (#17705) 3 years ago
text_formatter_spec.rb Refactor formatter (#17828) 3 years ago
user_settings_decorator_spec.rb Enable updating additional account information from user preferences via rest api (#6789) 7 years ago
webfinger_resource_spec.rb Fix webfinger returning wrong status code on malformed or missing param (#13759) 5 years ago