Commit Graph

661 Commits (febdfefafe05c66fd4740321665f8c76e6744fa9)

Author SHA1 Message Date
Matt Jankowski 17c57c46e7
Add coverage for title/limit validations in `List` model (#31869) 5 months ago
Eugen Rochko e0c27a5047
Add ability to manage which websites can credit you in link previews (#31819) 5 months ago
Matt Jankowski d0ab94c4d2
Add `FeaturedTag` coverage, use `pick` in model (#31828) 5 months ago
Emelia Smith c88ba523ee
Fix sort order of moderation notes on Reports and Accounts (#31528) 5 months ago
Matt Jankowski 5acec087ca
Simplify basic presence validations (#29664) 5 months ago
Matt Jankowski ba9fd1c32e
Add coverage for `Account#prepare_contents` callback (#31748) 5 months ago
Matt Jankowski 14af5b47ac
Add coverage for model normalizations (#31734) 5 months ago
Matt Jankowski f1003b2560
Enable "zero monkey patching" mode in RSpec (#31614) 5 months ago
Matt Jankowski 7c26e5e4a1
Add `Reviewable` model concern (#31152) 5 months ago
Matt Jankowski 67faaf5557
Simplify account model username presence validation spec (#31013) 5 months ago
Matt Jankowski fcb83be8b2
Improve coverage specificity for Webhook enable/disable/secret specs (#31194) 5 months ago
Edward Moulsdale d4f135bc6d
Fix in memoriam accounts appearing in follow recommendations (#31474)
Co-authored-by: Utkarsh Wankar <46633523+kernal053@users.noreply.github.com>
6 months ago
Jeong Arm 95c11d365d
Don't push to cache buster if attachment path is nil (#31414) 6 months ago
Matt Jankowski 02df1b4e4a
Finish email allow/deny list naming migration (#30530) 6 months ago
Claire 994ef16b72
Bust CDN cache on media deletion (#31353) 6 months ago
Claire af2aec1a82
Change notification requests to only count mentions (#31322) 6 months ago
Emelia Smith c40e481169
Implement UI for Admin Search of Hashtags (#30880) 7 months ago
Adam Niedzielski 337a7fcf30
Fix ß bug in regexp for mentions and tags (#31122) 7 months ago
Matt Jankowski 6e4305de69
Fix spec descriptions around configurable limit values (#31079) 7 months ago
kyori19 3a00f89aa1
Respect `Account::DISPLAY_NAME_LENGTH_LIMIT` in account spec correctly (#31075) 7 months ago
Matt Jankowski 848b59c8ae
Reduce factory creation in `MediaAttachment` model spec (#31058) 7 months ago
Matt Jankowski 91ef4a6fc5
Add assertion about key columns to account key generate spec (#30635) 7 months ago
David Roetzel 35a437a03f
Destroy `NotificationRequest`s that are dismissed (#31008) 7 months ago
Matt Jankowski f1300ad284
Rename jobs/attachments rspec tag names (#29762) 7 months ago
Claire d41b43ed4f
Limit attachments to `MEDIA_ATTACHMENTS_LIMIT` when returning posts through the API (#30932) 7 months ago
Matt Jankowski 836c0477ac
Use vips setting instead of env var in media processing spec (#30859) 8 months ago
Matt Jankowski d818ddd687
Extract `SIGN_COUNT_LIMIT` constant in `WebauthnCredential` class (#30636) 8 months ago
Matt Jankowski 62d070c438
Check both before/after state in `AccountDomainBlock` spec (#30640) 8 months ago
Matt Jankowski 1622f7aeb9
Remove duplicate fabricator validity checks (#29667) 8 months ago
Matt Jankowski cfd4823b65
Use fabricator in follow_spec (#30642) 8 months ago
Matt Jankowski 9bf2e2eda0
Extract `TEXT_LENGTH_LIMIT` constant in `Appeal` class (#30638) 8 months ago
Matt Jankowski 3e3f3d7580
Match report validation spec to extracted constant (#30633) 8 months ago
Matt Jankowski 92b3004bf3
Reference constants from account validation specs (#30634) 8 months ago
Daniel M Brasil 28f9a8f2ec
Add Specs for Scheduled Status Model Validations (#30585) 8 months ago
Claire 1408733386
Fix Mastodon relying on ImageMagick even with `MASTODON_USE_LIBVIPS` (#30590) 8 months ago
Matt Jankowski a662c6d1d8
Use `sidekiq_inline` in admin/account_action model spec (#30565) 8 months ago
Eugen Rochko 5f15a892fa
Add support for libvips in addition to ImageMagick (#30090)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
8 months ago
Claire 974335e414
Add experimental server-side notification grouping (#29889) 8 months ago
Claire 30ef9fccf0
Fix hashtag matching pattern matching some link anchors (#30190) 9 months ago
Claire e5062b7135
Fix post deletion not being deferred when those are part of an account warning (#30163) 9 months ago
Matt Jankowski 1e7d5d2957
Update `devise-two-factor` to version 5.0.0 (#28325)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
9 months ago
Claire e845594878
Fix moderator account being exposed in account moderation notification (#30082) 10 months ago
Claire 4ef0b48b95
Add in-app notifications for moderation actions/warnings (#30065) 10 months ago
Matt Jankowski 11e0049b08
Use enum-generated scopes/queries for `BulkImport` (#29975) 10 months ago
Matt Jankowski 650c548c31
Add `not_featured_by` scope to Tag (#28815) 10 months ago
Matt Jankowski 6fed108703
Use Rails `upsert` to generate update_count! query in Counters concern (#28738)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
10 months ago
Matt Jankowski 285f63c02e
Use composable query in `User.active` scope (#29775) 10 months ago
Claire babbf6017d
Remove caching in `cache_collection` (#29862) 10 months ago
Claire 38b9d31f63
Improve email address validation (#29838) 10 months ago
Claire 44bf7b8128
Add notifications of severed relationships (#27511) 11 months ago
Claire d5063072c3
Revert friends-of-friends follow recommendation query to using a CTE (#29619) 11 months ago
Matt Jankowski 6262ceeb70
Fix `RSpec/DescribedClass` cop (#29472) 11 months ago
Matt Jankowski c09b8a7164
Add `Account.without_internal` scope (#29559)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
11 months ago
Matt Jankowski 01b624c4a0
Use `normalizes` on `CustomFilter#context` value (#27602) 11 months ago
Matt Jankowski 216cea1e27
Fix incorrect frequency value in `FriendsOfFriendsSource` data (#29550) 11 months ago
Eugen Rochko c10bbf5fe3
Add notification policies and notification requests in web UI (#29433) 11 months ago
Jeong Arm 4a6ddbc9c0
Normalize idna domain before account unblock domain (#29530) 11 months ago
Eugen Rochko 50b17f7e10
Add notification policies and notification requests (#29366) 11 months ago
Claire ee8d0b9447
Fix follow suggestions potentially including silenced or blocked accounts (#29306) 11 months ago
Daniel M Brasil a25014de8f
Improve `IpBlock` model test coverage (#29460) 12 months ago
Matt Jankowski 3389c41b58
Move `nobody` position in `UserRole` magic number to constant (#29465) 12 months ago
Matt Jankowski 1f648fdf1a
Remove erroneous service type on `TagFeed` model spec (#29302) 12 months ago
Matt Jankowski 64f9939e39
Use `capture_emails` helper to improve email assertions in specs (#29245) 12 months ago
Matt Jankowski 245064bb98
Move "everyone" role and "instance actor" account magic number IDs to constants (#29260) 12 months ago
Matt Jankowski 117b507df5
Extract `subject` from `User#mark_email_as_confirmed!` spec (#29231) 1 year ago
Matt Jankowski bba488c189
Reduce `RSpec/MultipleExpectations` in media_attachment spec (#29228) 1 year ago
Claire b31af34c97
Merge pull request from GHSA-vm39-j3vx-pch3
* Prevent different identities from a same SSO provider from accessing a same account

* Lock auth provider changes behind `ALLOW_UNSAFE_AUTH_PROVIDER_REATTACH=true`

* Rename methods to avoid confusion between OAuth and OmniAuth
1 year ago
Emelia Smith 68eaa804c9
Merge pull request from GHSA-7w3c-p9j8-mq3x
* Ensure destruction of OAuth Applications notifies streaming

Due to doorkeeper using a dependent: delete_all relationship, the destroy of an OAuth Application bypassed the existing AccessTokenExtension callbacks for announcing destructing of access tokens.

* Ensure password resets revoke access to Streaming API

* Improve performance of deleting OAuth tokens

---------

Co-authored-by: Claire <claire.github-309c@sitedethib.com>
1 year ago
Matt Jankowski 95da28d201
Add common `ThreadingHelper` module for specs (#29116) 1 year ago
Claire 66dda7c762
Fix already-invalid reports failing to resolve (#29027) 1 year ago
Matt Jankowski 6d35a77c92
Combine repeated subjects in `models/user` spec (#28937) 1 year ago
Matt Jankowski 42ab855b23
Add specs for `Instance` model scopes and add `with_domain_follows` scope (#28767) 1 year ago
Matt Jankowski 2866106ec1
Reduce factory creation in `spec/models/account_statuses_cleanup_policy` (#28361) 1 year ago
Matt Jankowski 6b6586f5d0
Add `CustomFilterKeyword#to_regex` method (#28893) 1 year ago
Matt Jankowski b0207d7757
Add coverage for `Tag.recently_used` scope (#28850) 1 year ago
Matt Jankowski 18004bf227
Add `Account.matches_uri_prefix` scope and use in activitypub/followers_synchronizations controller (#28820) 1 year ago
Matt Jankowski 1480573c83
Add `Account.auditable` scope, fix N+1 in admin/action_logs#index (#28812) 1 year ago
Matt Jankowski d0b3bc23d7
Remove unused `matches_domain` scopes on Account, DomainAllow, DomainBlock (#28803) 1 year ago
Matt Jankowski 07e10e3747
Combine assertions about same setup in `Account#suspend!` spec (#28787) 1 year ago
Matt Jankowski 1b0cb3b54d
Announcement reactions query spec improvement and refactor (#28768) 1 year ago
Claire 98b5f85f10
Rename and refactor `User#confirm!` to `User#mark_email_as_confirmed!` (#28735) 1 year ago
Matt Jankowski cd37048439
Move followable_by coverage to suggestions (#28697) 1 year ago
Matt Jankowski 8b26614fa7
Combine results include check in spec/models/account (#28471) 1 year ago
Matt Jankowski 0a7cff53c2
Add coverage for `Account.followable_by` scope (#28689) 1 year ago
Matt Jankowski 543d7890fd
Use normalizes to prepare `User` values (#28650)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
1 year ago
Matt Jankowski 00341c70ff
Use Sidekiq `fake!` instead of `inline!` in specs (#25369) 1 year ago
Claire 10203bd57a
Clean up `Setting` model and remove dead code (#28661) 1 year ago
Jean Boussier 1781849884
Inline what remains of the rails-settings-cached gem (#28618)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
1 year ago
Matt Jankowski 5dc634796a
Misc coverage improvements re: sidekiq/inline (#28651) 1 year ago
Matt Jankowski e677eb164c
Remove unused `Announcement#time_range?` (#28648) 1 year ago
Matt Jankowski 3e43cd095c
Remove unused scope `Announcement.without_muted` (#28645) 1 year ago
Matt Jankowski aa6d07dbd9
Use normalizes to prepare CustomEmoji `domain` value (#28624) 1 year ago
Matt Jankowski 12bed81187
Add validation specs to `CustomFilter` model (#28600) 1 year ago
Matt Jankowski bb8077e784
Fix `RSpec/LetSetup` cop in models/account_status_cleanup_policy (#28470) 1 year ago
Matt Jankowski e6e217fedd
Clean up `tagged_with_*` Status specs, fix `RSpec/LetSetup` cop (#28462) 1 year ago
Matt Jankowski c753b1ad35
Clean up of `RSpec/LetSetup` within `spec/models` (#28444) 1 year ago
Claire 6fed0fcbaa
Remove unneeded settings cleanup from specs (#28425) 1 year ago
Matt Jankowski af366f65ee
Add spec coverage for `models/form/custom_emoji_batch` class (#28388) 1 year ago
Matt Jankowski 1820bad646
Fix `Performance/StringIdentifierArgument` cop (#28399) 1 year ago
Matt Jankowski 28e1a7a394
Improve spec coverage for `models/announcement` class (#28350) 1 year ago
Matt Jankowski 89a8e6e622
Remove 2x double subject call in `models/form/account_batch` spec (#28209) 1 year ago
Matt Jankowski 5631f139c1
Fix `Lint/SymbolConversion` cop (#28175) 1 year ago
Matt Jankowski 440b80b2e7
Model concerns organization into module namespaces (#28149) 1 year ago
Matt Jankowski e48ecd2929
Remove `default_scope` from `Admin::ActionLog` (#28026) 1 year ago
Matt Jankowski 973597c6f1
Consolidate configuration of `Sidekiq::Testing.fake!` setup (#28046) 1 year ago
Eugen Rochko cdc57c74b7
Fix unsupported time zone or locale preventing sign-up (#28035)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
1 year ago
Matt Jankowski 371f355719
Reduce `.times` usage in `AccountStatusesCleanupPolicy` (#27947) 1 year ago
Matt Jankowski d2aacea8da
Reduce `.times` usage in AccountSearch spec, use constant for default limit (#27946) 1 year ago
Matt Jankowski 00c6ebd86f
Reduce `.times` usage in `StatusPin` and add `PIN_LIMIT` constant in validator (#27945) 1 year ago
Matt Jankowski b2c5b20ef2
Fix `RSpec/AnyInstance` cop (#27810) 1 year ago
Matt Jankowski b7807f3d84
Use `normalizes` to prepare `Webhook#events` value (#27605) 1 year ago
Matt Jankowski 63c9102f8a
Fix `RSpec/MessageChain` cop (#27776) 1 year ago
Matt Jankowski 69d00e2721
Fix `RSpec/InstanceVariable` cop (#27766) 1 year ago
Matt Jankowski ce91d14d48
Fix `Style/WordArray` cop (#27770) 1 year ago
Matt Jankowski 49e2772064
Fix `RSpec/MessageSpies` cop (#27751) 1 year ago
Matt Jankowski cfa14ec6d1
Fix `Lint/EmptyBlock` cop (#27748) 1 year ago
Matt Jankowski b06284c572
Fix `RSpec/HookArgument` cop (#27747) 1 year ago
Matt Jankowski 949f5eb860
Fix `RSpec/MetadataStyle` cop in spec/ (#27729) 1 year ago
Claire 93e4cdc31b
Fix hashtag matching pattern matching some URLs (#27584) 1 year ago
Claire bcae744275
Fix some link anchors being recognized as hashtags (#27271) 1 year ago
Matt Jankowski b0213472df
Validate allowed schemes on preview card URLs (#27485) 1 year ago
Matt Jankowski bcd0171e5e
Fix `Lint/UselessAssignment` cop (#27472) 1 year ago
Matt Jankowski a1b27d8b61
Fix `Naming/VariableNumber` cop (#27447) 1 year ago
Victor Lee c4bddc9855
Add spec for poll model (#23399)
Co-authored-by: Nick Schonning <nschonni@gmail.com>
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
1 year ago
Claire 340c390849
Fix crash when filtering for “dormant” relationships (#27306) 1 year ago
Matt Jankowski c676bc91e9
Dont match mention in url query string (#25656)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
1 year ago
Claire ceb365c419
Fix boosts of local users being filtered in account timelines (#27204) 1 year ago
Claire 1f99d86287
Fix blocked domain appears from account feed (#26823)
Co-authored-by: Jeong Arm <kjwonmail@gmail.com>
Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>
1 year ago
Christian Schmidt ea31929776
Fix invalid Content-Type header for WebP images (#26773) 1 year ago
Claire 16681e0f20
Add admin notifications for new Mastodon versions (#26582) 1 year ago
jsgoldstein 30c191aaa0
Add new public status index (#26344)
Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
1 year ago
Nick Schonning b970ed6098
Update rubocop and rubocop-rspec (#26329) 1 year ago
Matt Jankowski c363978782
Spec media attachment speedups (#25416) 2 years ago
Christian Schmidt f2257069b2
Fix AVIF attachments (#26264) 2 years ago
Matt Jankowski 6f1fa1364f
Fix `RSpec/EmptyExampleGroup` cop (#24735) 2 years ago
Claire 1e3b19230a
Add stricter protocol fields validation for accounts (#25937) 2 years ago
Matt Jankowski c75df62ccc
Fix `RSpec/SubjectDeclaration` cop (#25312) 2 years ago
Claire dc8f1fbd97
Merge pull request from GHSA-9928-3cp5-93fm
* Fix attachments getting processed despite failing content-type validation

* Add a restrictive ImageMagick security policy tailored for Mastodon

* Fix misdetection of MP3 files with large cover art

* Reject unprocessable audio/video files instead of keeping them unchanged
2 years ago
Matt Jankowski 05f9e39b32
Fix `RSpec/VerifiedDoubles` cop (#25469) 2 years ago
Claire dd07393e75
Fix user settings not getting validated (#25508) 2 years ago
Matt Jankowski 4c5aa0e470
Update rubocop-rspec to version 2.22.0, fix `RSpec/IndexedLet` cop (#24698) 2 years ago
Daniel M Brasil d9c6f70cc6
Fix `ArgumentError` in `/api/v1/admin/accounts/:id/action` (#25386) 2 years ago
Matt Jankowski ae9f5379d1
Reduce factory data created in spec/models/trends/statuses spec (#25410) 2 years ago
Matt Jankowski 62c996b52d
Reduce `RSpec/MultipleExpectations` cop max to 8 (#25313) 2 years ago
Matt Jankowski c94bb9ba9a
Disable paperclip processing in specs (#25359) 2 years ago
Matt Jankowski 6c0e3f490a
Fix RSpec/MissingExampleGroupArgument cop (#25310) 2 years ago
Matt Jankowski c42591356d
Fix `RSpec/DescribedClass` cop (#25104) 2 years ago
Matt Jankowski b22bfae4f9
Add coverage for `DomainBlock#public_domain` method (#25283) 2 years ago
Claire 8884d1ece0
Add support for importing lists (#25203) 2 years ago
Matt Jankowski d2e5430d4a
Fix RSpec/ExpectChange cop (#25101) 2 years ago