Commit Graph

22 Commits (fa43a6c8355ae53c0609999e1891023626ab4217)

Author SHA1 Message Date
Matt Jankowski 1e7d5d2957
Update `devise-two-factor` to version 5.0.0 ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Matt Jankowski 2ec9bff36e
Fix Rubocop `Rails/UniqueValidationWithoutIndex` cop ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Claire 70a8fcf07d
Fix notification policy migration not preserving `filter_private_mentions` correctly ()
Matt Jankowski 245064bb98
Move "everyone" role and "instance actor" account magic number IDs to constants ()
Matt Jankowski ca7053f19c
Consolidate db test prep steps to rake task ()
Matt Jankowski defe5f4076
Fix `Rails/WhereExists` cop in lib/tasks ()
gunchleoc 173953c23e
Fix ISO code for Canadian French ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Eugen Rochko 0d14fcebae
Change link previews to keep original URL from the status ()
Claire 890e334703
Add migration tests for negative settings ()
Claire cddef4c485
Fix language settings for users having selected the `kmr` language ()
Claire 6b896b20cc
Add primary key to preview_cards_statuses join table (includes deduplication migration) ()
Claire 1d588d58f1
Improve various queries against account domains ()
Nick Schonning 99e2e9b81f
Fix minor typos in comments and spec names ()
Matt Jankowski 60ac9e8634
Fix Rails/SquishedSQLHeredocs cop ()
Eugen Rochko a9b5598c97
Change user settings to be stored in a more optimal way ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Claire 0d70deee53
Add migration tests for user mail notification settings ()
Claire 66a70ebb6e
Fix pre-4.0 admin action logs ()
* Fix BackfillAdminActionLogs post-deployment migration

* Improve migration tests

* Backfill admin action logs again
Claire 1dca08b76f
Fix admin action logs page ()
* Add tests

* Fix crash when trying to display orphaned action logs

* Add migration for older admin action logs
Claire 02851848e9
Revamp post filtering system ()
* Add model for custom filter keywords

* Use CustomFilterKeyword internally

Does not change the API

* Fix /filters/edit and /filters/new

* Add migration tests

* Remove whole_word column from custom_filters (covered by custom_filter_keywords)

* Redesign /filters

Instead of a list, present a card that displays more information and handles
multiple keywords per filter.

* Redesign /filters/new and /filters/edit to add and remove keywords

This adds a new gem dependency: cocoon, as well as a npm dependency:
cocoon-js-vanilla. Those are used to easily populate and remove form fields
from the user interface when manipulating multiple keyword filters at once.

* Add /api/v2/filters to edit filter with multiple keywords

Entities:
- `Filter`: `id`, `title`, `filter_action` (either `hide` or `warn`), `context`
  `keywords`
- `FilterKeyword`: `id`, `keyword`, `whole_word`

API endpoits:
- `GET /api/v2/filters` to list filters (including keywords)
- `POST /api/v2/filters` to create a new filter
  `keywords_attributes` can also be passed to create keywords in one request
- `GET /api/v2/filters/:id` to read a particular filter
- `PUT /api/v2/filters/:id` to update a new filter
  `keywords_attributes` can also be passed to edit, delete or add keywords in
   one request
- `DELETE /api/v2/filters/:id` to delete a particular filter
- `GET /api/v2/filters/:id/keywords` to list keywords for a filter
- `POST /api/v2/filters/:filter_id/keywords/:id` to add a new keyword to a
   filter
- `GET /api/v2/filter_keywords/:id` to read a particular keyword
- `PUT /api/v2/filter_keywords/:id` to edit a particular keyword
- `DELETE /api/v2/filter_keywords/:id` to delete a particular keyword

* Change from `irreversible` boolean to `action` enum

* Remove irrelevent `irreversible_must_be_within_context` check

* Fix /filters/new and /filters/edit with update for filter_action

* Fix Rubocop/Codeclimate complaining about task names

* Refactor FeedManager#phrase_filtered?

This moves regexp building and filter caching to the `CustomFilter` class.

This does not change the functional behavior yet, but this changes how the
cache is built, doing per-custom_filter regexps so that filters can be matched
independently, while still offering caching.

* Perform server-side filtering and output result in REST API

* Fix numerous filters_changed events being sent when editing multiple keywords at once

* Add some tests

* Use the new API in the WebUI

- use client-side logic for filters we have fetched rules for.
  This is so that filter changes can be retroactively applied without
  reloading the UI.
- use server-side logic for filters we haven't fetched rules for yet
  (e.g. network error, or initial timeline loading)

* Minor optimizations and refactoring

* Perform server-side filtering on the streaming server

* Change the wording of filter action labels

* Fix issues pointed out by linter

* Change design of “Show anyway” link in accordence to review comments

* Drop “irreversible” filtering behavior

* Move /api/v2/filter_keywords to /api/v1/filters/keywords

* Rename `filter_results` attribute to `filtered`

* Rename REST::LegacyFilterSerializer to REST::V1::FilterSerializer

* Fix systemChannelId value in streaming server

* Simplify code by removing client-side filtering code

The simplifcation comes at a cost though: filters aren't retroactively
applied anymore.
Claire 33cd80d69c
Fix instance actor being incorrectly created when running migrations ()
* Add migration test about instance actor key

* Fix old migration

* Work around incorrect database state
Claire 61ae6b3535
Add more migration tests ()
* Add migration tests for hide_network settings migration

* Add tests about suspended/suspended_at

* Add more tests regarding the results of migrations

* Fix migration test regarding stale conflicting remote account

* Add migration tests about AccountConversation
Claire a0e06c3c3e
Add more advanced migration tests ()
- populate the database with some data when testing migrations
- try both one-step and two-step migrations (`SKIP_POST_DEPLOYMENT_MIGRATIONS`)