mastodon

Commit Graph

Author	SHA1	Message	Date
Matt Jankowski	c42591356d	Fix `RSpec/DescribedClass` cop (#25104 )	2 years ago
Claire	8884d1ece0	Add support for importing lists (#25203 )	2 years ago
Renaud Chaput	942d850b0a	Allow carets in URL search params (#25216 )	2 years ago
Christian Schmidt	69057467cb	Translate CW, poll options and media descriptions (#24175 ) Co-authored-by: Claire <claire.github-309c@sitedethib.com>	2 years ago
Matt Jankowski	0f2c16ac4b	Fix RSpec/NoExpectationExample cop (#25103 )	2 years ago
Matt Jankowski	d2e5430d4a	Fix RSpec/ExpectChange cop (#25101 )	2 years ago
Matt Jankowski	b896b16cb3	Fix RSpec/PredicateMatcher cop (#25102 )	2 years ago
Emelia Smith	19f9098551	Allow reports with long comments from remote instances, but truncate (#25028 )	2 years ago
Nick Schonning	99e2e9b81f	Fix minor typos in comments and spec names (#21831 )	2 years ago
Claire	b805b7f021	Add tests for avatar/header in backup service (#25037 )	2 years ago
Matt Jankowski	bf3ebeb42f	Fix RSpec/SharedContext cop (#24847 )	2 years ago
Matt Jankowski	a610a02d4f	Fix RSpec/ScatteredSetup cop (#24848 )	2 years ago
Matt Jankowski	710745e16b	Fix RSpec/ContextWording cop (#24739 )	2 years ago
Matt Jankowski	bdcd8a9e88	Misc spec cleanup (#24822 )	2 years ago
Claire	b233da5996	Optimize archive export service and export zip files instead of gzipped tar files (#23360 )	2 years ago
Claire	32a030dd74	Rewrite import feature (#21054 )	2 years ago
Nick Schonning	a3393d0d07	Autofix Rubocop RSpec/MatchArray (#24050 )	2 years ago
Matt Jankowski	10f0de4212	Refactor race condition reblog service spec (#24526 )	2 years ago
Claire	f53d009778	Refactor `Status._insert_record` slightly and tighten the test around reblogs of discarded statuses (#24516 )	2 years ago
Eugen Rochko	a9b5598c97	Change user settings to be stored in a more optimal way (#23630 ) Co-authored-by: Claire <claire.github-309c@sitedethib.com>	2 years ago
Christian Schmidt	eb38e9df31	Requeue expiration notification (#24311 )	2 years ago
Matt Jankowski	9da52ac044	Update rspec-rails to version 6.0.1 (#23908 )	2 years ago
Nick Schonning	6bd7003799	Fix mispelled spec filenames (#23834 )	2 years ago
Nick Schonning	84cc805cae	Enable Style/FrozenStringLiteralComment for specs (#23790 )	2 years ago
Nick Schonning	5116347eb7	Autofix Rubocop RSpec/BeEq (#23740 )	2 years ago
Nick Schonning	bf785df9fe	Audofix Rubocop Style/WordArray (#23739 )	2 years ago
Nick Schonning	4552685f6b	Autofix Rubocop RSpec/LeadingSubject (#23670 )	2 years ago
Nick Schonning	5179c47087	Autofix Rubocops RSpec/ScatteredLet (#23725 )	2 years ago
Nick Schonning	bd1d57c230	Autofix Rubocop RSpec/EmptyLineAfterSubject (#23719 )	2 years ago
Nick Schonning	65ba0d92ef	Enable Rubocop RSpec/NotToNot (#23723 )	2 years ago
Nick Schonning	81ad6c2e39	Autofix Rubocop Style/StringLiterals (#23695 )	2 years ago
Nick Schonning	3680e032b4	Autofix Rubocop RSpec/EmptyLineAfterFinalLet (#23707 )	2 years ago
Nick Schonning	08289a38fa	Autofix Rubocop Style/TrailingCommaInArrayLiteral (#23692 )	2 years ago
Nick Schonning	5069769cbe	Autofix Rubocop Style/TrailingCommaInHashLiteral (#23693 )	2 years ago
Nick Schonning	c38bd17657	Autofix Rubocop Style/TrailingCommaInArguments (#23694 )	2 years ago
Nick Schonning	e5cf23cf3a	Enable Rubocop RSpec/HooksBeforeExamples (#23668 )	2 years ago
Nick Schonning	634368c491	Autofix Rubocop Lint/SymbolConversion (#23683 )	2 years ago
Nick Schonning	669f6d2c0a	Run rubocop formatting except line length (#23632 )	2 years ago
Nick Schonning	6ed6c41724	Autofix Rubocop RSpec/EmptyLineAfterExample (#23661 )	2 years ago
Nick Schonning	936204b9ea	Autofix Rubocop Style/NestedParenthesizedCalls (#23646 )	2 years ago
Nick Schonning	37914c8757	Autofix Rubocop Style/MethodCallWithoutArgsParentheses (#23645 )	2 years ago
Claire	d6930b3847	Add API parameter to safeguard unexpect mentions in new posts (#18350 )	2 years ago
Claire	0c9eac80d8	Fix unbounded recursion in post discovery (#23506 ) * Add a limit to how many posts can get fetched as a result of a single request * Add tests * Always pass `request_id` when processing `Announce` activities --------- Co-authored-by: nametoolong <nametoolong@users.noreply.github.com>	2 years ago
Markus Unterwaditzer	f2a6e71bb6	Suppress AddressFamilyError in link verification (#23204 ) * Suppress AddressFamilyError * clarify comment	2 years ago
Claire	4b92e59f4f	Add support for editing media description and focus point of already-posted statuses (#20878 ) * Add backend support for editing media attachments of existing posts * Allow editing media attachments of already-posted toots * Add tests	2 years ago
Markus Unterwaditzer	0c689b9d01	fix: allow verification when page size exceeds 1MB (using HTML5 parser) (#22879 ) * fix: allow verification when page size exceeds 1MB Truncates the page after 1MB instead Closes #15316 * switch to HTML5 parser, fix rubocop errors * undo rubocop fixes Co-authored-by: Chris Zubak-Skees <chriszs@gmail.com>	2 years ago
Claire	18fb01ef7c	Fix possible race conditions when suspending/unsuspending accounts (#22363 ) * Fix possible race conditions when suspending/unsuspending accounts * Fix tests Tests were assuming SuspensionWorker and UnsuspensionWorker would do the suspending/unsuspending themselves, but this has changed.	2 years ago
Claire	c8849d6cee	Fix unbounded recursion in account discovery (#22025 ) * Fix trying to fetch posts from other users when fetching featured posts * Rate-limit discovery of new subdomains * Put a limit on recursively discovering new accounts	2 years ago
Claire	625216d8e1	Fix attachments of edited statuses not being fetched (#21565 ) * Fix attachments of edited statuses not being fetched * Fix tests	2 years ago
Rose	4f15fd0ba1	Fix style for hashes (#20518 ) * Fix style for hashes Make the style for hashes consistent. * New style More consistency	2 years ago
Joshua Wood	daf6f3453e	Handle links with no href in VerifyLinkService (#20741 ) Before this change, the following error would cause VerifyAccountLinksWorker to fail: NoMethodError: undefined method `downcase' for nil:NilClass [PROJECT_ROOT]/app/services/verify_link_service.rb:31 :in `block in link_back_present?`	2 years ago
Hampton Lintorn-Catlin	147d8bd8fc	Support UTF-8 Characters in Domains During CSV Import (#20592 ) * Support UTF-8 Characters in Domains During Import * Update Changelong	2 years ago
Claire	bbf74498f5	Fix validation error in SynchronizeFeaturedTagsCollectionWorker (#20018 ) * Fix followers count not being updated when migrating follows Fixes #19900 * Fix validation error in SynchronizeFeaturedTagsCollectionWorker Also saves remote user's chosen case for hashtags * Limit remote featured tags before validation	2 years ago
Claire	4fb0aae636	Change mentions of blocked users to not be processed (#19725 ) Fixes #19698	2 years ago
Claire	9387beb3b3	Change flaky AccountSearchService test (#19650 )	2 years ago
Yamagishi Kazutoshi	94feb2b93f	Fix `FetchFeaturedCollectionService` spec (#19401 ) Regression from #19380	2 years ago
Claire	7165e89362	Add tests to ActivityPub::FetchRemoteKeyService (#19226 )	2 years ago
Claire	26c51cfa07	Fix various rspec warnings in ReportService tests (#19189 ) * Fix various rspec warnings in ReportService tests * Add tests to ReportService	2 years ago
Claire	8cf7006d4e	Refactor ActivityPub handling to prepare for non-Account actors (#19212 ) * Move ActivityPub::FetchRemoteAccountService to ActivityPub::FetchRemoteActorService ActivityPub::FetchRemoteAccountService is kept as a wrapper for when the actor is specifically required to be an Account * Refactor SignatureVerification to allow non-Account actors * fixup! Move ActivityPub::FetchRemoteAccountService to ActivityPub::FetchRemoteActorService * Refactor ActivityPub::FetchRemoteKeyService to potentially return non-Account actors * Refactor inbound ActivityPub payload processing to accept non-Account actors * Refactor inbound ActivityPub processing to accept activities relayed through non-Account * Refactor how Account key URIs are built * Refactor Request and drop unused key_id_format parameter * Rename ActivityPub::Dereferencer `signature_account` to `signature_actor`	2 years ago
Eugen Rochko	50948b46aa	Add ability to filter followed accounts' posts by language (#19095 )	2 years ago
Claire	1145dbd327	Improve error reporting and logging when processing remote accounts (#15605 ) * Add a more descriptive PrivateNetworkAddressError exception class * Remove unnecessary exception class to rescue clause * Remove unnecessary include to JsonLdHelper * Give more neutral error message when too many webfinger redirects * Remove unnecessary guard condition * Rework how “ActivityPub::FetchRemoteAccountService” handles errors Add “suppress_errors” keyword argument to avoid raising errors in ActivityPub::FetchRemoteAccountService#call (default/previous behavior). * Rework how “ActivityPub::FetchRemoteKeyService” handles errors Add “suppress_errors” keyword argument to avoid raising errors in ActivityPub::FetchRemoteKeyService#call (default/previous behavior). * Fix Webfinger::RedirectError not being a subclass of Webfinger::Error * Add suppress_errors option to ResolveAccountService Defaults to true (to preserve previous behavior). If set to false, errors will be raised instead of caught, allowing the caller to be informed of what went wrong. * Return more precise error when failing to fetch account signing AP payloads * Add tests * Fixes * Refactor error handling a bit * Fix various issues * Add specific error when provided Digest is not 256 bits of base64-encoded data * Please CodeClimate * Improve webfinger error reporting	2 years ago
Eugen Rochko	d83faa1a89	Add ability to block sign-ups from IP (#19037 )	2 years ago
Claire	1b4054256f	Fix crash when a remote Flag activity mentions a private post (#18760 ) * Add tests * Fix crash when a remote Flag activity mentions a private post	3 years ago
Claire	e0bdaeab65	Fix NoMethodError when resolving a link that redirects to a local post (#18314 ) * Fix NoMethodError when resolving a link that redirects to a local post * Fix tests	3 years ago
Claire	71d02ffcf3	Fix compatibility with Friendica regarding pinned posts (#18254 ) * Fix multiple database queries when fetching pinned posts for remote account * Fix compatibility with Friendica regarding pinned posts Fixes #18066 * Add tests	3 years ago
Eugen Rochko	7b0fe4aef9	Fix opening and closing Redis connections instead of using a pool (#18171 ) * Fix opening and closing Redis connections instead of using a pool * Fix Redis connections not being returned to the pool in CLI commands	3 years ago
Claire	84d991988e	Fix temporary network/remote server error prevent from interactions with remote accounts (#18161 ) * Fix temporary network/remote server error prevent from interactions with remote accounts * Fix and add tests	3 years ago
Eugen Rochko	3917353645	Fix single Redis connection being used across all threads (#18135 ) * Fix single Redis connection being used across all Sidekiq threads * Fix tests	3 years ago
Claire	8f91e304a5	Fix spurious edits and require incoming edits to be explicitly marked as such (#17918 ) * Change post text edit to not be considered significant if it's identical after reformatting * We don't need to clear previous change information anymore * Require status edits to be explicit, except for poll tallies * Fix tests * Add some tests * Add poll-related tests * Add HTML-formatting related tests	3 years ago
Claire	30658924a8	Fix test-related issues (#17888 ) * Remove obsolete RSS::Serializer test Since #17828, RSS::Serializer no longer has specific code for deleted statuses, but it is never called on deleted statuses anyway. * Rename erroneously-named test files * Fix failing test * Fix test deprecation warnings * Update CircleCI Ruby orb 1.4.0 has a bug that does not match all the test files due to incorrect globbing	3 years ago
Eugen Rochko	71f2b95106	Fix edits with no actual changes being allowed (#17843 ) * Fix edits with no actual changes being allowed locally * Fix edits with no actual changes being allowed through ActivityPub * Fix false positive changes caused by description processing in model * Fix not recording poll expiration update * Fix test * Revert changes to ProcessStatusUpdateService * Various fixes and improvements * Fix code style issues * Various changes and improvements * Add guard clause	3 years ago
Claire	92a86b958e	Fix issues with processing toot edits (#17748 ) * Fix searching for an already-known status by URL not working * Fix Update processing from statuses prior to 20220302232632 `ordered_media_attachment_ids_changed?` would return `true` when going from `nil` to anything (including `[]`). * Add tests	3 years ago
Eugen Rochko	ddbe906c25	Fix not updating a status when newer version is fetched manually (#17745 )	3 years ago
Claire	5ccd6cbfda	Add test for reblog race condition fix (#17732 ) Follow-up to #17693	3 years ago
Claire	63c9d2bc28	Add tests for CVE-2022-24307 (#17733 ) Follow-up to #17426	3 years ago
Eugen Rochko	d17fb70131	Change how changes to media attachments are stored for edits (#17696 ) * Change how changes to media attachments are stored for edits Fix not being able to re-order media attachments * Fix not broadcasting updates when polls/media is changed through ActivityPub * Various fixes and improvements * Update app/models/report.rb Co-authored-by: Claire <claire.github-309c@sitedethib.com> * Add tracking of media attachment description changes * Change poll in status edit to have a structure closer to the real one Co-authored-by: Claire <claire.github-309c@sitedethib.com>	3 years ago
Josh Soref	b5329e0035	Spelling (#17705 ) * spelling: account Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: affiliated Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: appearance Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: autosuggest Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: cacheable Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: component Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: conversations Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: domain.example Clarify what's distinct and use RFC friendly domain space. Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: environment Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: exceeds Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: functional Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: inefficiency Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: not Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: notifications Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: occurring Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: position Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: progress Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: promotable Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: reblogging Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: repetitive Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: resolve Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: saturated Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: similar Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: strategies Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: success Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: targeting Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: thumbnails Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: unauthorized Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: unsensitizes Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: validations Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: various Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>	3 years ago
luzpaz	73f5e4a1d9	Fix various typos (#17621 ) Found via `codespell -q 3 -S ./CHANGELOG.md,./AUTHORS.md,./config/locales,./app/javascript/mastodon/locales -L ba,keypair,medias,ro`	3 years ago
Claire	d4e6774a0c	Fix Undo Announce sometimes inlining the originally Announced status (#17516 ) * Change tests to have more specific expectations on sent ActivityPub payloads * Check that payload doesn't actually contain the contents of the boosted toot * Fix Undo Announce sometimes inlining the originally Announced status	3 years ago
Claire	472bc89611	Fix some flaky tests that randomly failed because of item ordering (#17509 )	3 years ago
Claire	2af03164cb	Improve tests involving push_bulk (#17508 ) sidekiq-bulk's push_bulk can either accept arguments directly or run them through a block. Setting expectations on the result of evaluating the blocks allows testing more code (the block itself) and the test is moved closer to the interface of the tested code than its precise implementation.	3 years ago
Claire	63854bee6c	Fix poll votes not being properly reset on poll change (#17498 ) * Fix poll votes not being properly reset on poll change * Fix and add tests * Fix poll update handling when the number of options changes	3 years ago
Eugen Rochko	63002cde03	Add editing for published statuses (#17320 ) * Add editing for published statuses * Fix change of multiple-choice boolean in poll not resetting votes * Remove the ability to update existing media attachments for now	3 years ago
Claire	e38fc319dc	Refactor and improve tests (#17386 ) * Change account and user fabricators to simplify and improve tests - `Fabricate(:account)` implicitly fabricates an associated `user` if no `domain` attribute is given (an account with `domain: nil` is considered a local account, but no user record was created), unless `user: nil` is passed - `Fabricate(:account, user: Fabricate(:user))` should still be possible but is discouraged. * Fix and refactor tests - avoid passing unneeded attributes to `Fabricate(:user)` or `Fabricate(:account)` - avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other way around - prefer `Fabricate(:user, account_attributes: …)` to `Fabricate(:user, account: Fabricate(:account, …)` - also, some tests were using remote accounts with local user records, which is not representative of production code.	3 years ago
Eugen Rochko	1060666c58	Add support for editing for published statuses (#16697 ) * Add support for editing for published statuses * Fix references to stripped-out code * Various fixes and improvements * Further fixes and improvements * Fix updates being potentially sent to unauthorized recipients * Various fixes and improvements * Fix wrong words in test * Fix notifying accounts that were tagged but were not in the audience * Fix mistake	3 years ago
Claire	7f803c41e2	Add ability to purge undeliverable domains from admin interface (#16686 ) * Add ability to purge undeliverable domains from admin interface * Add tests	3 years ago
Eugen Rochko	7de0ee7aba	Remove Keybase integration (#17045 )	3 years ago
Claire	013bee6afb	Fix filtering DMs from non-followed users (#17042 )	3 years ago
Eugen Rochko	39cdf61ab7	Add support for structured data and more OpenGraph tags to link cards (#16938 ) Save preview cards under their canonical URL Increase max redirects to follow from 2 to 3	3 years ago
Claire	ec059317fa	Fix some link previews being incorrectly generated from other prior links (#16885 ) * Add tests * Fix some link previews being incorrectly generated from different prior links PR #12403 added a cache to avoid redundant queries when the OEmbed endpoint can be guessed from the URL. This caching mechanism is not perfectly correct as there is no guarantee that all pages from a given domain share the same OEmbed provider endpoint. This PR prevents the FetchOEmbedService from caching OEmbed endpoint that cannot be generalized by replacing a fully-qualified URL from the endpoint's parameters, greatly reducing the number of incorrect cached generalizations.	3 years ago
Claire	3f9b28ce26	Add support for fetching Create and Announce activities by URI (#16383 ) * Add support for fetching Create and Announce activities by URI This should improve compatibility with ZAP and offer a way to fetch boosts, which is currently not possible. * Add tests	3 years ago
Takeshi Umeda	17f4e457b3	Add remove from followers api (#16864 ) * Add followed_by? to account_interactions * Add RemoveFromFollowersService * Fix AccountBatch to use RemoveFromFollowersService * Add remove from followers API	3 years ago
Claire	216570ad98	Fix scheduled statuses decreasing statuses counts (#16791 ) * Add tests * Fix scheduled statuses decreasing statuses counts Fixes #16774	3 years ago
Claire	2b18f7a943	Fix processing mentions to domains with non-ascii TLDs (#16689 ) Fixes #16602	3 years ago
Claire	6702148472	Add tests for SuspendAccountService and UnsuspendAccountService (#16627 ) * Add tests for SuspendAccountService * Add tests for UnsuspendAccountService	3 years ago
Claire	13b08610a0	Fix crash when encountering invalid account fields (#16598 ) * Add test * Fix crash when encountering invalid account fields	4 years ago
Claire	4ac78e2a06	Add feature to automatically delete old toots (#16529 ) * Add account statuses cleanup policy model * Record last inspected toot to delete to speed up successive calls to statuses_to_delete * Add service to cleanup a given account's statuses within a budget * Add worker to go through account policies and delete old toots * Fix last inspected status id logic All existing statuses older or equal to last inspected status id must be kept by the current policy. This is an invariant that must be kept so that resuming deletion from the last inspected status remains sound. * Add tests * Refactor scheduler and add tests * Add user interface * Add support for discriminating based on boosts/favs * Add UI support for min_reblogs and min_favs, rework UI * Address first round of review comments * Replace Snowflake#id_at_start with with_random parameter * Add tests * Add tests for StatusesCleanupController * Rework settings page * Adjust load-avoiding mechanisms * Please CodeClimate	4 years ago
Claire	763ab0c7eb	Fix owned account notes not being deleted when an account is deleted (#16579 ) * Add account_notes relationship * Add tests * Fix owned account notes not being deleted when an account is deleted * Add post-migration to clean up orphaned account notes	4 years ago
Claire	225c6582d1	Add tests for BootstrapTimelineService (#16476 )	4 years ago
Claire	afb7882189	Fix blocking someone not clearing up list feeds (#16205 )	4 years ago

1 2 3 4 5 ...

372 Commits (efd16f3c2cf12c41bb39b6378007ef8f72e60652)