mastodon

Commit Graph

Author	SHA1	Message	Date
Akihiko Odaki	ae871c4d46	Make Array-creation behavior of Paginable more predictable (#14687 ) * Make Array-creation behavior of Paginable more predictable Paginable.paginate_by_id usually returns ActiveRecord::Relation, but it returns an Array if min_id option is present. The behavior caused problems fixed with the following commits: - `552e886b64` - `b63ede5005` - `64ef37b89d` To prevent from recurring similar problems, this commit introduces two changes: - The scope now always returns an Array whether min_id option is present or not. - The scope is renamed to to_a_paginated_by_id to clarify it returns an Array. * Transform Paginable.to_a_paginated_by_id from a scope to a class method https://api.rubyonrails.org/classes/ActiveRecord/Scoping/Named/ClassMethods.html#method-i-scope > The method is intended to return an ActiveRecord::Relation object, which > is composable with other scopes. Paginable.to_a_paginated_by_id returns an Array and is not appropriate as a scope.	5 years ago
Eugen Rochko	bf477cee9f	Fix videos with near-60 fps being rejected (#14684 ) Fix #14668	5 years ago
santiagorodriguez96	e8d41bc2fe	Add WebAuthn as an alternative 2FA method (#14466 ) * feat: add possibility of adding WebAuthn security keys to use as 2FA This adds a basic UI for enabling WebAuthn 2FA. We did a little refactor to the Settings page for editing the 2FA methods – now it will list the methods that are available to the user (TOTP and WebAuthn) and from there they'll be able to add or remove any of them. Also, it's worth mentioning that for enabling WebAuthn it's required to have TOTP enabled, so the first time that you go to the 2FA Settings page, you'll be asked to set it up. This work was inspired by the one donde by Github in their platform, and despite it could be approached in different ways, we decided to go with this one given that we feel that this gives a great UX. Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com> * feat: add request for WebAuthn as second factor at login if enabled This commits adds the feature for using WebAuthn as a second factor for login when enabled. If users have WebAuthn enabled, now a page requesting for the use of a WebAuthn credential for log in will appear, although a link redirecting to the old page for logging in using a two-factor code will also be present. Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com> * feat: add possibility of deleting WebAuthn Credentials Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com> * feat: disable WebAuthn when an Admin disables 2FA for a user Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com> * feat: remove ability to disable TOTP leaving only WebAuthn as 2FA Following examples form other platforms like Github, we decided to make Webauthn 2FA secondary to 2FA with TOTP, so that we removed the possibility of removing TOTP authentication only, leaving users with just WEbAuthn as 2FA. Instead, users will have to click on 'Disable 2FA' in order to remove second factor auth. The reason for WebAuthn being secondary to TOPT is that in that way, users will still be able to log in using their code from their phone's application if they don't have their security keys with them – or maybe even lost them. * We had to change a little the flow for setting up TOTP, given that now it's possible to setting up again if you already had TOTP, in order to let users modify their authenticator app – given that now it's not possible for them to disable TOTP and set it up again with another authenticator app. So, basically, now instead of storing the new `otp_secret` in the user, we store it in the session until the process of set up is finished. This was because, as it was before, when users clicked on 'Edit' in the new two-factor methods lists page, but then went back without finishing the flow, their `otp_secret` had been changed therefore invalidating their previous authenticator app, making them unable to log in again using TOTP. Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com> * refactor: fix eslint errors The PR build was failing given that linting returning some errors. This commit attempts to fix them. * refactor: normalize i18n translations The build was failing given that i18n translations files were not normalized. This commits fixes that. * refactor: avoid having the webauthn gem locked to a specific version * refactor: use symbols for routes without '/' * refactor: avoid sending webauthn disabled email when 2FA is disabled When an admins disable 2FA for users, we were sending two mails to them, one notifying that 2FA was disabled and the other to notify that WebAuthn was disabled. As the second one is redundant since the first email includes it, we can remove it and send just one email to users. * refactor: avoid creating new env variable for webauthn_origin config * refactor: improve flash error messages for webauthn pages Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com>	5 years ago
niwatori24	8b61bb1c3e	Cache result of SQL (#14534 )	5 years ago
Takeshi Umeda	7540e235a2	Fix movie width and frame_rate returning nil (#14357 ) * Fix movie width and frame_rate returning nil * Add StreamValidationError and raise * Fix code style	5 years ago
abcang	6a96af4d20	Fix rubocop warning (#14288 ) * Fix rubocop warning * use limit variable * use ContextCreatingMethods option	5 years ago
ThibG	a8e84a18f1	Fix larger video files not being transcoded (#14306 ) Since #14145, the `set_type_and_extension` has been moved from `before_post_process` to `before_file_post_process`, but while the former runs before all validations performed by Paperclip, the latter is dependent on the order validations and hooks are defined. In our case, this meant video files could be checked against the generic 10MB limit, causing validation failures, which, internally, make Paperclip skip post-processing, and thus, transcoding of the video file. The actual validation would then happen after the type is correctly set, so the large file would pass validation, but without being transcoded first. This commit moves the hook definition so that it is run before checking for the file size.	5 years ago
Eugen Rochko	99f3a55540	Add color extraction for audio thumbnails (#14209 )	5 years ago
Eugen Rochko	6d23d40420	Change Redis#exists calls to Redis#exists? to avoid deprecation warning (#14191 )	5 years ago
Eugen Rochko	7aaf2b44ec	Fix remote files not using Content-Type header, streaming (#14184 )	5 years ago
ThibG	65506bac3f	Add user notes on accounts (#14148 ) * Add UserNote model * Add UI for user notes * Put comment in relationships entity * Add API to create user notes * Copy user notes to new account when receiving a Move activity * Address some of the review remarks * Replace modal by inline edition * Please CodeClimate * Button design changes * Change design again * Cancel note edition when pressing Escape * Fixes * Tweak design again * Move “Add note” item, and allow users to add notes to themselves * Rename UserNote into AccountNote, rename “comment” Relationship attribute to “note”	5 years ago
Eugen Rochko	1b198d6489	Fix trying to write non-existent image remote URL attribute on preview cards (#14181 ) Regression from #14145	5 years ago
Eugen Rochko	64aac30733	Add customizable thumbnails for audio and video attachments (#14145 ) - Change audio files to not be stripped of metadata - Automatically extract cover art from audio if it exists - Add `thumbnail` parameter to `POST /api/v1/media`, `POST /api/v2/media` and `PUT /api/v1/media/:id` - Add `icon` to represent it in attachments in ActivityPub - Fix `preview_url` containing URL of missing missing image when there is no thumbnail instead of null - Fix duration of audio not being displayed on public pages until the file is loaded	5 years ago
Eugen Rochko	662a49dc3f	Fix various issues around OpenGraph representation of media (#14133 ) - Fix audio attachments not being represented in OpenGraph tags - Fix audio being represented as "1 image" in OpenGraph descriptions - Fix video metadata being overwritten by paperclip-av-transcoder - Fix embedded player not using Mastodon's UI - Fix audio/video progress bars not moving smoothly - Fix audio/video buffered bars not displaying correctly	5 years ago
Eugen Rochko	72a7cfaa39	Add e-mail-based sign in challenge for users with disabled 2FA (#14013 )	5 years ago
ThibG	346d9b3d2e	Add blurhash to preview cards (#13984 ) Fixes #13001	5 years ago
Eugen Rochko	5d8398c8b8	Add E2EE API (#13820 )	5 years ago
ThibG	51ff679b9d	Fix admin page crashing when trying to block an invalid domain name (#13884 ) * Fix admin page crashing when trying to block an invalid domain name Fixes #13880 * Fix trailing and leading spaces not being properly stripped for domain blocks	5 years ago
Takeshi Umeda	8e056bd82e	Fix csv upload (#13835 )	5 years ago
Takeshi Umeda	e6706d171a	Fix searchable status without explicitly mentioning it (#13829 )	5 years ago
dependabot-preview[bot]	78202e9138	Bump doorkeeper from 5.3.3 to 5.4.0 (#13733 ) * Bump doorkeeper from 5.3.3 to 5.4.0 Bumps [doorkeeper](https://github.com/doorkeeper-gem/doorkeeper) from 5.3.3 to 5.4.0. - [Release notes](https://github.com/doorkeeper-gem/doorkeeper/releases) - [Changelog](https://github.com/doorkeeper-gem/doorkeeper/blob/master/CHANGELOG.md) - [Commits](https://github.com/doorkeeper-gem/doorkeeper/compare/v5.3.3...v5.4.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Fix tests * Fix use of Doorkeeper::AccessToken.find_or_create_for * Fix tests? Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Thibaut Girka <thib@sitedethib.com>	5 years ago
Eugen Rochko	4b766f9846	Refactor monkey-patching of Goldfinger (#12561 )	5 years ago
Takeshi Umeda	26b08a3c54	Add remote only to public timeline (#13504 ) * Add remote only to public timeline * Fix code style	5 years ago
ThibG	a4240fd027	Improve RSS entries for statuses (#13592 ) * Improve RSS entries for statuses - Render polls in both accounts and tags serializers - Refactor RSS serializers - Change title preview to include ellipsis when truncated - Change title preview to show CW instead of toot text - Add tests * Remove title from OEmbed serialization Twitter doesn't serialize title either, and tihs allows us to move the title formatting code to the RSS serializers.	5 years ago
Taras Gogol	6748a5acb1	Fix followings list order \| Issue #13538 (#13676 )	5 years ago
Yamagishi Kazutoshi	e223fd8c61	Revert "improve status title (#8596 )" (#13591 ) This reverts commit `05756c9a14`.	5 years ago
Eugen Rochko	988b0493fe	Add more tests for ActivityPub controllers (#13585 )	5 years ago
kaiyou	3511528e50	Only check locally when deduplicating usernames (#13581 ) When deduplicating account usernames for OAuthable users, the routine did check if any account was known with that username, including remote accounts. This caused some unnecessary deduplication, and usernames ending with unexpected trailing _1. This fixes #13580	5 years ago
Eugen Rochko	c3ca3801f2	Add separate cache directory for non-local uploads (#12821 )	5 years ago
Takeshi Umeda	46b2cc184f	Fix enable/disable relay failures (#13535 )	5 years ago
ThibG	3825e1943f	Fix confusing error when failing to add an alias to an unknown account (#13480 ) Follow-up to #13452, fixing broken `uri.nil?` test. Also remove the separate check for `uri` presence, as that would result in a “Please review 2 errors below” while only one would be listed.	5 years ago
Eugen Rochko	5edff32733	Change delivery failure tracking to work with hostnames instead of URLs (#13437 )	5 years ago
ThibG	5524258da9	Fix “Email changed” notification sometimes having wrong e-mail (#13475 ) * Fix “Email changed” notification sometimes having wrong e-mail Fixes #6778 The root of the issue is that `send_devise_notification` was called before the changes were properly commited to the database, causing the mailer to pick previous values if running too early. Devise's documentation provides guidance on how to handle that[1][2], however, I have found it to not be working, as the following happens, in that order: - `send_devise_notification` is called for the `email_changed` notification. In that case, `changed?` is false and `saved_changes?` is true, so if we use the former, we have the same issue. - the `after_commit` hook is called - `send_devise_notification` is called for the `confirmation_instructions` notification. In that case, `changed?` is still false, and `saved_changes?` still true, so if we use the latter, that second notification email is simply not going to be sent (as we would be queuing the notification after executing the after_commit hook). This is because it may be called from either an `after_update` or `after_commit` hook, the difference not being a call to `save` but the transaction actually being committed to the database. This may arguably be a bug in Devise, or Devise's notification. The proposed workaround is inspired by Devise's documentation but checks whether a transaction is open to make the call whether to immediately send the notification or defer it to the `after_commit` hook. [1]: https://www.rubydoc.info/github/plataformatec/devise/Devise%2FModels%2FAuthenticatable:send_devise_notification [2]: `406915cb78/lib/devise/models/authenticatable.rb (L133-L194)` * Fix cases when sending notifications without changing the model * Defer sending if and only if in transaction including current record	5 years ago
ThibG	f7e011919e	Fix account aliases page (#13452 ) * Fix error not being displayed when adding an account alias, add error for self-references Co-Authored-By: Mélanie Chauvel (ariasuni) <perso@hack-libre.org> * Add “You have no aliases.” note in confusing empty aliases table Co-Authored-By: Mélanie Chauvel (ariasuni) <perso@hack-libre.org> Co-authored-by: Mélanie Chauvel (ariasuni) <perso@hack-libre.org>	5 years ago
Eugen Rochko	c9efb400b4	Add rate limit for reporting (#13390 )	5 years ago
ThibG	89e28c7674	Fix PostgreSQL load when linking in announcements (#13250 ) * Fix PostgreSQL load when linking in announcements Fixes #13245 by caching status lookups Since statuses are supposed to be known already and we only need their URLs and a few other things, caching them should be fine. Since it's only used by announcements so far, there won't be much statuses to cache. * Perform status lookup when saving announcements, not when rendering them * Change EntityCache#status to fetch URLs instead of looking into the database * Move announcement link lookup to publishing worker * Address issues pointed out during review	5 years ago
Eugen Rochko	f65568f1d4	Add ability to filter audit log in admin UI (#13381 )	5 years ago
Eugen Rochko	0c8945e5ff	Change `tootctl media remove-orphans` to work for all classes (#13316 ) Change `tootctl media lookup` to not use an interactive prompt	5 years ago
Jeong Arm	8c42e0b53c	Make bookmarks also searchable (#13271 )	5 years ago
ThibG	61f35c1a8a	Fix reported accounts not being whitelisted when resolving a spamcheck report (#13289 )	5 years ago
Eugen Rochko	bea0bb39d6	Add option to include resolved DNS records when blacklisting e-mail domains in admin UI (#13254 ) * Add shortcuts to blacklist a user's e-mail domain in admin UI * Add option to blacklist resolved MX and IP records for e-mail domains	5 years ago
Eugen Rochko	f556f79b77	Add titles to warning presets in admin UI (#13252 )	5 years ago
ThibG	2c6099125d	Fix videos with unsupported colorspace not being transcoded (#13242 )	5 years ago
ThibG	abd8394880	Fix MP4 (H264 + AAC) video files being needlessly re-encoded (#13239 )	5 years ago
Eugen Rochko	8a2b8e0321	Change video uploads to always be converted to H264/MP4 (#13220 ) Even if the container format is the same (.mp4), the codec could be different and not playable in web browsers	5 years ago
Eugen Rochko	dc15c81e67	Change video uploads to enforce certain limits (#13218 ) - Dimensions at most 1920x1200 - Frame rate at most 60	5 years ago
ThibG	b154428e14	Add federation support for the "hide network" preference (#11673 ) * Change ActivityPub follower/following collections to not link first page * Add support for hiding followers and following of remote users * Switch to using a single `hide_collections` column * Address code style remarks	5 years ago
Eugen Rochko	9660aa4543	Change local media attachments to perform heavy processing asynchronously (#13210 ) Fix #9106	5 years ago
ThibG	aa67036b41	Add support for links to statuses in announcements to be opened in web UI (#13212 ) * Add support for links to public statuses in announcements to be opened in WebUI * Please CodeClimate	5 years ago
ThibG	4a4cd686c1	Add sorting by username, creation and last activity in moderation view (#13076 ) * Add ability to order accounts in moderation view * Display last status date in “Most recent activity” for remote users	5 years ago

1 2 3 4 5 ...

1005 Commits (e3b4d3179ac7945491500935f4e3c586f2e7abbc)