1368 Commits (d9a958fcf7c01462c1235895f0bde7b35c233f45)

Author	SHA1	Message	Date
Claire	67de888bad	Fix server status URL being a required server setting (#23499)	2 years ago
Nick Schonning	0592937264	Apply Rubocop Rails/WhereNot (#23448) ... * Apply Rubocop Rails/WhereNot * Update spec for where.not	2 years ago
Nick Schonning	0d1f192c54	Apply Rubocop Performance/BlockGivenWithExplicitBlock (#23441) ... * Apply Rubocop Performance/BlockGivenWithExplicitBlock * Unprefix used block parameter	2 years ago
Nick Schonning	f68bb52556	Apply Rubocop Style/NegatedIfElseCondition (#23451)	2 years ago
Nick Schonning	8c1b65c7dd	Apply Rubocop Style/RedundantAssignment (#23452)	2 years ago
Nick Schonning	cec005068f	Apply Rubocop Performance/RedundantBlockCall (#23440)	2 years ago
Nick Schonning	ed570050c6	Autofix Rails/EagerEvaluationLogMessage (#23429) ... * Autofix Rails/EagerEvaluationLogMessage * Update spec for debug block syntax	2 years ago
Eugen Rochko	8f590b0a21	Add setting for status page URL (#23390)	2 years ago
Claire	13a2abacc8	Add `roles` attribute to Account entities in REST API (#23255)	2 years ago
Claire	6883fddb19	Fix account activation being triggered before email confirmation (#23245) ... * Add tests * Fix account activation being triggered before email confirmation Fixes #23098	2 years ago
Jeong Arm	a1abda39dd	Fix Account Strike causing PG not null validation error (#23178)	2 years ago
Claire	3970a6f433	Add option to make the landing page be /about even when trends are enabled (#20808) ... * Add option to make the landing page be /about even when trends are enabled * Restablish /explore as landing page by default	2 years ago
Claire	343e1fe8e9	Add confirmation screen when handling reports (#22375) ... * Add confirmation screen on moderation actions * Add flash notice when a report has been processed * Refactor tests * Add tests	2 years ago
Claire	d1387579b9	Fix situations in which instance actor can be set to a Mastodon-incompatible name (#22307) ... * Validate internal actor * Use “internal.actor” by default for the server actor username * Fix instance actor username on the fly if it includes ':' * Change actor name from internal.actor to mastodon.internal	2 years ago
Claire	fcc4c9b34a	Change domain block CSV parsing to be more robust and handle more lists (#21470) ... * Change domain block CSV parsing to be more robust and handle more lists * Add some tests * Improve domain block import validation and reporting	2 years ago
David Freedman	ff70e50199	Don't crash on unobtainable avatars (#22462)	2 years ago
Claire	21a1a8ee88	Fix crash when marking statuses as sensitive while some statuses are deleted (#22134) ... * Do not offer to mark statuses as sensitive if there is no undeleted status with media attachments * Fix crash when marking statuses as sensitive while some statuses are deleted Fixes #21910 * Fix multiple strikes being created for a single report when selecting “Mark as sensitive” * Add tests	2 years ago
Kaspar V	ae62e5fa53	Fix/remove calling private method with send in model (#22951) ... * fix(status): remove send usage for private unlink_from_conversations - make unlink_from_conversations public method - rename unlink_from_conversations to unlink_from_conversations! - fix send call on private method in statuses_vacuum and batched_remove_status_service * fix(feeds_vacuum): replace find_in_batches with in_batches because active record query results should be a little more efficient than itterating with map and each. Postgres can grasp such lists of ids much quicker than ruby can. Will probably make allmost no difference, but cannot hurt either.	2 years ago
Darius Kazemi	264655c53a	Fix account search not returning followed accounts first (#22956) ... * Make autosuggest for mentions return followed accounts first This makes it so that (when elasticsearch is disabled) when a user types '@foo' in the compose box, they are first going to get accounts they follow ordered by the ranking algorithm, and then second they will get accounts they do not follow, also ordered by the ranking algorithm. This makes behavior more consistent with user expectation and also with results when elasticsearch is enabled. * Fix ranking order to correct direction * One more fixup per @gargron suggestion * Tweak to ranking to no longer include following modifier	2 years ago
Claire	acec1fb745	Fix site upload validations (#22479) ... * Fix site settings media upload handling of DimensionsValidationError Fixes #22234 * Fix underlying validations not being performed for site uploads	2 years ago
Claire	3654c94583	Strip spaces around URL when adding a relay (#22655) ... * Strip spaces around URL when adding a relay Fixes #22650 * Gracefuly handle URL parsing errors in URL validator	2 years ago
Alexander Ivanov	8eb29741b4	Add webhook `account.approved` (#22938) ... * Webhook `account.approved` when preparing new user * Update Webhook.EVENTS	2 years ago
Partho Ghosh	115ab2869b	Fix ・ detection in hashtag regex to construct hashtag correctly (#22888) ... * Fix ・ detection in hashtag regex to construct hashtag correctly * Fixed rubocop liniting issues * More rubocop linting fix	2 years ago
Claire	70415714f1	Add follow request banner on account header (#20785) ... * Add requested_by to relationship maps * Display whether an account has requested to follow you on their profile	2 years ago
Claire	2644a28cb3	Change remote media files to be downloaded outside of transactions (#21796)	2 years ago
Jeong Arm	3656a6b9cc	Add "disabled" user filter for admin/accounts UI (#21282)	2 years ago
Jeong Arm	d412147d02	Save avatar or header correctly even if other one fails (#18465) ... * Save avatar or header correctly if other one fails * Fix test	2 years ago
Francis Murillo	5fb1c3e934	Revoke all authorized applications on password reset (#21325) ... * Clear sessions on password change * Rename User::clear_sessions to revoke_access for a clearer meaning * Add reset paassword controller test * Use User.find instead of User.find_for_authentication for reset password test * Use redirect and render for better test meaning in reset password Co-authored-by: Effy Elden <effy@effy.space>	2 years ago
Claire	ed07f10ca8	Fix failure when “Require a reason to join” is set with open registrations (#22127)	2 years ago
Claire	b59fb28e90	Fix 500 error when trying to migrate to an invalid address (#21462) ... * Fix 500 error when trying to migrate to an invalid address * Add tests	2 years ago
Claire	c8849d6cee	Fix unbounded recursion in account discovery (#22025) ... * Fix trying to fetch posts from other users when fetching featured posts * Rate-limit discovery of new subdomains * Put a limit on recursively discovering new accounts	2 years ago
Claire	69137f4a90	Fix irreversible and whole_word parameters handling in /api/v1/filters (#21988) ... Fixes #21965	2 years ago
Claire	57b893d505	Fix spaces not being stripped in admin account search (#21324) ... Fixes #21058 Regression from #18641	2 years ago
Kaspar V	47f0d7021e	refactor(vacuum statuses): reduce amount of db queries and load for each query - improve performance (#21487) ... * refactor(statuses_vacuum): remove dead code - unused Method is not called inside class and private. Clean up dead code. * refactor(statuses_vacuum): make retention_period present test explicit This private method only hides functionality. It is best practice to be as explicit as possible. * refactor(statuses_vacuum): improve query performance - fix statuses_scope having sub-select for Account.remote scope by `joins(:account).merge(Account.remote)` - fix statuses_scope unnecessary use of `Status.arel_table[:id].lt` because it is inexplicit, bad practice and even slower than normal `.where('statuses.id < ?'` - fix statuses_scope remove select(:id, :visibility) for having reusable active record query batches (no re queries) - fix vacuum_statuses! to use in_batches instead of find_in_batches, because in_batches delivers a full blown active record query result, in stead of an array - no requeries necessary - send(:unlink_from_conversations) not to perform another db query, but reuse the in_batches result instead. - remove now obsolete remove_from_account_conversations method - remove_from_search_index uses array of ids, instead of mapping the ids from an array - this should be more efficient - use the in_batches scope to call delete_all, instead of running another db query for this - because it is again more efficient - add TODO comment for calling models private method with send * refactor(status): simplify unlink_from_conversations - add `has_many through:` relation mentioned_accounts - use model scope local instead of method call `Status#local?` - more readable add account to inbox_owners when account.local? * refactor(status): searchable_by way less sub selects These queries all included a sub-select. Doing the same with a joins should be more efficient. Since this method does 5 such queries, this should be significant, since it technically halves the query count. This is how it was: ```ruby [3] pry(main)> Status.first.mentions.where(account: Account.local, silent: false).explain Status Load (1.6ms) SELECT "statuses".* FROM "statuses" WHERE "statuses"."deleted_at" IS NULL ORDER BY "statuses"."id" DESC LIMIT $1 [["LIMIT", 1]] Mention Load (1.5ms) SELECT "mentions".* FROM "mentions" WHERE "mentions"."status_id" = $1 AND "mentions"."account_id" IN (SELECT "accounts"."id" FROM "accounts" WHERE "accounts"."domain" IS NULL) AND "mentions"."silent" = $2 [["status_id", 109382923142288414], ["silent", false]] => EXPLAIN for: SELECT "mentions".* FROM "mentions" WHERE "mentions"."status_id" = $1 AND "mentions"."account_id" IN (SELECT "accounts"."id" FROM "accounts" WHERE "accounts"."domain" IS NULL) AND "mentions"."silent" = $2 [["status_id", 109382923142288414], ["silent", false]] QUERY PLAN ------------------------------------------------------------------------------------------------------------------ Nested Loop (cost=0.15..23.08 rows=1 width=41) -> Seq Scan on accounts (cost=0.00..10.90 rows=1 width=8) Filter: (domain IS NULL) -> Index Scan using index_mentions_on_account_id_and_status_id on mentions (cost=0.15..8.17 rows=1 width=41) Index Cond: ((account_id = accounts.id) AND (status_id = '109382923142288414'::bigint)) Filter: (NOT silent) (6 rows) ``` This is how it is with this change: ```ruby [4] pry(main)> Status.first.mentions.joins(:account).merge(Account.local).active.explain Status Load (1.7ms) SELECT "statuses".* FROM "statuses" WHERE "statuses"."deleted_at" IS NULL ORDER BY "statuses"."id" DESC LIMIT $1 [["LIMIT", 1]] Mention Load (0.7ms) SELECT "mentions".* FROM "mentions" INNER JOIN "accounts" ON "accounts"."id" = "mentions"."account_id" WHERE "mentions"."status_id" = $1 AND "accounts"."domain" IS NULL AND "mentions"."silent" = $2 [["status_id", 109382923142288414], ["silent", false]] => EXPLAIN for: SELECT "mentions".* FROM "mentions" INNER JOIN "accounts" ON "accounts"."id" = "mentions"."account_id" WHERE "mentions"."status_id" = $1 AND "accounts"."domain" IS NULL AND "mentions"."silent" = $2 [["status_id", 109382923142288414], ["silent", false]] QUERY PLAN ------------------------------------------------------------------------------------------------------------------ Nested Loop (cost=0.15..23.08 rows=1 width=41) -> Seq Scan on accounts (cost=0.00..10.90 rows=1 width=8) Filter: (domain IS NULL) -> Index Scan using index_mentions_on_account_id_and_status_id on mentions (cost=0.15..8.17 rows=1 width=41) Index Cond: ((account_id = accounts.id) AND (status_id = '109382923142288414'::bigint)) Filter: (NOT silent) (6 rows) ```	2 years ago
afontenot	f17fc5742e	Clear voter count when poll is reset (#21700) ... When a poll is edited, we reset the poll and remove all previous votes. However, prior to this commit, the voter count on the poll was not reset. This leads to incorrect percentages being shown in poll results. Fixes #21696	2 years ago
Skyler Hawthorne	5b2ff8d32d	fix media uploads with ffmpeg 5 (#21191)	2 years ago
David Leadbeater	69378eac99	Don't allow URLs that contain non-normalized paths to be verified (#20999) ... * Don't allow URLs that contain non-normalized paths to be verified This stops things like https://example.com/otheruser/../realuser where "/otheruser" appears to be the verified URL, but the actual URL being verified is "/realuser" due to the "/../". Also fix a test to use 'https', so it is testing the right thing, now that since #20304 https is required. * missing do	2 years ago
lenore gilbert	c373148b3d	Support for import/export of instance-level domain blocks/allows for 4.x w/ additional fixes (#20597) ... * Allow import/export of instance-level domain blocks/allows (#1754) * Allow import/export of instance-level domain blocks/allows. Fixes #15095 * Pacify circleci * Address simple code review feedback * Add headers to exported CSV * Extract common import/export functionality to AdminExportControllerConcern * Add additional fields to instance-blocked domain export * Address review feedback * Split instance domain block/allow import/export into separate pages/controllers * Address code review feedback * Pacify DeepSource * Work around Paperclip::HasAttachmentFile for Rails 6 * Fix deprecated API warning in export tests * Remove after_commit workaround (cherry picked from commit 94e98864e3) * Add confirmation page when importing blocked domains (#1773) * Move glitch-soc-specific strings to glitch-soc-specific locale files * Add confirmation page when importing blocked domains (cherry picked from commit b91196f4b7) * Fix authorization check in domain blocks controller (cherry picked from commit 7527937758) * Fix error strings for domain blocks and email-domain blocks Corrected issue with non-error message used for Mastodon:NotPermittedError in Domain Blocks Corrected issue Domain Blocks using the Email Domain Blocks message on ActionContoller::ParameterMissing Corrected issue with Email Domain Blocks using the not_permitted string from "custom emojii's" * Ran i18n-tasks normalize to address test failure * Removed unused admin.export_domain_blocks.not_permitted string Removing unused string as indicated by Check i18n * Fix tests (cherry picked from commit 9094c2f52c) * Fix domain block export not exporting blocks with only media rejection (cherry picked from commit 26ff48ee48) * Fix various issues with domain block import - stop using Paperclip for processing domain allow/block imports - stop leaving temporary files - better error handling - assume CSV files are UTF-8-encoded (cherry picked from commit cad824d8f501b95377e4f0a957e5a00d517a1902) Co-authored-by: Levi Bard <taktaktaktaktaktaktaktaktaktak@gmail.com> Co-authored-by: Claire <claire.github-309c@sitedethib.com>	2 years ago
Claire	00b2720ef0	Change automatic post deletion configuration to be accessible to redirected users (#20774) ... Fixes #20550	2 years ago
Claire	0cc77263fc	Change batch account suspension to create a strike (#20897)	2 years ago
Eugen Rochko	552d69ad96	Fix error when invalid domain name is submitted (#19474) ... Fix #19175	2 years ago
Eugen Rochko	b31afc6294	Fix error when passing unknown filter param in REST API (#20626) ... Fix #19156	2 years ago
Eugen Rochko	5c826c408d	Fix image type not being set after conversion for convertible image types (#20624)	2 years ago
Eugen Rochko	2e2ba39abf	Fix rules with same priority being sorted non-deterministically (#20623)	2 years ago
Jeong Arm	c4c1bee880	Fix trendable status without review (#20214)	2 years ago
Emily Strickland	96f51e593f	Guard against error extracting `body` from URL (#20428) ... If `Nokogiri::HTML(value).at_xpath('//body')` fails to find the `body` element, it will return `nil`. We can guard against that with an early return. Avoids calling `children` on `Nilclass` in those cases.	2 years ago
Eugen Rochko	9bc0a6c861	Fix metadata scrubbing removing color profile from images (#20389)	2 years ago
Claire	86f6631d28	Remove dead code and refactor status threading code (#20357) ... * Remove dead code * Remove unneeded/broken parameters and refactor descendant computation	2 years ago
Eugen Rochko	c6c7c6223d	Change verification to only work for https links (#20304) ... Fix #20242	2 years ago
Eugen Rochko	9965a23b04	Change link verification to ignore IDN domains (#20295) ... Fix #3833	2 years ago
James Tucker	78a6b871fe	Improve performance by avoiding regex construction (#20215) ... ```ruby 10.times { p /#{FOO}/.object_id } 10.times { p FOO_RE.object_id } ```	2 years ago
Eugen Rochko	0cd0786aef	Revert filtering public timelines by locale by default (#20294)	2 years ago
Eugen Rochko	e98833748e	Fix being able to spoof link verification (#20217) ... - Change verification to happen in `default` queue - Change verification worker to only be queued if there's something to do - Add `link` tags from metadata fields to page header of profiles	2 years ago
Postmodern	ca80beb653	Micro-optimization: use `if`/`else` instead of `Array#compact` and `Array#min` (#19906) ... * Technically `if`/`else` is faster than using `[value1, value2].compact.min` to find the lesser of two values, one of which may be `nil`.	2 years ago
Claire	bbf74498f5	Fix validation error in SynchronizeFeaturedTagsCollectionWorker (#20018) ... * Fix followers count not being updated when migrating follows Fixes #19900 * Fix validation error in SynchronizeFeaturedTagsCollectionWorker Also saves remote user's chosen case for hashtags * Limit remote featured tags before validation	2 years ago
Postmodern	106648b456	Micro-optimization: only split `acct` into two Strings (#19901) ... * Since `acct` is split by `@` and assigned to `username` and `domain`, we only need to split `acct` into two Strings.	2 years ago
nightpool	54f0f1b9ef	Skip Webfinger cache during migrations as well (#19883)	2 years ago
Eugen Rochko	3151b260e2	Fix not using GIN index for account search queries (#19830)	2 years ago
Claire	c2170991c7	Fix reblogs being discarded after the reblogged status (#19731)	2 years ago
Eugen Rochko	b1a219552e	Fix featured tags not saving preferred casing (#19732)	2 years ago
Claire	125322718b	Fix inaccurate admin log entry for re-sending confirmation e-mails (#19674) ... Fixes #19593	2 years ago
txt-file	0f5e6dd02b	Add support for AVIF uploads (#19647)	2 years ago
Eugen Rochko	ae07cfb868	Add support for HEIC uploads (#19618)	2 years ago
Eugen Rochko	15bae3e0e4	Change post-processing to be deferred only for large media types (#19617)	2 years ago
Eugen Rochko	d0ba77047e	Change max. thumbnail dimensions to 640x360px (360p) (#19619)	2 years ago
Eugen Rochko	26478f461c	Remove language filtering from hashtag timelines (#19563)	2 years ago
Eugen Rochko	ac9fb0d654	Add reputation and followers score boost to SQL-only account search (#19251)	2 years ago
Eugen Rochko	40c7f3e830	Fix account action type validation (#19476) ... * Fix account action type validation Fix #19143 * Fix #19145 * Fix code style issues	2 years ago
Eugen Rochko	3b024c563c	Fix not being able to input featured tag with `#` (#19535)	2 years ago
Eugen Rochko	dc5c86add7	Fix account migration form ever using outdated account data (#18429)	2 years ago
Claire	d9d722d74b	Change admin announcement edition interface to use datetime-local (#18321) ... * Change admin announcement edition interface to use datetime-local * Dynamically set announcement stop date as required if start date is set, set minimum date for stop date * Change `all_day` to not be bound to presence of time-range * Add pattern and placeholder as minimal fallback for browsers not supporting datetime-local * Display datetime-local inputs as local time Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>	2 years ago
Eugen Rochko	07cc201acc	Fix using wrong policy on status-related actions in admin UI (#19490)	2 years ago
Eugen Rochko	5f733ad83a	Remove unused method `searchable?` on accounts (#19489) ... It called the wrong methods, but nothing uses it	2 years ago
Eugen Rochko	d2eb726962	Fix notifications about deleted reports not being also deleted (#19475) ... * Fix notifications about deleted reports not being also deleted * Fix notification with empty report crashing web UI Fix #18909	2 years ago
zunda	52ebfb7792	Store integer settings as integer (#19478)	2 years ago
Eugen Rochko	f8ca3bb2a1	Add ability to view previous edits of a status in admin UI (#19462) ... * Add ability to view previous edits of a status in admin UI * Change moderator access to posts to be controlled by a separate policy	2 years ago
Eugen Rochko	487d81fb92	Fix IP blocks not having a unique index (#19456)	2 years ago
Takeshi Umeda	74ead7d106	Change featured tag updates to add/remove activity (#19409) ... * Change featured tag updates to add/remove activity * Fix to check for the existence of feature tag * Rename service and worker * Merge AddHashtagSerializer with AddSerializer * Undo removal of sidekiq_options	2 years ago
Takeshi Umeda	53e86747e4	Fix duplicate featured tags (#19403) ... * Fix duplicate featured tags * Add unique tag name validator * Fix error message	2 years ago
Takeshi Umeda	1d34eff63f	Add featured tag add/remove activity handler (#19408)	2 years ago
Eugen Rochko	7c152acb2c	Change settings area to be separated into categories in admin UI (#19407) ... And update all descriptions	2 years ago
Eugen Rochko	839f893168	Change public accounts pages to mount the web UI (#19319) ... * Change public accounts pages to mount the web UI * Fix handling of remote usernames in routes - When logged in, serve web app - When logged out, redirect to permalink - Fix `app-body` class not being set sometimes due to name conflict * Fix missing `multiColumn` prop * Fix failing test * Use `discoverable` attribute to control indexing directives * Fix `<ColumnLoading />` not using `multiColumn` * Add `noindex` to accounts in REST API * Change noindex directive to not be rendered by default before a route is mounted * Add loading indicator for detailed status in web UI * Fix missing indicator appearing while account is loading in web UI	2 years ago
Takeshi Umeda	b0e3f0312c	Add synchronization of remote featured tags (#19380) ... * Add LIMIT of featured tag to instance API response * Add featured_tags_collection_url to Account * Add synchronization of remote featured tags * Deliver update activity when updating featured tag * Remove featured_tags_collection_url * Revert "Add featured_tags_collection_url to Account" This reverts commit cff349fc27. * Add hashtag sync from featured collections * Fix tag name normalize * Add target option to fetch featured collection * Refactor fetch_featured_tags_collection_service * Add LIMIT of featured tag to v1/instance API response	2 years ago
Eugen Rochko	f01310dadb	Fix trending statuses returning more than one post by the same author (#19349)	2 years ago
Eugen Rochko	1bd00036c2	Change about page to be mounted in the web UI (#19345)	2 years ago
Eugen Rochko	b04633a961	Add image processing and generate blurhash for server thumbnail (#19348) ... Remove separate server hero setting	2 years ago
Yamagishi Kazutoshi	05148e2c77	Fix missing `skip_review?` (#19335)	2 years ago
Eugen Rochko	45ebdb72ca	Add support for language preferences for trending statuses and links (#18288)	2 years ago
Eugen Rochko	678fc4d292	Fix privacy policy being empty if custom setting exists but is empty (#19318)	2 years ago
Eugen Rochko	a2ba011326	Change privacy policy to be rendered in web UI, add REST API (#19310) ... Source string no longer localized, Markdown instead of raw HTML	2 years ago
Eugen Rochko	93f340a4bf	Remove setting that disables account deletes (#17683)	2 years ago
Eugen Rochko	9f65909f42	Change public timelines to be filtered by current locale by default (#19291) ... In the absence of an opt-in to multiple specific languages in the preferences, it makes more sense to filter by the user's presumed language only (interface language or `lang` override)	2 years ago
Eugen Rochko	02ba9cfa35	Remove code for rendering public and hashtag timelines outside the web UI (#19257)	2 years ago
Eugen Rochko	1a5150e9c3	Fix content retention policy settings not accepting a blank value (#19248)	2 years ago
Eugen Rochko	0d0f3c15d3	Fix language dropdown sometimes not appearing in web UI (#19246) ... When user has no locale preference saved (such as never changing it from the default), the preferred posting language is nil, and the dropdown is not visible	3 years ago
Eugen Rochko	5c9abdeff1	Add retention policy for cached content and media (#19232)	3 years ago
Eugen Rochko	50948b46aa	Add ability to filter followed accounts' posts by language (#19095)	3 years ago
Eugen Rochko	546672e292	Change "Allow trends without prior review" setting to include statuses (#17977) ... * Change "Allow trends without prior review" setting to include posts * Fix i18n-tasks	3 years ago
Eugen Rochko	2a7766dcc9	Add admin API for managing e-mail domain blocks (#19066)	3 years ago
Eugen Rochko	c556c3a0d1	Add admin API for managing canonical e-mail blocks (#19067)	3 years ago