Commit Graph

2302 Commits (d41b43ed4fff8ccbee5eac62064c5def14f88973)

Author SHA1 Message Date
Matt Jankowski 98ef38e34e
Ensure unique values in fabricators (#29515) 10 months ago
Eugen Rochko 50b17f7e10
Add notification policies and notification requests (#29366) 10 months ago
Claire ee8d0b9447
Fix follow suggestions potentially including silenced or blocked accounts (#29306) 10 months ago
Matt Jankowski 18945f62e0
Convert more API specs from controller->request style (#29004) 10 months ago
Daniel M Brasil a25014de8f
Improve `IpBlock` model test coverage (#29460) 10 months ago
Matt Jankowski 3389c41b58
Move `nobody` position in `UserRole` magic number to constant (#29465) 10 months ago
Matt Jankowski eb1b8f69de
Allow pagination `Link` headers on API accounts/statuses when pinned true (#29442) 10 months ago
Matt Jankowski 6675bf574a
Extract `parsed_uri_query_values` helper in ap/replies controller spec (#29410) 10 months ago
Matt Jankowski 14c65180df
Use sequence in `software_update` fabricator to allow multiple (#29438) 10 months ago
Matt Jankowski 8f3c91fc3c
Add `change` block expectation to `admin/invites#deactivate_all` spec (#29412) 10 months ago
Claire 6f7615ba86
Add basic end-to-end test for admin moderation interface (#29424) 10 months ago
Matt Jankowski 9e78129e6e
Use "cacheable response" shared example in more places (#29419) 10 months ago
Matt Jankowski 8156113d58
Use `response_vary_headers` method in requests/cache_spec (#29411) 10 months ago
Damien Mathieu 1540f42522
Better tests for auth/registrations#update (#29303) 10 months ago
Wolfgang Fournès d51c3ac087
Add a missing spec to `SessionsController#webauthn_options` (#29277) 10 months ago
Matt Jankowski b0064ddda7
Add basic coverage for `MoveService` class (#29301) 10 months ago
Matt Jankowski a6ed148769
Use heredoc on the `HTML` blocks in verify link spec (#29365) 10 months ago
Claire 9d8dfeb5fb
Fix processing of `Link` objects in `Image` objects (#29335) 10 months ago
Claire 5152dd869e
Fix link verifications when page size exceeds 1MB (#29358) 10 months ago
Claire b71904816a
Change registrations to be disabled by default for new servers (#29280) 10 months ago
Matt Jankowski e9b0f0c314
Add basic coverage for `RemoveDomainsFromFollowersService` class (#29327) 10 months ago
Matt Jankowski 7c7dfe7de3
Add basic coverage for `RemoveFeaturedTagService` class (#29328) 10 months ago
Matt Jankowski 6342ddd698
Add basic coverage for `UnfavouriteService` class (#29329) 10 months ago
Matt Jankowski f70905f127
Add basic coverage for `UnmuteService` class (#29330) 10 months ago
Matt Jankowski a69fe534e3
Add basic coverage for `WebhookService` class (#29331) 10 months ago
Matt Jankowski d1602c017d
Add basic coverage for `ApproveAppealService` class (#29333) 10 months ago
Matt Jankowski ab2ef63a03
Add basic coverage for `VoteService` class (#29334) 10 months ago
Claire 2751acb6cd
Automatically switch from open to approved registrations in absence of moderators (#29318) 10 months ago
Matt Jankowski 08342ad40c
Add basic coverage for `AfterUnallowDomainService` class (#29324) 10 months ago
Matt Jankowski 8f61e32569
Add basic coverage for `AppealService` class (#29322) 10 months ago
Matt Jankowski b73932461f
Add basic coverage for `CreateFeaturedTagService` class (#29321) 10 months ago
Matt Jankowski 5f19e7e799
Add basic coverage for `ProcessHashtagsService` class (#29320) 10 months ago
Matt Jankowski 1f648fdf1a
Remove erroneous service type on `TagFeed` model spec (#29302) 10 months ago
Matt Jankowski 64f9939e39
Use `capture_emails` helper to improve email assertions in specs (#29245) 11 months ago
Wolfgang Fournès 86627ea2e4
Add a missing thread example to the statuses spec (#29278) 11 months ago
Matt Jankowski 245064bb98
Move "everyone" role and "instance actor" account magic number IDs to constants (#29260) 11 months ago
Claire 96ddf1d482
Fix flaky end-to-end OCR test (#29244) 11 months ago
Matt Jankowski 1946e171e6
Reduce round trips in admin/disputes/appeals spec (#29234) 11 months ago
Matt Jankowski 3454fcbd71
Reduce round trips in auth/sessions spec (#29233) 11 months ago
Matt Jankowski a316c0e38d
Reduce round trips in disputes/appeals spec (#29232) 11 months ago
Matt Jankowski 117b507df5
Extract `subject` from `User#mark_email_as_confirmed!` spec (#29231) 11 months ago
Matt Jankowski 1690fb39e6
Reduce `RSpec/MultipleExpectations` in instance_actors_controller spec (#29229) 11 months ago
Matt Jankowski bba488c189
Reduce `RSpec/MultipleExpectations` in media_attachment spec (#29228) 11 months ago
Claire 9fee5e8526
Merge pull request from GHSA-jhrq-qvrm-qr36
* Fix insufficient Content-Type checking of fetched ActivityStreams objects

* Allow JSON-LD documents with multiple profiles
11 months ago
Matt Jankowski a9f9b0097b
Reduce `RSpec/MultipleExpectations` in captcha feature spec (#29226) 11 months ago
Matt Jankowski 4b7f04e3ea
Reduce `RSpec/MultipleExpectations` in post_status_service spec (#29225) 11 months ago
Matt Jankowski ed4939296a
Reduce `RSpec/MultipleExpectations` in ap/activity/create spec (#29224) 11 months ago
Matt Jankowski 1df2ffc3ee
Use `subject` in blacklist email validator spec (#29211) 11 months ago
Matt Jankowski fc4f823464
Avoid local block var assignment in ap/process_status_update_service spec (#29210) 11 months ago
Claire d4d0565b0f
Fix user creation failure handling in OAuth paths (#29207) 11 months ago
Claire bbbbf00084
Fix OmniAuth tests (#29201) 11 months ago
Claire b31af34c97
Merge pull request from GHSA-vm39-j3vx-pch3
* Prevent different identities from a same SSO provider from accessing a same account

* Lock auth provider changes behind `ALLOW_UNSAFE_AUTH_PROVIDER_REATTACH=true`

* Rename methods to avoid confusion between OAuth and OmniAuth
11 months ago
Emelia Smith 68eaa804c9
Merge pull request from GHSA-7w3c-p9j8-mq3x
* Ensure destruction of OAuth Applications notifies streaming

Due to doorkeeper using a dependent: delete_all relationship, the destroy of an OAuth Application bypassed the existing AccessTokenExtension callbacks for announcing destructing of access tokens.

* Ensure password resets revoke access to Streaming API

* Improve performance of deleting OAuth tokens

---------

Co-authored-by: Claire <claire.github-309c@sitedethib.com>
11 months ago
Emelia Smith 46142cdbdd
Disable administrative doorkeeper routes (#29187) 11 months ago
Claire ca8fbda5d0
Add end-to-end test for OCR in media uploads (#29148) 11 months ago
Matt Jankowski a9e91eb955
Add common stub setup for resolv dns in email mx validator spec (#29140) 11 months ago
Matt Jankowski 15437e4ad9
Add `context` and `before` to lengthy tag manager spec examples (#29129) 11 months ago
Matt Jankowski 5271131658
Extract helper method for repeated form fill in admin/domain_blocks feature spec (#29128) 11 months ago
Claire eff447a455
Rewrite signature verification using regexps and `StringScanner` (#29133) 11 months ago
Matt Jankowski 95da28d201
Add common `ThreadingHelper` module for specs (#29116) 11 months ago
Claire 7efc33b909
Move HTTP Signature parsing code to its own class (#28932) 11 months ago
Matt Jankowski da50217b88
Combine repeated requests in `admin/accounts` controller spec (#29119) 11 months ago
Claire 7ee93b7431
Change `source` attribute of `Suggestion` entity in `/api/v2/suggestions` back to a string (#29108) 11 months ago
Matt Jankowski 0df86d77fd
Reduce `RSpec/ExampleLength` in PostStatusService spec example (#29105) 11 months ago
Matt Jankowski 2d6ab44556
Reduce request/response round-trips in ap/collections controller spec (#29102) 11 months ago
Matt Jankowski 978fdc71ca
Reduce expectation count in example from `ProcessAccountService` spec (#29100) 11 months ago
Matt Jankowski 577520b637
Replace deprecated `Sidekiq::Testing` block style (#29097) 11 months ago
Matt Jankowski df7acdcee5
Update markers API spec for error case (#29096) 11 months ago
Emelia Smith 4fb7f611de
Return domain block digests from admin domain blocks API (#29092) 11 months ago
Matt Jankowski 4cf07ed78c
Add missing action logging to `api/v1/admin/reports#update` (#29044) 11 months ago
Claire 66dda7c762
Fix already-invalid reports failing to resolve (#29027) 11 months ago
Claire 1726085db5
Merge pull request from GHSA-3fjr-858r-92rw
* Fix insufficient origin validation

* Bump version to 4.3.0-alpha.1
11 months ago
Matt Jankowski 8b7b0ee598
Configure selenium to use Chrome version 120 (#29038) 11 months ago
Matt Jankowski 86fbde7b46
Fix `Style/NumericLiterals` cop in ProfileStories support module (#28971) 11 months ago
Matt Jankowski f91acba70a
Combine repeated requests in account controller concern spec (#28957) 11 months ago
Matt Jankowski ff8937aa2c
Move `api/v1/statuses/*` to request spec (#28954) 11 months ago
Matt Jankowski 44f6d285af
Combine repeated subject in ap fetch remote actor service spec (#28953) 11 months ago
Matt Jankowski 239244e2ed
Combine repeated subject in ap fetch remote account service spec (#28952) 11 months ago
Matt Jankowski 5119fbc9b7
Move `api/v1/admin/trends/links/preview_card_providers` to request spec (#28951) 11 months ago
Matt Jankowski b6baab447d
Move `api/v2/admin/accounts` to request spec (#28950) 11 months ago
Matt Jankowski 7adcc0aae3
Move `api/v1/trends/*` to request specs (#28949) 11 months ago
Matt Jankowski 0b0ca6f3b8
Move `api/v1/timelines/list` to request spec (#28948) 11 months ago
Matt Jankowski e519f113e8
Combine repeated subject in `cacheable response` shared example (#28945) 11 months ago
Matt Jankowski d791bca11b
Combine double subject in `well_known/webfinger` shared example (#28944) 11 months ago
Matt Jankowski 09a3493fca
Combine double subject in `api/v1/media` shared example (#28943) 11 months ago
Matt Jankowski 5fbdb2055b
Combine repeated `subject` in `cli/accounts` spec shared example (#28942) 11 months ago
Matt Jankowski 1a30a517d6
Combine repeated subjects in link details extractor spec (#28941) 11 months ago
Matt Jankowski 685eaa04d4
Combine double subject in admin/statuses controller shared example (#28940) 11 months ago
Matt Jankowski beb74fd71c
Combine double subjects in instance actors controller shared example (#28939) 11 months ago
Matt Jankowski beaef4b672
Combine double subjects in application controller shared example (#28938) 11 months ago
Matt Jankowski 6d35a77c92
Combine repeated subjects in `models/user` spec (#28937) 11 months ago
Matt Jankowski 2f8656334d
Combine double subjects in `admin/accounts` controller spec (#28936) 11 months ago
Matt Jankowski 9cc1817bb4
Fix intmermittent failure in `api/v1/accounts/statuses` controller spec (#28931) 11 months ago
Matt Jankowski 0e0a94f483
Handle CLI failure exit status at the top-level script (#28322) 11 months ago
Eugen Rochko 6936e5aa69
Change design of compose form in web UI (#28119)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
11 months ago
Matt Jankowski 42ab855b23
Add specs for `Instance` model scopes and add `with_domain_follows` scope (#28767) 11 months ago
Matt Jankowski 2866106ec1
Reduce factory creation in `spec/models/account_statuses_cleanup_policy` (#28361) 11 months ago
Matt Jankowski 6b6586f5d0
Add `CustomFilterKeyword#to_regex` method (#28893) 11 months ago
Matt Jankowski 7c9c6c7f80
Fix remaining `Rails/WhereExists` cop violations, regenerate todo (#28892) 11 months ago
Claire 087415d0fe
Add tests for processing statuses using bearcap URIs (#28904) 11 months ago
Claire 0471a78055
Add tests for redirect confirmations (#28903) 11 months ago
Matt Jankowski a11a2fb052
Add error classes to api/base errors coverage (#28864) 11 months ago
Matt Jankowski b0207d7757
Add coverage for `Tag.recently_used` scope (#28850) 11 months ago
Claire e2d9635074
Add notification email on invalid second authenticator (#28822) 11 months ago
Matt Jankowski 18004bf227
Add `Account.matches_uri_prefix` scope and use in activitypub/followers_synchronizations controller (#28820) 11 months ago
Matt Jankowski 7ecf7f5403
Move controller->request specs for api/v1/statuses/* (#28818) 11 months ago
Claire cf2a2ed71c
Fix processing of compacted single-item JSON-LD collections (#28816) 12 months ago
Claire 3593ee2e36
Add rate-limit of TOTP authentication attempts at controller level (#28801) 12 months ago
Matt Jankowski 329911b0a3
Migrate controller->request spec for api/v1/follow* (#28811) 12 months ago
Matt Jankowski 1480573c83
Add `Account.auditable` scope, fix N+1 in admin/action_logs#index (#28812) 12 months ago
Matt Jankowski d0b3bc23d7
Remove unused `matches_domain` scopes on Account, DomainAllow, DomainBlock (#28803) 12 months ago
Matt Jankowski 0b853678a4
Add coverage for `api/v1/peers/search` endpoint and extract controller query to Instance scope (#28796) 12 months ago
Matt Jankowski 3d82040b26
Reduced repeated setup in `UnallowDomainService` spec (#28785) 12 months ago
Matt Jankowski 6c5a2d51bc
Reduced repeated setup in `PurgeDomainService` spec (#28786) 12 months ago
Matt Jankowski 07e10e3747
Combine assertions about same setup in `Account#suspend!` spec (#28787) 12 months ago
Matt Jankowski 9a475ea8b3
Finish up the CLI spec area pattern adoption for `CLI::Accounts#refresh` specs (#28764) 12 months ago
Matt Jankowski 1b0cb3b54d
Announcement reactions query spec improvement and refactor (#28768) 12 months ago
Matt Jankowski b4c332104a
Use top-level `warn` in JS errors check (#28745) 12 months ago
Claire 98b5f85f10
Rename and refactor `User#confirm!` to `User#mark_email_as_confirmed!` (#28735) 12 months ago
Claire e621c1c44c
Fix registrations not checking MX records for email domain blocks requiring approval (#28608) 12 months ago
Matt Jankowski a2f02a0775
Disable `Rails/SkipsModelValidations` cop (#28712) 12 months ago
Matt Jankowski e72676e83a
Improve `api/v1/markers#create` performance against simultaneous requests (#28718) 12 months ago
MitarashiDango 2c05b8a60d
Fix Undo Announce activity is not sent, when not followed by the reblogged post author (#18482)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
12 months ago
Matt Jankowski a90696011e
Add coverage/bugfix for invalid appeal submission (#28703) 12 months ago
Matt Jankowski 7801db7ba4
Spec coverage for custom css endpoint (#28706) 12 months ago
Matt Jankowski df9e220364
Add JS console errors check (#28682) 12 months ago
Matt Jankowski cd37048439
Move followable_by coverage to suggestions (#28697) 12 months ago
Matt Jankowski 32eeca9c7b
Refresh instance counts in spec (fixes intermittent failure) (#28698) 12 months ago
Matt Jankowski 8b26614fa7
Combine results include check in spec/models/account (#28471) 12 months ago
Matt Jankowski 185c806d69
Extract spec helper for verifing to/from public AP collection namespace (#28472) 12 months ago
Matt Jankowski 2954279e9c
Remove double subject call in `api/v1/admin/trends/links/links` spec (#28695) 12 months ago
Matt Jankowski 95bd46d32a
Remove double subject call in `api/v1/admin/ip_blocks` spec (#28696) 12 months ago
Matt Jankowski 4e08a4892f
Move streaming `around` config into manager class (#28684) 12 months ago
Matt Jankowski 87097a227c
Clean up `settings/featured_tags/index` view (#28688) 12 months ago
Matt Jankowski 55802242ce
Refactor login activity partial (remove inline ruby) (#28687) 12 months ago
Matt Jankowski 0a7cff53c2
Add coverage for `Account.followable_by` scope (#28689) 12 months ago
Claire d7e13e2483
Fix potential redirection loop of streaming endpoint (#28665) 12 months ago
Matt Jankowski 8422b8ded0
Extract capybara config and improve headless_chrome driver config (#28681) 12 months ago
Matt Jankowski 543d7890fd
Use normalizes to prepare `User` values (#28650)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
12 months ago
Matt Jankowski 00341c70ff
Use Sidekiq `fake!` instead of `inline!` in specs (#25369) 12 months ago
Matt Jankowski 742d8d30e2
Add coverage for `--days` option to CLI `media refresh` command (#28669) 12 months ago
Renaud Chaput 63d0b52cf3
Add a system spec for the `/share` endpoint (#28672) 12 months ago
Claire 10203bd57a
Clean up `Setting` model and remove dead code (#28661) 12 months ago
Jean Boussier 1781849884
Inline what remains of the rails-settings-cached gem (#28618)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
12 months ago
Matt Jankowski 5dc634796a
Misc coverage improvements re: sidekiq/inline (#28651) 12 months ago
Matt Jankowski e677eb164c
Remove unused `Announcement#time_range?` (#28648) 12 months ago
Matt Jankowski 3e43cd095c
Remove unused scope `Announcement.without_muted` (#28645) 12 months ago
Claire 157fc69954
Make request_pool_spec tests more robust (#28610) 12 months ago
Matt Jankowski aa6d07dbd9
Use normalizes to prepare CustomEmoji `domain` value (#28624) 12 months ago
Matt Jankowski 832b92ac3e
Add attachment check to spec/service/suspend_account_service spec (#28619) 12 months ago
Matt Jankowski 12bed81187
Add validation specs to `CustomFilter` model (#28600) 1 year ago
Claire 6ad0fb5a77
Fix NULL MX handling and tighten DNS resolving specs (#28607) 1 year ago
Claire 5f4643b895
Add `PAPERCLIP_ROOT_URL` to Content-Security-Policy when used (#28561) 1 year ago
Matt Jankowski 964a0ecf37
Add sleep statement to nudge thread scheduler in request pool spec (#28596) 1 year ago
Matt Jankowski f06c1f1552
Fix `Capybara/ClickLinkOrButtonStyle` cop in spec/features (#28576) 1 year ago
Claire dfdadb92e8
Add ability to require approval when users sign up using specific email domains (#28468) 1 year ago
Matt Jankowski f92d8c654d
Standardize on Thor methods in CLI classes (#28566) 1 year ago
Matt Jankowski 5c769de096
Add spec coverage for `CLI::Media#remove_orphans` command (#28267) 1 year ago
Matt Jankowski 74a0d81e90
Add coverage for CLI `self-destruct` command (#28565)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
1 year ago
Claire 092bb8a27a
Fix Mastodon not correctly processing HTTP Signatures with query strings (#28476) 1 year ago
Claire bd415af9a1
Change streaming API host to not be overridden to localhost in development mode (#28557) 1 year ago
Claire a2624ff739
Convert signature verification specs to request specs (#28443) 1 year ago
Matt Jankowski bb8077e784
Fix `RSpec/LetSetup` cop in models/account_status_cleanup_policy (#28470) 1 year ago
Claire 2bf84b93d4
Fix media attachment order of remote posts (#28469) 1 year ago
Matt Jankowski a4d49c236d
Fix `RSpec/LetSetup` cop in ap/fetch_featured_collection_service (#28461) 1 year ago
Matt Jankowski e6e217fedd
Clean up `tagged_with_*` Status specs, fix `RSpec/LetSetup` cop (#28462) 1 year ago
Matt Jankowski 513d35969e
Fix `RSpec/LetSetup` cop in auth controller specs (#28464) 1 year ago
Matt Jankowski 9251779d75
Fix `RSpec/LetSetup` cop in spec/services (#28459) 1 year ago
Matt Jankowski efd16f3c2c
Clean up of `RSpec/LetSetup` within `spec/services/activitypub` (#28445) 1 year ago
Matt Jankowski c99f88e1a8
Clean up of `RSpec/LetSetup` within `spec/lib` (#28447) 1 year ago
Matt Jankowski cd64a5b2ec
Clean up of `RSpec/LetSetup` within `api/` (#28448) 1 year ago
Matt Jankowski f32d672d2f
Clean up of `RSpec/LetSetup` within `spec/controllers` (#28446) 1 year ago
Matt Jankowski c753b1ad35
Clean up of `RSpec/LetSetup` within `spec/models` (#28444) 1 year ago
Matt Jankowski 2463b53363
More duplicates in cli maintenance spec, misc bug fixes (#28449) 1 year ago
Matt Jankowski 961d65aba6
Add coverage to CLI Maintenance for duplicate users on `confirmation_token` and `reset_password_token` values (#28434) 1 year ago
Claire 6fed0fcbaa
Remove unneeded settings cleanup from specs (#28425) 1 year ago
Matt Jankowski c7c727994a
Add spec for `CLI::Maintenance#fix_duplicates` (#28326) 1 year ago
Eugen Rochko b5ac61b2c5
Change algorithm of follow recommendations (#28314)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
1 year ago
Matt Jankowski c28976d89e
Handle negative offset param in `api/v2/search` (#28282) 1 year ago
Matt Jankowski 476d1237d4
Typo fix in json ld helper spec (#28417) 1 year ago
Claire 7d9b209fe8
Fix call to inefficient `delete_matched` cache method in domain blocks (#28374) 1 year ago
Matt Jankowski af366f65ee
Add spec coverage for `models/form/custom_emoji_batch` class (#28388) 1 year ago
Matt Jankowski 1820bad646
Fix `Performance/StringIdentifierArgument` cop (#28399) 1 year ago
Matt Jankowski b1dec09d20
Fix `Style/InverseMethods` cop (#28377) 1 year ago
Matt Jankowski db897eaa5a
Unwind `map` on single-item array in `spec/services/delete_account_service` spec (#28358) 1 year ago
Matt Jankowski ef9797a395
Un-nest contexts in `settings/2fa/webauthn` spec (#28359) 1 year ago
Matt Jankowski adbfd40a1b
Convert `api/v1/directories` controller spec to request spec (#28356) 1 year ago
Matt Jankowski 28e1a7a394
Improve spec coverage for `models/announcement` class (#28350) 1 year ago
Matt Jankowski 8a3d8c6c14
Remove the `stub_stdout` wrapper around CLI specs (#28340) 1 year ago
Claire 89a496b42f
Fix status edits not always being streamed to mentioned users (#28324) 1 year ago
Matt Jankowski b5a1013ae3
Combine `CLI::...` spec example subjects (#28285) 1 year ago
Matt Jankowski 0e4233de9d
Controller spec to request spec: `api/v2/suggestions` (#28297) 1 year ago
Matt Jankowski 0c64092500
Controller spec to request spec: `api/v1/accounts/search` (#28299) 1 year ago
Matt Jankowski 16ede59d0a
Controller spec to request spec: `api/v1/featured_tags/suggestions` (#28298) 1 year ago
Matt Jankowski 809506bdd4
Controller spec to request spec: `api/v1/accounts/pins` (#28300) 1 year ago
Matt Jankowski 94cc707ab3
Controller spec to request spec: `api/v1/accounts/notes` (#28301) 1 year ago
Matt Jankowski e544b6df42
Controller spec to request spec: `api/v1/accounts/lookup` (#28302) 1 year ago
Matt Jankowski a968898dc7
Controller spec to request spec: `api/v1/accounts/lists` (#28303) 1 year ago
Matt Jankowski 8f94502e7d
Controller spec to request spec: `api/v1/accounts/identify_proofs` (#28304) 1 year ago
Matt Jankowski 78347d2556
Controller spec to request spec: `api/v1/accounts/familiar_followers` (#28305) 1 year ago