350 Commits (d1ecc323e7d435d0ffb11056a53b52d3345868f0)

Author	SHA1	Message	Date
Eugen Rochko	4b766f9846	Refactor monkey-patching of Goldfinger (#12561)	5 years ago
ThibG	34756cc4e0	Fix "tootctl media remove-orphans" crashing on “Import” files (#13685) ... * Fix "tootctl media remove-orphans" crashing on “Import” files * Also remove empty directories when removing orphaned media	5 years ago
ThibG	e1629a7758	Remove 'unsafe-inline' from Content-Security-Policy style-src (#13679) ... * Make sure wicg-inert doesn't rely on inline CSS * Remove unsafe-inline from style-src	5 years ago
ThibG	dea5db0e25	Fix PgHero Content-Security-Policy when CDN_HOST is used (#13595)	5 years ago
mayaeh	acc367fd14	Fix naming issue (#13551)	5 years ago
Eugen Rochko	c3ca3801f2	Add separate cache directory for non-local uploads (#12821)	5 years ago
Eugen Rochko	d18d6c29f3	Fix search not working due to proxy settings when using hidden services (#13488) ... Fix #13484	5 years ago
Eugen Rochko	f65568f1d4	Add ability to filter audit log in admin UI (#13381)	5 years ago
Eugen Rochko	9014367bd8	Fix background jobs not using locks like they are supposed to (#13361) ... Also: - Fix locks not being removed when jobs go to the dead job queue - Add UI for managing locks to the Sidekiq dashboard - Remove unused Sidekiq workers Fix #13349	5 years ago
Eugen Rochko	9241cbf861	Fix re-sending of e-mail confirmation not being rate limited (#13360) ... Fix #13330	5 years ago
ThibG	7ddbbdea6d	Fix OCR not working on Safari because of unsupported worker-src CSP (#13323) ... Fixes #13321	5 years ago
dependabot-preview[bot]	56531d646e	Bump sidekiq from 5.2.7 to 6.0.4 (#11727) ... * Bump sidekiq from 5.2.7 to 6.0.0 Bumps [sidekiq](https://github.com/mperham/sidekiq) from 5.2.7 to 6.0.0. - [Release notes](https://github.com/mperham/sidekiq/releases) - [Changelog](https://github.com/mperham/sidekiq/blob/master/Changes.md) - [Commits](https://github.com/mperham/sidekiq/compare/v5.2.7...v6.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Sidekiq::Logger.logger -> Sidekiq.logger * Drop support Ruby 2.4 * update Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh>	5 years ago
Eugen Rochko	339ce1c4e9	Add specific rate limits for posting and following (#13172)	5 years ago
Eugen Rochko	f52c988e12	Add announcements (#12662) ... * Add announcements Fix #11006 * Add reactions to announcements * Add admin UI for announcements * Add unit tests * Fix issues - Add `with_dismissed` param to announcements API - Fix end date not being formatted when time range is given - Fix announcement delete causing reactions to send streaming updates - Fix announcements container growing too wide and mascot too small - Fix `all_day` being settable when no time range is given - Change text "Update" to "Announcement" * Fix scheduler unpublishing announcements before they are due * Fix filter params not being passed to announcements filter	5 years ago
ThibG	a8e46cf7a1	Add support for magnet: URIs (#12905)	5 years ago
ThibG	ea436b355b	Add support for linking XMPP URIs in toots (#12709) ... * Fix wrong grouping in Twitter valid_url regex * Add support for xmpp URIs Fixes #9776 The difficult part is autolinking, because Twitter-text's extractor does some pretty ad-hoc stuff to find things that “look like” URLs, and XMPP URIs do not really match the assumptions of that lib, so it doesn't sound wise to try to shoehorn it into the existing regex. This is why I used a specific regex (very close, although slightly more permissive than the RFC), and a specific scan function (a simplified version of the generalized one from Twitter). * Remove leading “xmpp:” from auto-linked text	5 years ago
Eugen Rochko	49b2f7c0a2	Fix base64-encoded file uploads not being possible (#12748) ... Fix #3804, Fix #5776	5 years ago
Eugen Rochko	59c697a30c	Fix resource_owner_from_credentials in Doorkeeper initializer (#12743) ... - Nil error when e-mail not found - LDAP authentication used in place of PAM authentication	5 years ago
Eugen Rochko	09d54d1f62	Fix uncaught query param encoding errors (#12741)	5 years ago
Eugen Rochko	17159625b3	Add `S3_OVERRIDE_PATH_STYLE` environment variable (#12594) ... To support Exoscale	5 years ago
Eugen Rochko	f3d232381d	Add `tootctl media remove-orphans` (#12568)	5 years ago
tateisu	f1ef777d40	add S3_OPEN_TIMEOUT environment variable (#12459)	5 years ago
Mathieu Brunot	bd8dc9bd0c	✨ Add an LDAP Mail attribute config (#12053) ... Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>	5 years ago
Mathieu Brunot	d70268f099	✨ Convert LDAP username (#12461) ... * ✨ Convert LDAP username #12021 Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io> * 🐛 Fix conversion var use Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io> * 🐛 Fix LDAP uid conversion test Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io> * 👌 Remove comments with ref to PR Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io> * 👌 Remove unnecessary paranthesis Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io> * 🔧 Move space in conversion string Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>	5 years ago
ntl-purism	f3a93987b6	LDAP & PAM added to OAuth password grant strategy (#7999) (#12390) ... When authenticating via OAuth, the resource owner password grant strategy is allowed by Mastodon, but (without this PR), it does not attempt to authenticate against LDAP or PAM. As a result, LDAP or PAM authenticated users cannot sign in to Mastodon with their email/password credentials via OAuth (for instance, for native/mobile app users). This PR fleshes out the authentication strategy supplied to doorkeeper in its initializer by looking up the user with LDAP and/or PAM when devise is configured to use LDAP/PAM backends. It attempts to follow the same logic as the Auth::SessionsController for handling email/password credentials. Note #1: Since this pull request affects an initializer, it's unclear how to add test automation. Note #2: The PAM authentication path has not been manually tested. It was added for completeness sake, and it is hoped that it can be manually tested before merging.	5 years ago
ThibG	dfea7368c9	Add bookmarks (#7107) ... * Add backend support for bookmarks Bookmarks behave like favourites, except they aren't shared with other users and do not have an associated counter. * Add spec for bookmark endpoints * Add front-end support for bookmarks * Introduce OAuth scopes for bookmarks * Add bookmarks to archive takeout * Fix migration * Coding style fixes * Fix rebase issue * Update bookmarked_statuses to latest UI changes * Update bookmark actions to properly reflect status changes in state * Add bookmarks item to single-column layout * Make active bookmarks red	5 years ago
Eugen Rochko	45eccaf8c5	Fix preloaded JSON-LD context for identity not being used (#12138) ... Regression from #11316	5 years ago
Eugen Rochko	354fdd317e	Fix attachment not being re-downloaded even if file is not stored (#12125) ... Change the behaviour of remotable concern. Previously, it would skip downloading an attachment if the stored remote URL is identical to the new one. Now it would not be skipped if the attachment is not actually currently stored by Paperclip.	5 years ago
Eugen Rochko	086fc7ed77	Fix S3 adapter retrying failing uploads with exponential backoff (#12085) ... The default limit of 10 retries with exponential backoff meant that if the S3 server was timing out, you would be stuck with it for much, much longer than the 5 second read timeout we expect. The uploading happens within a database transaction, which means a failing S3 server could negatively affect database performance	5 years ago
Eugen Rochko	5c42f47617	Fix records not being indexed sometimes (#12024) ... It's possible that after commit callbacks were not firing when exceptions occurred in the process. Also, the default Sidekiq strategy does not push indexing jobs immediately, which is not necessary and could be part of the issue too.	5 years ago
Eugen Rochko	5f69eb89e2	Add a nodeinfo endpoint (#12002) ... * Add nodeinfo endpoint * dont commit stuff from my local dev * consistant naming since we implimented 2.1 schema * Add some additional node info stuff * Add nodeinfo endpoint * dont commit stuff from my local dev * consistant naming since we implimented 2.1 schema * expanding this to include federation info * codeclimate feedback * CC feedback * using activeserializers seems like a good idea... * get rid of draft 2.1 version * Reimplement 2.1, also fix metaData -> metadata * Fix metaData -> metadata here too * Fix nodeinfo 2.1 tests * Implement cache for monthly user aggregate * Useless * Remove ostatus from the list of supported protocols * Fix nodeinfo's open_registration reading obsolete setting variable * Only serialize domain blocks with user-facing limitations * Do not needlessly list noop severity in nodeinfo * Only serialize domain blocks info in nodeinfo when they are set to be displayed to everyone * Enable caching for nodeinfo endpoints * Fix rendering nodeinfo * CodeClimate fixes * Please CodeClimate * Change InstancePresenter#active_user_count_months for clarity * Refactor NodeInfoSerializer#metadata * Remove nodeinfo 2.1 support as the schema doesn't exist * Clean-up	5 years ago
Yamagishi Kazutoshi	a5c558f052	Hide error message on /heath (#11947) ... * Hide error message on /heath * update health_check	5 years ago
Yamagishi Kazutoshi	b02169f124	Cast multipart threshold to integer (#11944)	5 years ago
Eugen Rochko	a1f04c1e34	Fix authentication before 2FA challenge (#11943) ... Regression from #11831	5 years ago
Yamagishi Kazutoshi	172eaeba3f	Add config of multipart threshold for S3 (#11924)	5 years ago
Eugen Rochko	c707ef49d9	Fix 2FA challenge and password challenge for non-database users (#11831) ... * Fix 2FA challenge not appearing for non-database users Fix #11685 * Fix account deletion not working when using external login Fix #11691	5 years ago
Yamagishi Kazutoshi	4e1b742cb2	Change rate limit for media proxy (#11814)	5 years ago
Yamagishi Kazutoshi	d7268befa8	Add healthcheck endpoint for web (#11770)	5 years ago
ThibG	692c5b439a	Fix ActivityPub context not being dynamically computed (#11746) ... * Fix contexts not being dynamically included Fixes #11649 * Refactor Note context in serializer * Refactor Actor serializer	5 years ago
ThibG	8203e24cf4	Fix CSP needlessly allowing blob URLs in script-src (#11620)	6 years ago
Eugen Rochko	b7f5f0ec10	Fix media host not being included in connect-src for OCR (#11577)	6 years ago
Eugen Rochko	28636f43e4	Add OCR tool to media editing modal (#11566)	6 years ago
Eugen Rochko	24552b5160	Add whitelist mode (#11291)	6 years ago
Eugen Rochko	3bc0c4a884	Remove unused StatsD code and expose StatsD as a global variable (#11232) ... The instrumentation code was used for StatsD metrics collection prior to the switch to the nsa gem and should have been removed at that point as it no longer does anything at all	6 years ago
Eugen Rochko	7696f77245	Add moderation API (#9387) ... Fix #8580 Fix #7143	6 years ago
Eugen Rochko	1db4117030	Change preferences page into appearance, notifications, and other (#10977)	6 years ago
Hinaloe	b793722d7d	Fix undefined method error (#10868)	6 years ago
mayaeh	afb17b7045	Fix undefined method error. (#10867)	6 years ago
ThibG	0e9b8be18a	Improve rate limiting (#10860) ... * Rate limit based on remote address IP, not on potential reverse proxy * Limit rate of unauthenticated API requests further * Rate-limit paging requests to one every 3 seconds	6 years ago
dependabot[bot]	ecbea2e3c6	Bump rack-attack from 5.4.2 to 6.0.0 (#10599) ... * Bump rack-attack from 5.4.2 to 6.0.0 Bumps [rack-attack](https://github.com/kickstarter/rack-attack) from 5.4.2 to 6.0.0. - [Release notes](https://github.com/kickstarter/rack-attack/releases) - [Changelog](https://github.com/kickstarter/rack-attack/blob/master/CHANGELOG.md) - [Commits](https://github.com/kickstarter/rack-attack/compare/v5.4.2...v6.0.0) Signed-off-by: dependabot[bot] <support@dependabot.com> * fix payload[:request]	6 years ago
Eugen Rochko	8a0d677cde	Fix stoplight logging to stderr separate from Rails logger (#10624)	6 years ago
Eugen Rochko	0e8819f0e8	Add rate limit for media proxy requests (#10490) ... 30 per 30 minutes, like media uploads	6 years ago
Eugen Rochko	11fe293e1b	Remove unused ActivityPub `@context` values depending on response (#10378) ... Fix #8078	6 years ago
Eric	7169928f96	cas_options :validate_url should be :service_validate_url (#10328) ... Otherwise, no matter what is given for CAS_VALIDATE_URL the default /serviceValidate path would be used.	6 years ago
Eugen Rochko	99fa1ce93d	Add tight rate-limit for API deletions (#10042) ... Deletions take a lot of resources to execute and cause a lot of federation traffic, so it makes sense to decrease the number someone can queue up through the API. 30 per 30 minutes	6 years ago
Eugen Rochko	016ad37bc8	Fix URL linkifier grabbing full-width spaces and quotations (#9997) ... Fix #9993 Fix #5654	6 years ago
Eugen Rochko	4699cf853c	Add timeouts for S3 (#9842)	6 years ago
Moritz Heiber	ecf40d09ed	Disable Same-Site cookie implementation to fix SSO issues on WebKit browsers (#9819)	6 years ago
Nolan Lawson	f05eb67081	Enable immutable caching for S3 objects (#9722) ... I also added "public" here, as I can't think of a good reason not to add it. Perhaps it has some marginal benefit in that ISPs (or other proxies) can cache it for all users. The assets are certainly publicly available and the same for all users.	6 years ago
Eugen Rochko	5d2fc6de32	Add REST API for creating an account (#9572) ... * Add REST API for creating an account The method is available to apps with a token obtained via the client credentials grant. It creates a user and account records, as well as an access token for the app that initiated the request. The user is unconfirmed, and an e-mail is sent as usual. The method returns the access token, which the app should save for later. The REST API is not available to users with unconfirmed accounts, so the app must be smart to wait for the user to click a link in their e-mail inbox. The method is rate-limited by IP to 5 requests per 30 minutes. * Redirect users back to app from confirmation if they were created with an app * Add tests * Return 403 on the method if registrations are not open * Require agreement param to be true in the API when creating an account	6 years ago
Eugen Rochko	240c122767	Skip mailer job retries when a record no longer exists (#9590) ... Fix #8666	6 years ago
ThibG	3f12c07ff5	Use same CORS policy for /@:username and /users/:username (#9485) ... Fixes #8189 rack-cors being called before the application router, it does not follow the redirection, and we need a separate rule for /users/:username.	6 years ago
ThibG	84e5ed43e7	Preload common JSON-LD contexts (#9412) ... Fixes #9411	6 years ago
Ben Lubar	13e049d772	Allow cross-origin requests to /.well-known/* URLs. (#9083) ... Right now, this includes three endpoints: host-meta, webfinger, and change-password. host-meta and webfinger are publicly available and do not use any authentication. Nothing bad can be done by accessing them in a user's browser. change-password being CORS-enabled will only reveal the URL it redirects to (which is /auth/edit) but not anything about the actual /auth/edit page, because it does not have CORS enabled. The documentation for hosting an instance on a different domain should also be updated to point out that Access-Control-Allow-Origin: * should be set at a minimum for the /.well-known/host-meta redirect to allow browser-based non-proxied instance discovery.	6 years ago
Eugen Rochko	a38a452481	Add unread indicator to conversations (#9009)	6 years ago
ThibG	8ab081ec32	Add manifest_src to CSP, add blob to connect_src (#8967)	6 years ago
Eugen Rochko	edc7f895be	Fix CSP headers blocking media and development environment (#8962) ... Regression from #8957	6 years ago
ThibG	2d27c11061	Set Content-Security-Policy rules through RoR's config (#8957) ... * Set CSP rules in RoR's configuration * Override CSP setting in the embed controller to allow frames	6 years ago
Sascha	b2a57a5d6f	add ffmpeg initializer (#8855) ... * add ffmpeg initializer * use different expression to check for environment var	6 years ago
ashleyhull-versent	f194857ac9	rubocop issues - Cleaning up (#8912) ... * cleanup pass * undo mistakes * fixed. * revert	6 years ago
aus-social	0a4739c732	lint pass 2 (#8878) ... * Code quality pass * Typofix * Update applications_controller_spec.rb * Update applications_controller_spec.rb	6 years ago
aus-social	1f98eae1cf	Lint pass (#8876)	6 years ago
Yamagishi Kazutoshi	65f04e6046	Fix that Rails.cache information could not be sent via StatsD (#8831)	6 years ago
Eugen Rochko	f4d549d300	Redesign forms, verify link ownership with rel="me" (#8703) ... * Verify link ownership with rel="me" * Add explanation about verification to UI * Perform link verifications * Add click-to-copy widget for verification HTML * Redesign edit profile page * Redesign forms * Improve responsive design of settings pages * Restore landing page sign-up form * Fix typo * Support <link> tags, add spec * Fix links not being verified on first discovery and passive updates	6 years ago
luzpaz	40dd19be37	Misc. typos (#8694) ... Found via `codespell -q 3 --skip="./app/javascript/mastodon/locales,./config/locales"`	6 years ago
Sorin Davidoi	6f3d934bc1	feat(cookies): Use the same-site attribute to lax (#8626) ... CSFR-prevention is already implemented but adding this doesn't hurt. A brief introduction to Same-Site cookies (and the difference between strict and lax) can be found at https://blog.mozilla.org/security/2018/04/24/same-site-cookies-in-firefox-60/ TLDR: We use lax since we want the cookies to be sent when the user navigates safely from an external site.	6 years ago
M Somerville	2bba6e582d	Rename S3_CLOUDFRONT_HOST to S3_ALIAS_HOST. (#8423) ... Still check for S3_CLOUDFRONT_HOST for existing installs.	7 years ago
ThibG	f06fa09962	Revert to using Paperclip's filesystem storage, and fix dangling records in remove_remote (#8339) ... * Fix uncaching worker * Revert to using Paperclip's filesystem backend instead of fog-local fog-local has lots of concurrency issues, causing failure to delete files, dangling file records, and spurious errors UncacheMediaWorker	7 years ago
Immae	b0f4fe456b	Add ldap search filter (#8151)	7 years ago
Eugen Rochko	018a9e4e7f	Add post-deployment migration system (#8182) ... Adopted from GitLab CE. Generate new migration with: rails g post_deployment_migration name_of_migration_here By default they are run together with db:migrate. To not run them, the env variable SKIP_POST_DEPLOYMENT_MIGRATIONS must be set Code by Yorick Peterse <yorickpeterse@gmail.com>, see also: 83c8241160	7 years ago
abcang	69bf116345	Add secure option to additional cookie (#8069)	7 years ago
Eugen Rochko	1f6ed4f86a	Add more granular OAuth scopes (#7929) ... * Add more granular OAuth scopes * Add human-readable descriptions of the new scopes * Ensure new scopes look good on the app UI * Add tests * Group scopes in screen and color-code dangerous ones * Fix wrong extra scope	7 years ago
MIYAGI Hikaru	ddd0bb69e1	Merge `HIDDEN_SERVICE_VIA_TRANSPARENT_PROXY` into `ALLOW_ACCESS_TO_HIDDEN_SERVICE` (#7901) ... If Mastodon accesses to the hidden service via transparent proxy, it's needed to avoid checking whether it's a private address, since `.onion` is resolved to a private address. I was previously using the `HIDDEN_SERVICE_VIA_TRANSPARENT_PROXY` to provide that function. However, I realized that using `HIDDEN_SERVICE_VIA_TRANSPARENT_PROXY` is redundant, since this specification is always used with `ALLOW_ACCESS_TO_HIDDEN_SERVICE`. Therefore, I decided to integrate the setting of `HIDDEN_SERVICE_VIA_TRANSPARENT_PROXY` into` ALLOW_ACCESS_TO_HIDDEN_SERVICE`.	7 years ago
Eugen Rochko	0df91c7b1e	Add dat, dweb, ipfs, ipns, ssb, gopher protocols to URL extractor (#7810) ... * Add dat:// and gopher:// to URL extractor Fix #6072 * Fix comment indent * Add dweb, ipfs, ipns, ssb	7 years ago
Eugen Rochko	53f0452b70	Remove rack-timeout (#7809) ... Timeout considered harmful due to leaving the app in a broken state, including unreaped database connections	7 years ago
Eugen Rochko	d87649db07	Disable AMS logging (#7623) ... Especially in production it's just noise and doesn't mix well with the log format	7 years ago
MIYAGI Hikaru	919eef3098	User agent for WebFinger (#7531) ... * User agent for WebFinger * local_domain → web_domain * 'http' is away accidentally...	7 years ago
Eugen Rochko	b4fb766b23	Add REST API for Web Push Notifications subscriptions (#7445) ... - POST /api/v1/push/subscription - PUT /api/v1/push/subscription - DELETE /api/v1/push/subscription - New OAuth scope: "push" (required for the above methods)	7 years ago
Hugo Gameiro	ea4e243303	Improve OpenStack v3 compatibility (#7392) ... * Update paperclip.rb * Update .env.production.sample * Update paperclip.rb	7 years ago
Akihiko Odaki	a7e71bbd08	Add a missing question mark in rack_attack.rb (#7338)	7 years ago
Akihiko Odaki	b1d4471e36	Throttle media post (#7337) ... The previous rate limit allowed to post media so fast that it is possible to fill up the disk space even before an administrator notices. The new rate limit is configured so that it takes 24 hours to eat 10 gigabytes: 10 * 1024 / 8 / (24 * 60 / 30) = 27 (which rounded to 30) The period is set long so that it does not prevent from attaching several media to one post, which would happen in a short period. For example, if the period is 5 minutes, the rate limit would be: 10 * 1024 / 8 / (24 * 60 / 5) = 4 This long period allows to lift the limit up.	7 years ago
Eugen Rochko	cb5b5cb5f7	Slightly reduce RAM usage (#7301) ... * No need to re-require sidekiq plugins, they are required via Gemfile * Add derailed_benchmarks tool, no need to require TTY gems in Gemfile * Replace ruby-oembed with FetchOEmbedService Reduce startup by 45382 allocated objects * Remove preloaded JSON-LD in favour of caching HTTP responses Reduce boot RAM by about 6 MiB * Fix tests * Fix test suite by stubbing out JSON-LD contexts	7 years ago
MIYAGI Hikaru	f58dcbc981	HTTP proxy support for outgoing request, manage access to hidden service (#7134) ... * Add support for HTTP client proxy * Add access control for darknet Supress error when access to darknet via transparent proxy * Fix the codes pointed out * Lint * Fix an omission + lint * any? -> include? * Change detection method to regexp to avoid test fail	7 years ago
Yamagishi Kazutoshi	50529cbceb	Upgrade Rails to version 5.2.0 (#5898)	7 years ago
Eugen Rochko	49bbef1202	Use RAILS_LOG_LEVEL to set log level of Sidekiq, too (#7079) ... Fix #3565 (oops)	7 years ago
Eugen Rochko	80a944c882	Log rate limit hits (#7096) ... Fix #7095	7 years ago
Eugen Rochko	d4de2239b0	Add a circuit breaker for ActivityPub deliveries (#7053)	7 years ago
Yamagishi Kazutoshi	28384c1771	Revert "Revert "Upgrade Paperclip to version 6.0.0" (#6807)" (#6808) ... This reverts commit 40871caa4b.	7 years ago
Eugen Rochko	ac49c7932d	Add LDAP_TLS_NO_VERIFY option, don't require LDAP_ENABLED outside .env (#6845) ... Fix #6816, fix #6790	7 years ago
Alexander	33ee347c99	rename pam email environment variable to something more understandable and default to LOCAL_DOMAIN (better fallback) (#6833)	7 years ago