mastodon

Commit Graph

Author	SHA1	Message	Date
Matt Jankowski	668a19a2f3	Fix Performance/DeletePrefix cop (#24796 )	2 years ago
Matt Jankowski	f1c1dd0118	Rename `with_lock` to `with_redis_lock` to avoid confusion with ActiveRecord's method (#24741 )	2 years ago
Claire	a89b02af92	Check domain suspensions before trying to fetch resources (#24535 )	2 years ago
Matt Jankowski	0a5f0a8b20	Remove instance variables from helper usage (#24203 )	2 years ago
Nick Schonning	4ff44be134	Autofix Rubocop Rails/Blank (#23765 )	2 years ago
Nick Schonning	717683d1c3	Autofix Rubocop remaining Layout rules (#23679 )	2 years ago
Nick Schonning	2177daeae9	Autofix Rubocop Style/RedundantBegin (#23703 )	2 years ago
Nick Schonning	e2a3ebb271	Autofix Rubocop Style/IfUnlessModifier (#23697 )	2 years ago
Nick Schonning	669f6d2c0a	Run rubocop formatting except line length (#23632 )	2 years ago
Claire	0c9eac80d8	Fix unbounded recursion in post discovery (#23506 ) * Add a limit to how many posts can get fetched as a result of a single request * Add tests * Always pass `request_id` when processing `Announce` activities --------- Co-authored-by: nametoolong <nametoolong@users.noreply.github.com>	2 years ago
Nick Schonning	ed570050c6	Autofix Rails/EagerEvaluationLogMessage (#23429 ) * Autofix Rails/EagerEvaluationLogMessage * Update spec for debug block syntax	2 years ago
Claire	bb89f0af8a	Fix ActivityPub::ProcessingWorker error on incoming malformed JSON-LD (#23416 )	2 years ago
Claire	68dcbcb7bf	Add more specific error messages to HTTP signature verification (#21617 ) * Return specific error on failure to parse Date header * Add error message when preferredUsername is not set * Change error report to be JSON and include more details * Change error report to differentiate unknown account and failed refresh * Add tests	2 years ago
Claire	2644a28cb3	Change remote media files to be downloaded outside of transactions (#21796 )	2 years ago
Claire	c8849d6cee	Fix unbounded recursion in account discovery (#22025 ) * Fix trying to fetch posts from other users when fetching featured posts * Rate-limit discovery of new subdomains * Put a limit on recursively discovering new accounts	2 years ago
Claire	625216d8e1	Fix attachments of edited statuses not being fetched (#21565 ) * Fix attachments of edited statuses not being fetched * Fix tests	2 years ago
Claire	a5394980f2	Fix NameError in Webfinger redirect handling in ActivityPub::FetchRemoteActorService (#20260 )	2 years ago
Eugen Rochko	e98833748e	Fix being able to spoof link verification (#20217 ) - Change verification to happen in `default` queue - Change verification worker to only be queued if there's something to do - Add `link` tags from metadata fields to page header of profiles	2 years ago
Claire	bbf74498f5	Fix validation error in SynchronizeFeaturedTagsCollectionWorker (#20018 ) * Fix followers count not being updated when migrating follows Fixes #19900 * Fix validation error in SynchronizeFeaturedTagsCollectionWorker Also saves remote user's chosen case for hashtags * Limit remote featured tags before validation	2 years ago
Yamagishi Kazutoshi	94feb2b93f	Fix `FetchFeaturedCollectionService` spec (#19401 ) Regression from #19380	2 years ago
Takeshi Umeda	b0e3f0312c	Add synchronization of remote featured tags (#19380 ) * Add LIMIT of featured tag to instance API response * Add featured_tags_collection_url to Account * Add synchronization of remote featured tags * Deliver update activity when updating featured tag * Remove featured_tags_collection_url * Revert "Add featured_tags_collection_url to Account" This reverts commit `cff349fc27`. * Add hashtag sync from featured collections * Fix tag name normalize * Add target option to fetch featured collection * Refactor fetch_featured_tags_collection_service * Add LIMIT of featured tag to v1/instance API response	2 years ago
Claire	85890bc80f	Fix crash in FetchRemoteKeyService (#19225 ) Fix regression from #19212	2 years ago
Claire	8cf7006d4e	Refactor ActivityPub handling to prepare for non-Account actors (#19212 ) * Move ActivityPub::FetchRemoteAccountService to ActivityPub::FetchRemoteActorService ActivityPub::FetchRemoteAccountService is kept as a wrapper for when the actor is specifically required to be an Account * Refactor SignatureVerification to allow non-Account actors * fixup! Move ActivityPub::FetchRemoteAccountService to ActivityPub::FetchRemoteActorService * Refactor ActivityPub::FetchRemoteKeyService to potentially return non-Account actors * Refactor inbound ActivityPub payload processing to accept non-Account actors * Refactor inbound ActivityPub processing to accept activities relayed through non-Account * Refactor how Account key URIs are built * Refactor Request and drop unused key_id_format parameter * Rename ActivityPub::Dereferencer `signature_account` to `signature_actor`	2 years ago
Claire	1145dbd327	Improve error reporting and logging when processing remote accounts (#15605 ) * Add a more descriptive PrivateNetworkAddressError exception class * Remove unnecessary exception class to rescue clause * Remove unnecessary include to JsonLdHelper * Give more neutral error message when too many webfinger redirects * Remove unnecessary guard condition * Rework how “ActivityPub::FetchRemoteAccountService” handles errors Add “suppress_errors” keyword argument to avoid raising errors in ActivityPub::FetchRemoteAccountService#call (default/previous behavior). * Rework how “ActivityPub::FetchRemoteKeyService” handles errors Add “suppress_errors” keyword argument to avoid raising errors in ActivityPub::FetchRemoteKeyService#call (default/previous behavior). * Fix Webfinger::RedirectError not being a subclass of Webfinger::Error * Add suppress_errors option to ResolveAccountService Defaults to true (to preserve previous behavior). If set to false, errors will be raised instead of caught, allowing the caller to be informed of what went wrong. * Return more precise error when failing to fetch account signing AP payloads * Add tests * Fixes * Refactor error handling a bit * Fix various issues * Add specific error when provided Digest is not 256 bits of base64-encoded data * Please CodeClimate * Improve webfinger error reporting	2 years ago
Jeong Arm	6aa83b13ba	Properly delete remote account's avatar/header when fetch/update (#18973 )	3 years ago
Claire	e0bdaeab65	Fix NoMethodError when resolving a link that redirects to a local post (#18314 ) * Fix NoMethodError when resolving a link that redirects to a local post * Fix tests	3 years ago
Eugen Rochko	6cf57c6765	Refactor how Redis locks are created (#18400 ) * Refactor how Redis locks are created * Fix autorelease duration on account deletion lock	3 years ago
Claire	0597e5db68	Fix ArgumentError when processing pinned posts from Friendica (#18260 ) Follow-up to #18254	3 years ago
Claire	71d02ffcf3	Fix compatibility with Friendica regarding pinned posts (#18254 ) * Fix multiple database queries when fetching pinned posts for remote account * Fix compatibility with Friendica regarding pinned posts Fixes #18066 * Add tests	3 years ago
Eugen Rochko	3917353645	Fix single Redis connection being used across all threads (#18135 ) * Fix single Redis connection being used across all Sidekiq threads * Fix tests	3 years ago
Jeong Arm	1de748bf5e	Fix FetchFeaturedCollectionService (#18030 )	3 years ago
Claire	8f91e304a5	Fix spurious edits and require incoming edits to be explicitly marked as such (#17918 ) * Change post text edit to not be considered significant if it's identical after reformatting * We don't need to clear previous change information anymore * Require status edits to be explicit, except for poll tallies * Fix tests * Add some tests * Add poll-related tests * Add HTML-formatting related tests	3 years ago
Claire	454ef42aab	Fix error when encountering invalid pinned posts (#17964 )	3 years ago
Eugen Rochko	71f2b95106	Fix edits with no actual changes being allowed (#17843 ) * Fix edits with no actual changes being allowed locally * Fix edits with no actual changes being allowed through ActivityPub * Fix false positive changes caused by description processing in model * Fix not recording poll expiration update * Fix test * Revert changes to ProcessStatusUpdateService * Various fixes and improvements * Fix code style issues * Various changes and improvements * Add guard clause	3 years ago
Claire	92a86b958e	Fix issues with processing toot edits (#17748 ) * Fix searching for an already-known status by URL not working * Fix Update processing from statuses prior to 20220302232632 `ordered_media_attachment_ids_changed?` would return `true` when going from `nil` to anything (including `[]`). * Add tests	3 years ago
Claire	d3aa9cf774	Fix Updates being forwarded even when not processable or causing no change (#17699 ) * Fix Updates being forwarded even when not processable or causing no change * Refactor and ensure status edit is strictly newer than last known edit	3 years ago
Eugen Rochko	ddbe906c25	Fix not updating a status when newer version is fetched manually (#17745 )	3 years ago
Eugen Rochko	b2cd34474b	Add rate limit for editing (#17728 )	3 years ago
Eugen Rochko	d17fb70131	Change how changes to media attachments are stored for edits (#17696 ) * Change how changes to media attachments are stored for edits Fix not being able to re-order media attachments * Fix not broadcasting updates when polls/media is changed through ActivityPub * Various fixes and improvements * Update app/models/report.rb Co-authored-by: Claire <claire.github-309c@sitedethib.com> * Add tracking of media attachment description changes * Change poll in status edit to have a structure closer to the real one Co-authored-by: Claire <claire.github-309c@sitedethib.com>	3 years ago
Claire	63854bee6c	Fix poll votes not being properly reset on poll change (#17498 ) * Fix poll votes not being properly reset on poll change * Fix and add tests * Fix poll update handling when the number of options changes	3 years ago
Eugen Rochko	63002cde03	Add editing for published statuses (#17320 ) * Add editing for published statuses * Fix change of multiple-choice boolean in poll not resetting votes * Remove the ability to update existing media attachments for now	3 years ago
Eugen Rochko	b6d7726ecb	Remove language detection through cld3 (#17478 ) * Remove language detection through cld3 * Update app/helpers/languages_helper.rb Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh> Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh>	3 years ago
Claire	c8b1e72a4f	Fix compacted JSON-LD possibly causing compatibility issues on forwarding (#17428 )	3 years ago
Claire	d1ecc323e7	Compact JSON-LD signed incoming activities (#17426 ) Co-authored-by: Puck Meerburg <puck@puck.moe>	3 years ago
Claire	03d59340da	Fix Sidekiq warnings about JSON serialization (#17381 ) * Fix Sidekiq warnings about JSON serialization This occurs on every symbol argument we pass, and every symbol key in hashes, because Sidekiq expects strings instead. See https://github.com/mperham/sidekiq/pull/5071 We do not need to change how workers parse their arguments because this has not changed and we were already converting to symbols adequately or using `with_indifferent_access`. * Set Sidekiq to raise on unsafe arguments in test mode In order to more easily catch issues that would produce warnings in production code.	3 years ago
Eugen Rochko	6505b39e5d	Fix poll updates being saved as status edits (#17373 ) Fix #17344	3 years ago
Eugen Rochko	d412a8d1f2	Fix error when processing poll updates (#17333 ) Regression from #16697	3 years ago
Eugen Rochko	1060666c58	Add support for editing for published statuses (#16697 ) * Add support for editing for published statuses * Fix references to stripped-out code * Various fixes and improvements * Further fixes and improvements * Fix updates being potentially sent to unauthorized recipients * Various fixes and improvements * Fix wrong words in test * Fix notifying accounts that were tagged but were not in the audience * Fix mistake	3 years ago
Jeong Arm	2d1f082bb6	Fix NameError on ActivityPub::FetchFeaturedCollectionService (#17326 ) Related: #16954	3 years ago
Claire	d5c9feb7b7	Add support for private pinned posts (#16954 ) * Add support for private pinned toots * Allow local user to pin private toots * Change wording to avoid "direct message"	3 years ago

1 2 3

150 Commits (ceca93d0d1146dd37da3cb947cf9cfdaeca0f80f)