mastodon

Commit Graph

Author	SHA1	Message	Date
Matt Jankowski	ad81be6c8e	Update rubocop rules for linelength (#26190 )	2 years ago
Matt Jankowski	bada7a65aa	Ignore long line in regex initializer (#26182 )	2 years ago
Claire	e5f1000ad1	Fix CSP headers being unintendedly wide (#26105 )	2 years ago
Claire	934c7b33d1	Change default KeyGenerator digest to SHA1 to fix cookies in rolling upgrades (#26023 )	2 years ago
Misty De Méo	b848ba3867	Paperclip: add support for Azure blob storage (#23607 )	2 years ago
Matt Jankowski	ce43ed144c	Rails 7.0 update (#25668 )	2 years ago
Matt Jankowski	2e1391fdd2	Fix `Naming/MemoizedInstanceVariableName` cop (#25928 )	2 years ago
Nick Schonning	1d557305d2	Enable Rubocop Style/FrozenStringLiteralComment (#23793 )	2 years ago
Kurtis Rainbolt-Greene	e4cfe4b3db	First pass at multi-database for read replica using Rails native adapter (#25693 ) Co-authored-by: emilweth <7402764+emilweth@users.noreply.github.com>	2 years ago
Claire	dc8f1fbd97	Merge pull request from GHSA-9928-3cp5-93fm * Fix attachments getting processed despite failing content-type validation * Add a restrictive ImageMagick security policy tailored for Mastodon * Fix misdetection of MP3 files with large cover art * Reject unprocessable audio/video files instead of keeping them unchanged	2 years ago
Eugen Rochko	ba06a2f104	Revert "Rails 7 update" (#25667 )	2 years ago
Matt Jankowski	50c2a03695	Rails 7 update (#24241 )	2 years ago
Claire	f378f10404	Fix compatibility of recent migration with PostgreSQL 10 (#25324 )	2 years ago
Nick Schonning	c66250abf1	Autofix Rubocop Regex Style rules (#23690 ) Co-authored-by: Claire <claire.github-309c@sitedethib.com>	2 years ago
Claire	e428670e61	Fix CSP headers when S3_ALIAS_HOST includes a path component (#25273 )	2 years ago
Matt Jankowski	e49819142f	Remove unmaintained `nsa` gem (#25265 )	2 years ago
Claire	94329f28e1	Change wording of “Content cache retention period” setting to highlight destructive implications (#23261 )	2 years ago
Renaud Chaput	942d850b0a	Allow carets in URL search params (#25216 )	2 years ago
Nick Schonning	c0b9664a31	Autofix Rubocop spacing in config (#25022 )	2 years ago
Nick Schonning	cee4369cf5	Autofix Rubocop Lint/AmbiguousOperatorPrecedence (#25002 )	3 years ago
Matt Jankowski	d9a958fcf7	Fix Performance/RedundantMerge cop (#24817 )	3 years ago
Matt Jankowski	d902a707a3	Fix Rails/CompactBlank cop (#24690 )	3 years ago
Matt Jankowski	5a2aa06a51	Fix Rails/Present cop (#24688 )	3 years ago
Nick Schonning	49fad26eca	Drop EOL Ruby 2.7 (#24237 )	3 years ago
Nick Schonning	4687967176	Autofix Rubocop Style/NumericLiterals (#24468 )	3 years ago
Claire	5c499f54e3	Change root Chewy strategy to emit a warning instead of erroring out in production mode (#24327 )	3 years ago
Nick Schonning	500d6f93be	Autofix Rubocop Style/IdenticalConditionalBranches (#24322 )	3 years ago
Eugen Rochko	a9b5598c97	Change user settings to be stored in a more optimal way (#23630 ) Co-authored-by: Claire <claire.github-309c@sitedethib.com>	3 years ago
Claire	e084b5b82d	Fix user archive takeout when using OpenStack Swift or S3 providers with no ACL support (#24200 )	3 years ago
Claire	f432db7b9f	Fix sidekiq jobs not triggering Elasticsearch index updates (#24046 )	3 years ago
Jean byroot Boussier	922837dc96	Upgrade to latest redis-rb 4.x and fix deprecations (#23616 ) Co-authored-by: Jean Boussier <jean.boussier@gmail.com>	3 years ago
Jamie Hoyle	de137e6bb0	Added support for specifying S3 storage classes in environment (#22480 )	3 years ago
Eugen Rochko	c6ef56fd5e	Change rate limits to 1,500/5m per user, 300/5m per app (#23347 )	3 years ago
luzpaz	596923da4a	Fix typos in source documentation (#21046 ) Fixed 2 source comment/documentation typos	3 years ago
Claire	d587a268fd	Add logging for Rails cache timeouts (#21667 ) * Reduce redis cache store connect timeout from default 20 seconds to 5 seconds * Log cache store errors	3 years ago
Claire	7955d4b959	Add form-action CSP directive (#20781 )	3 years ago
trwnh	a2931d19ae	Add missing admin scopes (fix #20892 ) (#20918 )	3 years ago
Eugen Rochko	43b0b2f3f4	Fix wrong directive `unsafe-wasm-eval` to `wasm-unsafe-eval` (#20729 )	3 years ago
prplecake	b46b7c3d5e	Use "unsafe-wasm-eval" instead of "unsafe-eval" in script-src CSP (#20606 ) * Add "unsafe-eval" to script-src CSP * Use 'unsafe-wasm-eval' instead of 'unsafe-eval'	3 years ago
Eugen Rochko	21fd25a269	Fix rate limiting for paths with formats (#20675 )	3 years ago
Matt Corallo	9d039209cc	Add `Cache-Control` header to openstack-stored files (#20610 ) When storing files in S3, paperclip is configured with a Cache-Control header indicating the file is immutable, however no such header was added when using OpenStack storage. Luckily Paperclip's fog integration makes this trivial, with a simple `fog_file` `Cache-Control` default doing the trick.	3 years ago
David Hewitt	290d78cea4	Allow unsetting x-amz-acl S3 Permission headers (#20510 ) Some "S3 Compatible" storage providers (Cloudflare R2 is one such example) don't support setting ACLs on individual uploads with the `x-amz-acl` header, and instead just have a visibility for the whole bucket. To support uploads to such providers without getting unsupported errors back, lets use a black `S3_PERMISSION` env var to indicate that these headers shouldn't be sent. This is tested as working with Cloudflare R2.	3 years ago
prplecake	aafbc82d88	Add "unsafe-eval" to script-src CSP (#18817 )	3 years ago
Eugen Rochko	bf0ab3e0fa	Fix vacuum scheduler missing lock, locks never expiring (#19458 ) Remove vacuuming of orphaned preview cards	3 years ago
Eugen Rochko	0d6b878808	Add user content translations with configurable backends (#19218 )	3 years ago
Eugen Rochko	546672e292	Change "Allow trends without prior review" setting to include statuses (#17977 ) * Change "Allow trends without prior review" setting to include posts * Fix i18n-tasks	3 years ago
Jeong Arm	861b35dd54	Support "http_hidden_proxy" ENV var for hidden service only proxy (#18427 ) * Support "http_hidden_proxy" ENV var for hidden service only proxy * Fallback to http_proxy if http_hidden_proxy is not set	3 years ago
Eugen Rochko	e7aa2be828	Change how hashtags are normalized (#18795 ) * Change how hashtags are normalized * Fix tests	3 years ago
Claire	ae4f068a84	Fix CAS_DISPLAY_NAME, SAML_DISPLAY_NAME and OIDC_DISPLAY_NAME being ignored (#18568 )	3 years ago
Eugen Rochko	96129c2f10	Fix confirmation redirect to app without `Location` header (#18523 )	3 years ago
Eugen Rochko	679b7158e3	Change search indexing to use batches to minimize resource usage (#18451 )	4 years ago
Eugen Rochko	7b0fe4aef9	Fix opening and closing Redis connections instead of using a pool (#18171 ) * Fix opening and closing Redis connections instead of using a pool * Fix Redis connections not being returned to the pool in CLI commands	4 years ago
Claire	8284110c55	Fix stoplight not using REDIS_NAMESPACE (#18160 )	4 years ago
Eugen Rochko	3917353645	Fix single Redis connection being used across all threads (#18135 ) * Fix single Redis connection being used across all Sidekiq threads * Fix tests	4 years ago
Eugen Rochko	6e418bf346	Fix cookies secure flag being set when served over Tor (#17992 )	4 years ago
Holger	39b489ba4c	fix: `s3_force_single_request` not parsed (#17922 )	4 years ago
Eugen Rochko	cefa526c6d	Refactor formatter (#17828 ) * Refactor formatter * Move custom emoji pre-rendering logic to view helpers * Move more methods out of Formatter * Fix code style issues * Remove Formatter * Add inline poll options to RSS feeds * Remove unused helper method * Fix code style issues * Various fixes and improvements * Fix test	4 years ago
Claire	895212bb2f	Fix PgHero suggesting migrations (#17807 ) * Fix PgHero suggesting migrations Fixes #17768 * Keep migration suggestions in development env	4 years ago
Yamagishi Kazutoshi	eb9a7e3626	Fix LetterOpennerWeb CSP (#17770 )	4 years ago
dependabot[bot]	46ad7fea9d	Bump rack-attack from 6.5.0 to 6.6.0 (#17405 ) * Bump rack-attack from 6.5.0 to 6.6.0 Bumps [rack-attack](https://github.com/rack/rack-attack) from 6.5.0 to 6.6.0. - [Release notes](https://github.com/rack/rack-attack/releases) - [Changelog](https://github.com/rack/rack-attack/blob/master/CHANGELOG.md) - [Commits](https://github.com/rack/rack-attack/compare/v6.5.0...v6.6.0) --- updated-dependencies: - dependency-name: rack-attack dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Fix usage of deprecated API Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>	4 years ago
chandrn7	a6ed6845c9	Allow login through OpenID Connect (#16221 ) * added OpenID Connect as an SSO option * minor fixes * added comments, removed an option that shouldn't be set * fixed Gemfile.lock * added newline to end of Gemfile.lock * removed tab from Gemfile.lock * remove chomp * codeclimate changes and small name change to make function's purpose clearer * codeclimate fix * added SSO buttons to /about page * minor refactor * minor style change * removed spurious change * removed unecessary conditional from ensure_valid_username and added support for auth.info.name in user_params_from_auth * minor changes	4 years ago
Josh Soref	b5329e0035	Spelling (#17705 ) * spelling: account Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: affiliated Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: appearance Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: autosuggest Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: cacheable Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: component Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: conversations Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: domain.example Clarify what's distinct and use RFC friendly domain space. Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: environment Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: exceeds Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: functional Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: inefficiency Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: not Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: notifications Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: occurring Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: position Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: progress Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: promotable Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: reblogging Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: repetitive Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: resolve Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: saturated Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: similar Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: strategies Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: success Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: targeting Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: thumbnails Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: unauthorized Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: unsensitizes Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: validations Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: various Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>	4 years ago
luzpaz	73f5e4a1d9	Fix various typos (#17621 ) Found via `codespell -q 3 -S ./CHANGELOG.md,./AUTHORS.md,./config/locales,./app/javascript/mastodon/locales -L ba,keypair,medias,ro`	4 years ago
Claire	8603a07504	Fix error when trying to register (#17600 )	4 years ago
zunda	f9e7f2e409	Avoid return within block (#17590 ) This prevents the error: LocalJumpError (unexpected return)	4 years ago
Jeong Arm	1de2e3f980	Throttle IPv6 signup for subnet (#17588 )	4 years ago
Claire	cfa583fa71	Remove support for OAUTH_REDIRECT_AT_SIGN_IN (#17287 ) Fixes #15959 Introduced in #6540, OAUTH_REDIRECT_AT_SIGN_IN allowed skipping the log-in form to instead redirect to the external OmniAuth login provider. However, it did not prevent the log-in form on /about introduced by #10232 from appearing, and completely broke with the introduction of #15228. As I restoring that previous log-in flow without introducing a security vulnerability may require extensive care and knowledge of how OmniAuth works, this commit removes support for OAUTH_REDIRECT_AT_SIGN_IN instead for the time being.	4 years ago
Eugen Rochko	8e84ebf0cb	Remove IP tracking columns from users table (#16409 )	4 years ago
Jeong Arm	ea61d3acd6	Fix media API limit (#17272 )	4 years ago
Eugen Rochko	fe71548844	Fix warnings on Rails boot (#16946 )	4 years ago
Takeshi Umeda	06631fdc53	Fix ElasticSearch to Elasticsearch (#17050 )	4 years ago
Takeshi Umeda	3419d3ec84	Bump chewy from 5.2.0 to 7.2.3 (supports Elasticsearch 7.x) (#16915 ) * Bump chewy from 5.2.0 to 7.2.2 * fix style (codeclimate) * fix style * fix style * Bump chewy from 7.2.2 to 7.2.3	4 years ago
Claire	6da135a493	Fix reviving revoked sessions and invalidating login (#16943 ) Up until now, we have used Devise's Rememberable mechanism to re-log users after the end of their browser sessions. This mechanism relies on a signed cookie containing a token. That token was stored on the user's record, meaning it was shared across all logged in browsers, meaning truly revoking a browser's ability to auto-log-in involves revoking the token itself, and revoking access from all logged-in browsers. We had a session mechanism that dynamically checks whether a user's session has been disabled, and would log out the user if so. However, this would only clear a session being actively used, and a new one could be respawned with the `remember_user_token` cookie. In practice, this caused two issues: - sessions could be revived after being closed from /auth/edit (security issue) - auto-log-in would be disabled for all browsers after logging out from one of them This PR removes the `remember_token` mechanism and treats the `_session_id` cookie/token as a browser-specific `remember_token`, fixing both issues.	4 years ago
Jeong Arm	c8ce728705	Support authentication for ElasticSearch (#16890 ) * Support authentication for ElasticSearch * Fix chewy auth settings	4 years ago
Claire	b21f3aa21d	Minor memory optimizations (#16507 ) Reduce constant memory usage by ~100kB and further reduce boot-up memory allocations and temporary memory use by a further ~200kB.	4 years ago
Daniel	2ed1c92c63	New env variable: CAS_SECURITY_ASSUME_EMAIL_IS_VERIFIED (#16655 ) When using a CAS server, the users only have a temporary email `change@me-foo-cas.com` which can't be changed but by an administrator. We need a new environment variable like for SAML to assume the email from CAS is verified. * config/initializers/omniauth.rb: define CAS option for assuming email are always verified. * .env.nanobox: add new variable as an example.	4 years ago
Claire	211d5c3c30	Fix inefficiencies in auto-linking code (#16506 ) The auto-linking code basically rewrote the whole string escaping non-ascii characters in an inefficient way, and building a full character offset map between the unescaped and escaped texts before sending the contents to TwitterText's extractor. Instead of doing that, this commit changes the TwitterText regexps to include valid IRI characters in addition to valid URI characters.	4 years ago
Claire	b715cede4d	Fix mailer jobs for deleted notifications erroring out (#16294 ) Fixes an oversight in the Rails 6 migration	5 years ago
Claire	97539b6a96	Fix host check on healthcheck path not being disabled (#16270 ) Fixes #16251 There was a typo in #16243	5 years ago
Jeong Arm	f09322f9cc	Disable host check on healthcheck path (#16243 )	5 years ago
Takeshi Umeda	9b18914c35	Add a Redis environment variable for sidekiq (#16188 )	5 years ago
Claire	566fc90913	Add Ruby 3.0 support (#16046 ) * Fix issues with POSIX::Spawn, Terrapin and Ruby 3.0 Also improve the Terrapin monkey-patch for the stderr/stdout issue. * Fix keyword argument handling throughout the codebase * Monkey-patch Paperclip to fix keyword arguments handling in validators * Change validation_extensions to please CodeClimate * Bump microformats from 4.2.1 to 4.3.1 * Allow Ruby 3.0 * Add Ruby 3.0 test target to CircleCI * Add test for admin dashboard warnings * Fix admin dashboard warnings on Ruby 3.0	5 years ago
Takeshi Umeda	2360191434	Fix guard against DNS rebinding attacks (#16095 )	5 years ago
Takeshi Umeda	8323023464	Add guard against DNS rebinding attacks (#16087 ) * Add guard against DNS rebinding attacks * Fix not to apply to test environment	5 years ago
Eugen Rochko	3b8d085436	Fix app name, website and redirect URIs not having a maximum length (#16042 ) Fix app scopes not being validated	5 years ago
Eugen Rochko	3f2533ca8e	Fix autoloading deprecation warnings from Rails 6 (#16010 )	5 years ago
Eugen Rochko	82cce18227	Change health check (#15988 )	5 years ago
Claire	cbd0ee1d07	Update Mastodon to Rails 6.1 (#15910 ) * Update devise-two-factor to unreleased fork for Rails 6 support Update tests to match new `rotp` version. * Update nsa gem to unreleased fork for Rails 6 support * Update rails to 6.1.3 and rails-i18n to 6.0 * Update to unreleased fork of pluck_each for Ruby 6 support * Run "rails app:update" * Add missing ActiveStorage config file * Use config.ssl_options instead of removed ApplicationController#force_ssl Disabled force_ssl-related tests as they do not seem to be easily testable anymore. * Fix nonce directives by removing Rails 5 specific monkey-patching * Fix fixture_file_upload deprecation warning * Fix yield-based test failing with Rails 6 * Use Rails 6's index_with when possible * Use ActiveRecord::Cache::Store#delete_multi from Rails 6 This will yield better performances when deleting an account * Disable Rails 6.1's automatic preload link headers Since Rails 6.1, ActionView adds preload links for javascript files in the Links header per default. In our case, that will bloat headers too much and potentially cause issues with reverse proxies. Furhermore, we don't need those links, as we already output them as HTML link tags. * Switch to Rails 6.0 default config * Switch to Rails 6.1 default config * Do not include autoload paths in the load path	5 years ago
Claire	a4dcaef53b	Prepare Mastodon for zeitwerk autoloader (#15917 ) * Prepare Mastodon for zeitwerk autoloader (Rails 6) Add inflections and rename/move a few classes. In particular, app/lib/exceptions.rb and app/lib/sanitize_config.rb were manually loaded while still in autoload paths. * Add inflection for Url → URL	5 years ago
Claire	43eff898a0	Prepare Mastodon for Rails 6 (#15911 ) * Fix misuse of foreign_type * Fix use of removed "add_template_helper" * Use response.media_type instead of response.content_type in tests * Fix CSV export controller test on Rails 6 Rails 6 sets a "filename" field in the Content-Disposition header to explicitly encode the filename as UTF-8. This changes checks the first part of the Content-Disposition header so it matches in both Rails 5 and Rails 6. Fix emoji formatting with Rails 6 * Make emoji output more idiomatic and robust * Switch from redis-rails gem to built-in Rails redis cache storage	5 years ago
Eugen Rochko	e89e976e92	Fix configuration for sidekiq-unique-jobs after 7.x upgrade (#15908 ) Remove locks from scheduled jobs	5 years ago
Claire	65db262550	Update twitter-text from 1.14 to 3.1.0 and fix toot character counting (#15382 ) * Update twitter-text from 1.14 to 3.1.0 * Disable emoji parsing * Properly depend on twitter-text for url detection * Fix some URLs being wrongly detected client-side * Add test for server-side validation of non-autolinkable URLs * Fix server-side status length counting	5 years ago
Eugen Rochko	ee1119208c	Add `POST /api/v1/emails/confirmations` to REST API (#15816 ) Only available to the application the user originally signed-up with	5 years ago
Shlee	ab9c2ed98d	Delete pagination.rb (#15754 )	5 years ago
Claire	21fb3f3684	Drop dependency on secure_headers, fix response headers (#15712 ) * Drop dependency on secure_headers, use always_write_cookie instead * Fix cookies in Tor Hidden Services by moving configuration to application.rb * Instead of setting always_write_cookie at boot, monkey-patch ActionDispatch	5 years ago
Cecylia Bocovich	e79f8dd85c	Onion service related changes to HTTPS handling (#15560 ) * Enable secure cookie flag for https only * Disable force_ssl for .onion hosts only Co-authored-by: Aiden McClelland <me@drbonez.dev>	5 years ago
Shubhendra Singh Chauhan	c8d11b8bdb	Fixed code quality issues (#15541 ) * Added .deepsource.toml * Removed bad use of `alias` * Fixed operand order in the binary expression * Prefixed unused method arguments with an underscore * Replaced the old OpenSSL algorithmic constants with the newer strings initializers. * Removed unnecessary UTF-8 encoding comment	5 years ago
luigi	eb51e43fb4	Optimize some regex matching (#15528 ) * Use Regex#match? * Replace =~ too * Avoid to call match? from Nil * Keep value of Regexp.last_match	5 years ago
kaiyou	f47c177eb7	Support clock drift in Omniauth SAML provider (#15511 ) The setting is not well documented by the provider, but allows for clock skew between SP and IDP, see: https://github.com/omniauth/omniauth-saml/blob/master/spec/omniauth/strategies/saml_spec.rb Co-authored-by: kaiyou <dev@kaiyou.fr>	5 years ago
Eugen Rochko	9915d11c0d	Fix unnecessary queries when batch-removing statuses, 100x faster (#15387 )	5 years ago

1 2 3 4 5 ...

466 Commits (cb0f3ecc28f508af25013834905bb9a11ac87314)