Commit Graph

25 Commits (c3f57188ae9bf48de5dd987cc1fcf50deab241a6)

Author SHA1 Message Date
Eugen Rochko aa9a20cde0
Fix ThreadResolveWorker getting queued with invalid URLs ()
Eugen Rochko 802cf6a4c5
Improve federated ID validation ()
* Fix URI not being sufficiently validated with prefetched JSON

* Add additional id validation to OStatus documents, when possible
Akihiko Odaki 55fd55714a Raise Mastodon::RaceConditionError if Redis lock failed ()
An explicit error allows user agents to know the error and Sidekiq to
retry.
Eugen Rochko 6208ea5a53
If an OStatus message contains nsfw hashtag, mark it as sensitive ()
* If an OStatus message contains nsfw hashtag, mark it as sensitive

Undo parts of 

* Put nsfw hashtag on OStatus messages if they have any media

* Fix code style issues
ThibG a24605961a Fixes/do not override timestamps ()
* Revert "Fixes/do not override timestamps ()"

This reverts commit 581a5c9d29.

* Document Snowflake ID corner-case a bit more

Snowflake IDs are used for two purposes: making object identifiers harder to
guess and ensuring they are in chronological order. For this reason, they
are based on the `created_at` attribute of the object.

Unfortunately, inserting items with older snowflakes IDs will break the
assumption of consumers of the paging APIs that new items will always have
a greater identifier than the last seen one.

* Add `override_timestamps` virtual attribute to not correlate snowflake ID with created_at
ThibG 581a5c9d29 Fixes/do not override timestamps ()
* Do not override timestamps for incoming toots

* Remove every reference to override_timestamps

Statuses are now created with the announced publishing date
and are only pushed to timelines if that date is at most
6 hours earlier than the time at which it is processed.
Eugen Rochko f02411da40
Ignore media validation when attaching to status during processing ()
Fix 
MitarashiDango 6dcf96271e fix validation error (media only status) ()
* fix validation error (media only status)

* Incorporating review suggestions

* Reflect similar fix to OStatus side

* Fix not to include media in transaction

* Restore the limit of the number of media

* Fix not to return nil
Eugen Rochko a71af98401
Push discovered status through streaming API within a time window ()
Time window of 6 hours
Eugen Rochko 35b84985a8
Skip ActivityPub Announces of non-public objects ()
* Skip ActivityPub Announces of non-public objects

* Skip OStatus reblogs of non-public statuses
abcang 3caec1ecc2 Save media outside transaction ()
Yamagishi Kazutoshi b21db9bbde Using double splat operator ()
Eugen Rochko 484208ce12 When status is fetched instead of delivered, do not stream it ()
Eugen Rochko 0717d9b3e6 Set snowflake IDs for backdated statuses ()
- Rename Mastodon::TimestampIds into Mastodon::Snowflake for clarity
- Skip for statuses coming from inbox, aka delivered in real-time
- Skip for statuses that claim to be from the future
Akihiko Odaki 63f0979799 Validate id of ActivityPub representations ()
Additionally, ActivityPub::FetchRemoteStatusService no longer parses
activities.
OStatus::Activity::Creation no longer delegates to ActivityPub because
the provided ActivityPub representations are not signed while OStatus
representations are.
ThibG 34fa305a00 Fix race condition when processing incoming OStatus messages ()
* Avoid races in incoming OStatus toots processing

* oops

* oops again
Akihiko Odaki bb4d005a83 Introduce OStatus::TagManager ()
Eugen Rochko 81cec35dbf Custom emoji ()
* Custom emoji

- In OStatus: `<link rel="emoji" name="coolcat" href="http://..." />`
- In ActivityPub: `{ type: "Emoji", name: ":coolcat:", href: "http://..." }`
- In REST API: Status object includes `emojis` array (`shortcode`, `url`)
- Domain blocks with reject media stop emojis
- Emoji file up to 50KB
- Web UI handles custom emojis
- Static pages render custom emojis as `<img />` tags

Side effects:

- Undo  optimization, as I needed to modify it to restore
  shortcode handling in emojify()
- Formatter#plaintext should now make sure stripped out line-breaks
  and paragraphs are replaced with newlines

* Fix emoji at the start not being converted
unarist 504737e860 Convert OStatus tag to ActivityPub id on in_reply_to resolution ()
unarist af2d22f88c Fallback from perform_via_activitypub on private posts ()
Currently, private / direct posts via OStatus from AP compatible instance will be dropped due to failing to fetch AP version.

So this fallbacks to OStatus handling:

* when failed to fetch ActivityPub version
* when status is neither :public nor :unlisted
Eugen Rochko 4c76402ba1 Serialize ActivityPub alternate link into OStatus deletes, handle it ()
Requires moving Atom rendering from DistributionWorker (where
`stream_entry.status` is already nil) to inline (where
`stream_entry.status.destroyed?` is true) and distributing that.

Unfortunately, such XML renderings can no longer be easily chained
together into one payload of n items.
Eugen Rochko 40c45f5dd9 Put ActivityPub alternate link into Atom, prefer it when processing Atom ()
Eugen Rochko 4fcbb1f838 Re-add missing transaction around status-from-OStatus creation ()
Eugen Rochko a5a07da892 Correct OStatus inflection (Ostatus -> OStatus) ()
Akihiko Odaki 89b988cab5 Introduce Ostatus name space ()
* Wrap methods of ProcessFeedService::ProcessEntry in classes

This is a change same with 425acecfdb, except
that it has the following changes:

* Revert irrelevant change in find_or_create_conversation
* Fix error handling for RemoteActivity

* Introduce Ostatus name space