mastodon

Commit Graph

Author	SHA1	Message	Date
Matt Jankowski	0a5f0a8b20	Remove instance variables from helper usage (#24203 )	2 years ago
Eugen Rochko	a9b5598c97	Change user settings to be stored in a more optimal way (#23630 ) Co-authored-by: Claire <claire.github-309c@sitedethib.com>	2 years ago
Matt Jankowski	e63524f457	Update retention model sql query (#24249 )	2 years ago
Claire	8fdf49b11d	Add warning for object storage misconfiguration (#24137 )	2 years ago
Christian Schmidt	bd047acc35	Replace `Status#translatable?` with language matrix in separate endpoint (#24037 )	2 years ago
Eugen Rochko	630436ab2d	Refactor monkey-patching of `PrivateAddressCheck` (#24122 )	2 years ago
Claire	9875be09fe	Fix dashboard crash on ElasticSearch server error (#23751 )	2 years ago
Claire	1d0ad558ff	Change sidekiq-bulk's batch size from 10,000 to 1,000 jobs in one Redis call (#24034 )	2 years ago
Christian Schmidt	684a970b3c	Unescape HTML entities (#24019 )	2 years ago
Matt Jankowski	dfa1be4ab4	Remove unused TOCGenerator (#23986 )	2 years ago
Jean byroot Boussier	922837dc96	Upgrade to latest redis-rb 4.x and fix deprecations (#23616 ) Co-authored-by: Jean Boussier <jean.boussier@gmail.com>	2 years ago
Christian Schmidt	5a8c651e8f	Only offer translation for supported languages (#23879 )	2 years ago
Nick Schonning	0cfdd1a401	Enable Rubocop Style/StringConcatenation defaults (#23792 )	2 years ago
Nick Schonning	59c8d43d94	Autofix Rubocop Style/RescueStandardError (#23745 )	2 years ago
Nick Schonning	717683d1c3	Autofix Rubocop remaining Layout rules (#23679 )	2 years ago
Nick Schonning	21bf326356	Autofix Rubocop Rails/Pluck (#23730 )	2 years ago
Nick Schonning	81ad6c2e39	Autofix Rubocop Style/StringLiterals (#23695 )	2 years ago
Nick Schonning	2177daeae9	Autofix Rubocop Style/RedundantBegin (#23703 )	2 years ago
Nick Schonning	e2a3ebb271	Autofix Rubocop Style/IfUnlessModifier (#23697 )	2 years ago
Nick Schonning	8aee4de034	Autofix Rubocop Style/PerlBackrefs (#23649 )	2 years ago
Nick Schonning	a6f77aa28a	Autofix Rubocop Lint/AmbiguousOperatorPrecedence (#23681 )	2 years ago
Nick Schonning	634368c491	Autofix Rubocop Lint/SymbolConversion (#23683 )	2 years ago
Nick Schonning	669f6d2c0a	Run rubocop formatting except line length (#23632 )	2 years ago
Claire	0c9eac80d8	Fix unbounded recursion in post discovery (#23506 ) * Add a limit to how many posts can get fetched as a result of a single request * Add tests * Always pass `request_id` when processing `Announce` activities --------- Co-authored-by: nametoolong <nametoolong@users.noreply.github.com>	2 years ago
Nick Schonning	0592937264	Apply Rubocop Rails/WhereNot (#23448 ) * Apply Rubocop Rails/WhereNot * Update spec for where.not	2 years ago
Nick Schonning	0d1f192c54	Apply Rubocop Performance/BlockGivenWithExplicitBlock (#23441 ) * Apply Rubocop Performance/BlockGivenWithExplicitBlock * Unprefix used block parameter	2 years ago
Nick Schonning	203739dd3a	Apply Rubocop Performance/StringIdentifierArgument (#23444 )	2 years ago
Nick Schonning	ef8988aef2	Apply Rubocop Performance/DoubleStartEndWith (#23442 )	2 years ago
Nick Schonning	ed570050c6	Autofix Rails/EagerEvaluationLogMessage (#23429 ) * Autofix Rails/EagerEvaluationLogMessage * Update spec for debug block syntax	2 years ago
Eugen Rochko	4c919812b9	Change number of stored items in home feed from 400 to 800 (#23349 )	2 years ago
Claire	41517a4845	Fix spurious admin dashboard warning when using ElasticSearch 7.x (#23064 ) Some 7.x ElasticSearch versions support some 6.x nodes, thus the version check is inadequate. I am not sure there is a good way to check if a server implements all the 7.x APIs, so check server version and minimum wire version instead.	2 years ago
Markus Unterwaditzer	0c689b9d01	fix: allow verification when page size exceeds 1MB (using HTML5 parser) (#22879 ) * fix: allow verification when page size exceeds 1MB Truncates the page after 1MB instead Closes #15316 * switch to HTML5 parser, fix rubocop errors * undo rubocop fixes Co-authored-by: Chris Zubak-Skees <chriszs@gmail.com>	2 years ago
Kaspar V	ae62e5fa53	Fix/remove calling private method with send in model (#22951 ) * fix(status): remove send usage for private unlink_from_conversations - make unlink_from_conversations public method - rename unlink_from_conversations to unlink_from_conversations! - fix send call on private method in statuses_vacuum and batched_remove_status_service * fix(feeds_vacuum): replace find_in_batches with in_batches because active record query results should be a little more efficient than itterating with map and each. Postgres can grasp such lists of ids much quicker than ruby can. Will probably make allmost no difference, but cannot hurt either.	2 years ago
Vyr Cossont	06f979098c	Check OpenSearch compatibility version instead of regular version (#22422 ) Fixes #18535.	2 years ago
Jeong Arm	fdd1facba1	Fix home TL could contain post from who blocked me (#22849 ) * Fix home tl contains post from who blocked me * Add test * Fix feed_manager's build_crutches blocked_by was not includes status' owner * Add test for status from I blocked * Fix typo	2 years ago
Claire	d13702ac06	Fix status cache hydration discrepancy (#19879 )	2 years ago
Claire	673c54f114	Fix inability to use local LibreTranslate without setting ALLOWED_PRIVATE_ADDRESSES (#21926 ) Fixes #20029	2 years ago
s0	52540771b0	Fix crash in elasticsearch_check.rb (#21006 ) Nil unwrap causes the admin dashboard to crash/500 when the Chewy client info version number value is nil. This occurs when running another ES-compatible backend such as MeiliSearch. Obviously it would be good for chewy to recognise upstream but at least avoiding the crash would be fine.	2 years ago
Jeong Arm	e8cc63105f	Don't delivery a reply to domains which are blocked by author (#22117 ) Co-authored-by: Claire <claire.github-309c@sitedethib.com>	2 years ago
Claire	c8849d6cee	Fix unbounded recursion in account discovery (#22025 ) * Fix trying to fetch posts from other users when fetching featured posts * Rate-limit discovery of new subdomains * Put a limit on recursively discovering new accounts	2 years ago
Claire	68d1df8bc3	Fix some performance issues with /admin/instances (#21907 ) /admin/instances?availability=failing remains wholly unefficient	2 years ago
Kaspar V	47f0d7021e	refactor(vacuum statuses): reduce amount of db queries and load for each query - improve performance (#21487 ) * refactor(statuses_vacuum): remove dead code - unused Method is not called inside class and private. Clean up dead code. * refactor(statuses_vacuum): make retention_period present test explicit This private method only hides functionality. It is best practice to be as explicit as possible. * refactor(statuses_vacuum): improve query performance - fix statuses_scope having sub-select for Account.remote scope by `joins(:account).merge(Account.remote)` - fix statuses_scope unnecessary use of `Status.arel_table[:id].lt` because it is inexplicit, bad practice and even slower than normal `.where('statuses.id < ?'` - fix statuses_scope remove select(:id, :visibility) for having reusable active record query batches (no re queries) - fix vacuum_statuses! to use in_batches instead of find_in_batches, because in_batches delivers a full blown active record query result, in stead of an array - no requeries necessary - send(:unlink_from_conversations) not to perform another db query, but reuse the in_batches result instead. - remove now obsolete remove_from_account_conversations method - remove_from_search_index uses array of ids, instead of mapping the ids from an array - this should be more efficient - use the in_batches scope to call delete_all, instead of running another db query for this - because it is again more efficient - add TODO comment for calling models private method with send * refactor(status): simplify unlink_from_conversations - add `has_many through:` relation mentioned_accounts - use model scope local instead of method call `Status#local?` - more readable add account to inbox_owners when account.local? * refactor(status): searchable_by way less sub selects These queries all included a sub-select. Doing the same with a joins should be more efficient. Since this method does 5 such queries, this should be significant, since it technically halves the query count. This is how it was: ```ruby [3] pry(main)> Status.first.mentions.where(account: Account.local, silent: false).explain Status Load (1.6ms) SELECT "statuses".* FROM "statuses" WHERE "statuses"."deleted_at" IS NULL ORDER BY "statuses"."id" DESC LIMIT $1 [["LIMIT", 1]] Mention Load (1.5ms) SELECT "mentions".* FROM "mentions" WHERE "mentions"."status_id" = $1 AND "mentions"."account_id" IN (SELECT "accounts"."id" FROM "accounts" WHERE "accounts"."domain" IS NULL) AND "mentions"."silent" = $2 [["status_id", 109382923142288414], ["silent", false]] => EXPLAIN for: SELECT "mentions".* FROM "mentions" WHERE "mentions"."status_id" = $1 AND "mentions"."account_id" IN (SELECT "accounts"."id" FROM "accounts" WHERE "accounts"."domain" IS NULL) AND "mentions"."silent" = $2 [["status_id", 109382923142288414], ["silent", false]] QUERY PLAN ------------------------------------------------------------------------------------------------------------------ Nested Loop (cost=0.15..23.08 rows=1 width=41) -> Seq Scan on accounts (cost=0.00..10.90 rows=1 width=8) Filter: (domain IS NULL) -> Index Scan using index_mentions_on_account_id_and_status_id on mentions (cost=0.15..8.17 rows=1 width=41) Index Cond: ((account_id = accounts.id) AND (status_id = '109382923142288414'::bigint)) Filter: (NOT silent) (6 rows) ``` This is how it is with this change: ```ruby [4] pry(main)> Status.first.mentions.joins(:account).merge(Account.local).active.explain Status Load (1.7ms) SELECT "statuses".* FROM "statuses" WHERE "statuses"."deleted_at" IS NULL ORDER BY "statuses"."id" DESC LIMIT $1 [["LIMIT", 1]] Mention Load (0.7ms) SELECT "mentions".* FROM "mentions" INNER JOIN "accounts" ON "accounts"."id" = "mentions"."account_id" WHERE "mentions"."status_id" = $1 AND "accounts"."domain" IS NULL AND "mentions"."silent" = $2 [["status_id", 109382923142288414], ["silent", false]] => EXPLAIN for: SELECT "mentions".* FROM "mentions" INNER JOIN "accounts" ON "accounts"."id" = "mentions"."account_id" WHERE "mentions"."status_id" = $1 AND "accounts"."domain" IS NULL AND "mentions"."silent" = $2 [["status_id", 109382923142288414], ["silent", false]] QUERY PLAN ------------------------------------------------------------------------------------------------------------------ Nested Loop (cost=0.15..23.08 rows=1 width=41) -> Seq Scan on accounts (cost=0.00..10.90 rows=1 width=8) Filter: (domain IS NULL) -> Index Scan using index_mentions_on_account_id_and_status_id on mentions (cost=0.15..8.17 rows=1 width=41) Index Cond: ((account_id = accounts.id) AND (status_id = '109382923142288414'::bigint)) Filter: (NOT silent) (6 rows) ```	2 years ago
Claire	71c92d3f56	Fix emoji substitution not applying only to text nodes in backend code (#20641 ) Signed-off-by: Claire <claire.github-309c@sitedethib.com> Signed-off-by: Claire <claire.github-309c@sitedethib.com>	2 years ago
Bearice Ren	28cda42af5	fixes ArgumentError when proxy is used (#20420 ) * fixes ArgumentError when proxy is used * Update app/lib/request.rb Co-authored-by: Claire <claire.github-309c@sitedethib.com> Co-authored-by: Eugen Rochko <eugen@zeonfederated.com> Co-authored-by: Claire <claire.github-309c@sitedethib.com>	2 years ago
Eugen Rochko	f8e8e622e5	Change incoming activity processing to happen in `ingress` queue (#20264 )	2 years ago
James Tucker	78a6b871fe	Improve performance by avoiding regex construction (#20215 ) ```ruby 10.times { p /#{FOO}/.object_id } 10.times { p FOO_RE.object_id } ```	2 years ago
Claire	c989faaa62	Change Request connection logic to try both IPv6 and IPv4 when available (#20108 ) Fixes #19751	2 years ago
James Tucker	833d9c2f1c	Improve performance by avoiding method cache busts (#19957 ) Switch to monkey-patching http.rb rather than a runtime extend of each response, so as to avoid busting the global method cache. A guard is included that will provide developer feedback in development and test environments should the monkey patch ever collide.	2 years ago
Claire	3114c826a7	Fix filter handling in status cache hydration (#19963 )	2 years ago
Claire	bb89f83cc0	Fix additional issues with status cache hydration (#19747 ) * Spare one SQL query when hydrating polls * Improve tests * Fix more discrepancies * Fix possible crash when the status has no application set	2 years ago

1 2 3 4 5 ...

764 Commits (c35e3cb6ac33e23d3b189edddf3bad6a671070fa)